[PATCH] Ugh. The three RRNotify events don't have 'window' at the same offset in the wire structures.

Keith Packard keithp at keithp.com
Wed Aug 13 12:42:46 PDT 2008

On Wed, 2008-08-13 at 10:26 -0400, Adam Jackson wrote:

> > Also saw this: 'configTimestamp' from the xRROutputChangeNotifyEvent 
> > wire structure is never used. In randrproto.h the two fields 'timestamp' 
> > and 'configTimestamp' have the same comments. If 'configTimestamp' is 
> > just padding, it should be labeled as such.
> Not sure what this is about.  Keith?

configTimestamp is leftover from RandR 1.1 semantics where config
requests would be ignored if they referred to 'stale' configuration
data. That was required because the config data was full of references
to indices in the specific set of data returned in the last query.

Now that everything uses fairly stable XIDs, I decided that there really
wasn't any reason to check that value anymore, and plenty of reasons
*not* to, like failed configuration when hot-plug detection was

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20080813/1ecb4da7/attachment.pgp>

More information about the xorg mailing list