xf86SetGamma crashes the server [Re: xserver: Branch 'master']

[Maarten Maathuis]

I should swap the reply button for reply to all :-)

On 12/17/2008 10:50 PM, Maarten Maathuis wrote:
> On 12/17/2008 09:33 PM, Aaron Plattner wrote:
>> On Wed, Dec 17, 2008 at 08:05:24AM -0800, Maarten Maathuis wrote:
>>>   hw/xfree86/common/Makefile.am  |    2
>>>   hw/xfree86/common/xf86Helper.c |    6 +
>>>   hw/xfree86/common/xf86cmap.c   |    5 +
>>>   hw/xfree86/modes/xf86Crtc.c    |  128 
>>> ++++++++++++++++++++++++++++++++++++++++-
>>>   hw/xfree86/modes/xf86Crtc.h    |   16 +++++
>>>   hw/xfree86/modes/xf86RandR12.c |   52 ++++++++++++++++
>>>   randr/randrstr.h               |   12 +++
>>>   randr/rrcrtc.c                 |   35 ++++++++++-
>>>   8 files changed, 249 insertions(+), 7 deletions(-)
>>>
>>> New commits:
>>> commit 91f73b79b7ae64e5b846d1efeb470bb61a913720
>>> Author: Maarten Maathuis<madman2003 at gmail.com>
>>> Date:   Wed Dec 17 16:56:26 2008 +0100
>>>
>>>      randr: Improve per-crtc gamma support.
>>>
>>>      - The Gamma values from the monitor section are now used during 
>>> initial config.
>>>      - The old colormap system is disabled when gamma set hook is 
>>> available.
>>>      - Gamma values are now persistent for the lifetime of the xserver.
>>>      - This requires no driver changes and should be driver ABI 
>>> compatible.
>>
>
> I've got some changes pending, i'll add a check for non-NULL'ness of 
> xf86_config as well.
>
>> Program received signal SIGSEGV, Segmentation fault.
>> [Switching to Thread 0x7f1c582006f0 (LWP 15464)]
>> 0x000000000047126b in xf86_crtc_supports_gamma (pScrn=0x899ac0) at 
>> /home/aaron/X/modular/xserver/hw/xfree86/modes/xf86Crtc.c:3146
>> 3146        for (c = 0; c<  xf86_config->num_crtc; c++) {
>> (gdb) bt
>> #0  0x000000000047126b in xf86_crtc_supports_gamma (pScrn=0x899ac0) 
>> at /home/aaron/X/modular/xserver/hw/xfree86/modes/xf86Crtc.c:3146
>> #1  0x000000000045966b in xf86SetGamma (scrp=0x899ac0, gamma={red = 
>> 0, green = 0, blue = 0})
>>      at /home/aaron/X/modular/xserver/hw/xfree86/common/xf86Helper.c:925
>> #2  0x00007f1c54264788 in VESAPreInit (pScrn=0x899ac0, flags=<value 
>> optimized out>)
>>      at /home/aaron/X/modular/driver/xf86-video-vesa/src/vesa.c:640
>> #3  0x0000000000453ab8 in InitOutput (pScreenInfo=0x8702a0, argc=4, 
>> argv=0x7fff60336308)
>>      at /home/aaron/X/modular/xserver/hw/xfree86/common/xf86Init.c:1007
>> #4  0x0000000000428315 in main (argc=4, argv=0x7fff60336308, 
>> envp=0x7fff60336330) at /home/aaron/X/modular/xserver/dix/main.c:308
>> (gdb) p xf86_config
>> $1 = (xf86CrtcConfigPtr) 0x21
>> (gdb) p xf86CrtcConfigPrivateIndex
>> $2 = -1
>> _______________________________________________
>> xorg mailing list
>> xorg at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/xorg
>