xorg/driver/xf86-input-citron - [PATCH] Don't call xf86SoundKbdBell and xf86XInputSetSendCoreEvents

Peter Hutterer mailinglists at who-t.net
Sun Feb 3 17:19:01 PST 2008


Paulo Cesar Pereira de Andrade wrote:
 >>From db54ce9ef38b2b6d6f5991bf8fc0a9dface11907 Mon Sep 17 00:00:00 2001
 > From: Paulo Cesar Pereira de Andrade <pcpa at mandriva.com.br>
 > Date: Wed, 30 Jan 2008 16:47:18 -0200
 > Subject: [PATCH] Don't call xf86SoundKbdBell and 
xf86XInputSetSendCoreEvents
 >
 > Only call those functions if GET_ABI_MAJOR(ABI_XINPUT_VERSION) == 0.
 > ---
 >  src/citron.c |    4 ++++
 >  1 files changed, 4 insertions(+), 0 deletions(-)
 >
 > diff --git a/src/citron.c b/src/citron.c
 > index 42152b5..e024370 100644
 > --- a/src/citron.c
 > +++ b/src/citron.c
 > @@ -169,7 +169,9 @@ char version[]="Touch Driver V2.2.0  (c) 
1999-2006 Citron GmbH";
 >  /* extern void xf86SoundKbdBell(int loudness, int pitch, int 
duration); */
 >
 >  /* #define CIT_TIM	*/	/* Enable timer */
 > +#if GET_ABI_MAJOR(ABI_XINPUT_VERSION) == 0
 >  #define CIT_BEEP		/* enable beep feature */
 > +#endif

I'm not particularly happy about this hunk.

please put the ifdef into the cit_Beep and cit_BeepKey functions.

Cheers,
    Peter






More information about the xorg mailing list