drm vblank memory allocation

Jesse Barnes jbarnes at virtuousgeek.org
Mon Jul 7 12:06:04 PDT 2008


On Sunday, July 06, 2008 12:29 am vehemens wrote:
> Would anyone object to using a struct for the vblank crtc data to eliminate
> the multiple allocs / frees?
>
> For example:
>
> struct drm_vblank {
>         wait_queue_head_t vbl_queue;
>         atomic_t _vblank_count;
>         struct drm_vbl_sig_list vbl_sigs;
>         atomic_t vblank_refcount;
>         u32 last_vblank;
>         int vblank_enabled;
>         u32 vblank_premodeset;
>         u32 vblank_suspend;
> };

Sure, seems like a reasonable change to gather up all the vblank related 
fields.  We probably would have done this initially, but the number of fields 
started out much smaller than it is today. :)

Jesse



More information about the xorg mailing list