[PATCH] Notify DRI when crtc regions change

Adam Jackson ajax at nwnk.net
Tue Nov 4 12:48:07 PST 2008


On Tue, 2008-11-04 at 10:04 -0800, Keith Packard wrote:
> On Tue, 2008-11-04 at 10:35 -0500, Adam Jackson wrote:
> 
> > Please put this in the rrScrPrivRec instead.  When we finally finish
> > multi-GPU support in RANDR this will want to be per-ScreenRec.
> 
> Yeah, I can imagine other extensions that will want to know when the
> crtc configuration has changed. I was mostly interested in getting
> review on whether this approach makes sense for DRI, or if there should
> be some different method here.

I think it makes sense, although I'm kind of surprised we don't pick up
on it from ClipNotify on the root window.  Still rotation is basically a
catastrophic clip change so might as well recompute the world.

> > (At which point it should probably be a proper wrap chain as well.)
> 
> In the traditional style, there wouldn't be any API, just a public
> structure with the callback in place. Should we start exposing an
> abstract interface to wrapping?

If we wanted a standard macro set I wouldn't complain.  I'm loathe to
introduce more function calls to the standard wrap chains though, O(n)
devprivates was a bad enough performance hit to make me hesitant to
introduce more things that grow linearly with number of subsystems.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20081104/f173fd26/attachment.pgp>


More information about the xorg mailing list