[PATCH] Removal of a needless null statement
Paulo César Pereira de Andrade
pcpa at mandriva.com.br
Sat Nov 8 14:55:16 PST 2008
>>>>>> "Fernando" == Fernando Carrijo <fcarrijo at yahoo.com.br> writes:
>
> Fernando> ... and there are still others. XCB and libX11, to list a few!
>
> Yes, we have to look in the other repos as well. Git grep makes is
> relatively easy, but only works one repo at a time.
>
> I'll get the ones in app and lib, but I lack commit privs on XCB and
> don't want to step on any toes for the drivers.
>
> The affected drivers are:
>
> xf86-input-digitaledge xf86-input-hyperpen xf86-input-summa
> xf86-video-ast xf86-video-cyrix xf86-video-i128 xf86-video-i740
> xf86-video-intel xf86-video-nsc xf86-video-savage xf86-video-sis
> xf86-video-sisusb xf86-video-ati
I remember there were also a few cases of code like:
#define macro(object) (object)->field;
that would generate warnings of mixed code and declarations, as these
macros were used in code like:
type
function(arguments)
{
type variable = macro(object);
type other_variable;
...
}
> -JimC
Paulo
More information about the xorg
mailing list