[PATCH 1/5] handle extenion for detail timing block
Adam Jackson
ajax at nwnk.net
Tue Nov 18 12:44:18 PST 2008
On Mon, 2008-11-17 at 16:33 +0800, ling.ma at intel.com wrote:
> From: MaLing<ling.ma at intel.com>
> +struct hdmi {
> + Uchar Support_flags;
> + Uchar Max_TMDS_Clock;
> + Uchar Latency_Present;
> + Uchar Video_Latency;
> + Uchar Audio_Latency;
> + Uchar Interlaced_Video_Latency;
> + Uchar Interlaced_Audio_Latency;
> +};
Please, CamelCase or underscore_separated_names, but Not_Both.
> @@ -286,11 +381,11 @@ get_std_timing_section(Uchar *c, struct std_timings *r,
>
> static void
> get_dt_md_section(Uchar *c, struct edid_version *ver,
> - struct detailed_monitor_section *det_mon)
> + struct detailed_monitor_section *det_mon, int det_mon_num)
> {
> int i;
>
> - for (i=0;i<DET_TIMINGS;i++) {
> + for (i=0;i<det_mon_num;i++) {
> if (ver->version == 1 && ver->revision >= 1 && IS_MONITOR_DESC) {
>
> switch (MONITOR_DESC_TYPE) {
This just walks over the base block, walking from 0 to (det_mon_num-1)
is wrong since det_mon_num will count detailed blocks found in extension
blocks. Should just drop the changes to this function.
- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20081118/eede6f73/attachment.pgp>
More information about the xorg
mailing list