[Patch 01/02] mieq threading prep: Only increment tail (push) when the event data is actually in the queue

Jeremy Huddleston jeremyhu at freedesktop.org
Tue Nov 18 21:59:15 PST 2008


On Nov 18, 2008, at 11:54, Simon Thum wrote:

> Jeremy Huddleston wrote:
>> -    unsigned int           oldtail = miEventQueue.tail, newtail;
>> +    unsigned int           oldtail = miEventQueue.tail;
> All fine, but is there a specific reason to remove newtail? Not that  
> I'd
> expect this to save more than one or two cycles on any platform...

I just thought it was adding to namespace polution, TBH... no "real"  
reason... and with any level of optimization, you'll get back those  
two cycles.  I can revert that "part" if you really care.

--Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5708 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20081118/b2cb53dd/attachment.bin>


More information about the xorg mailing list