[PATCH] [pixmap] rename/convert devKind and devPrivate fields

Maarten Maathuis madman2003 at gmail.com
Tue Oct 7 13:19:25 PDT 2008


On Tue, Oct 7, 2008 at 10:09 PM, Aaron Plattner
<aplattner at freedesktop.org> wrote:
> On Tue, Oct 07, 2008 at 08:04:52PM +0200, Maarten Maathuis wrote:
>> These names are supposedly historical, but everyone seems to use them
>> for the same purpose.
>> I am aware this may require a few minor changes to (for example) exa
>> drivers with driver based memory allocations.
>> I personally believe in having clear names rather than some obscure
>> remnant of the past. I removed the devPrivate considering the void
>> pointer is the only useful part anyway.
>>
>> It would be nice to know if all !xfree86 has the equivilant of
>> VIDEODRV_ABI_VERSION.
>>
>> Anyway, share your thoughts, comments and such.
>
> It seems unfortunate to break the API just to rename a few fields.  While I
> can understand wanting to make the naming clearer, if we're going to change
> the API can we please strive to make it better, rather than just different?
>
> -- Aaron
>

Anything particular you have in mind?



More information about the xorg mailing list