[PATCH] [pixmap] rename/convert devKind and devPrivate fields

[Dave Airlie]

On Fri, Oct 10, 2008 at 3:18 AM, Maarten Maathuis <madman2003 at gmail.com> wrote:
> On Thu, Oct 9, 2008 at 9:34 AM, Michel Dänzer
> <michel at tungstengraphics.com> wrote:
>> On Wed, 2008-10-08 at 19:20 +0200, Maarten Maathuis wrote:
>>> On Tue, Oct 7, 2008 at 8:04 PM, Maarten Maathuis <madman2003 at gmail.com> wrote:
>>> > These names are supposedly historical, but everyone seems to use them
>>> > for the same purpose.
>>> > I am aware this may require a few minor changes to (for example) exa
>>> > drivers with driver based memory allocations.
>>> > I personally believe in having clear names rather than some obscure
>>> > remnant of the past. I removed the devPrivate considering the void
>>> > pointer is the only useful part anyway.
>>> >
>>> > It would be nice to know if all !xfree86 has the equivilant of
>>> > VIDEODRV_ABI_VERSION.
>>> >
>>> > Anyway, share your thoughts, comments and such.
>>> >
>>> > Maarten.
>>> >
>>> > PS. i can commit these myself, this is just for review, considering
>>> > it's a non-trivial change.
>>> >
>>>
>>> Any thoughts about other stuff needing change in the pixmap (or maybe
>>> the closely related drawable)? I'm openminded to change, so it seems
>>> sensible to check if there are any other problems out there. Without
>>> any further complaints i'll probably go ahead with this in a few days.
>>
>> I'm not sure this is worth the pain for drivers...
>>
>>
>> --
>> Earthling Michel Dänzer           |          http://tungstengraphics.com
>> Libre software enthusiast         |          Debian, X and DRI developer
>>
>>
>
> Are you thinking of anything besides ddx drivers? (i checked ati, it
> has about 5 instances, intel about 12, a simple macro could serve as a
> drop in replacement)

It totally messes up the ability to do git bisections and such for 0 value other
than changing some names. The gain isn't outweighing much.

Dave.

>
> Maarten.
> _______________________________________________
> xorg mailing list
> xorg at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/xorg
>