Current tinderbox regression (libxcb)

[Dan Nicholson]

On Tue, Oct 14, 2008 at 1:40 PM, Chris Ball <cjb at laptop.org> wrote:
> http://tinderbox.x.org/builds/2008-10-14-0029/
> http://tinderbox.x.org/builds/2008-10-14-0029/logs/libxcb/#build
> http://cgit.freedesktop.org/xcb/libxcb/diff/configure.ac?id=cebd482a20fcc2b2dae0683c38e917a3740638a6
>
> In file included from xcbint.h:34,
>                 from xcb_in.c:38:
> config.h:74:31: warning: '$' in identifier or number
> In file included from xcb_in.c:38:
> xcbint.h:75: error: '$xcb_queue_buffer_size' undeclared here

+dnl define buffer queue size
+xcb_queue_buffer_size=16384
+AC_DEFINE(XCB_QUEUE_BUFFER_SIZE, $xcb_queue_buffer_size, [XCB buffer
queue size])
+AC_ARG_WITH(queue-size,
+ AC_HELP_STRING([--with-queue-size=SIZE],
+ [Set the XCB buffer queue size (default is 16384)]),
+ [AC_DEFINE_UNQUOTED(XCB_QUEUE_BUFFER_SIZE, $withval, [XCB buffer queue size]),
+ xcb_queue_buffer_size=$withval],
+ )
+

I think AC_DEFINE_UNQUOTED and the m4 [] quotes are needed in both
cases to guarantee that the shell variable is expanded. But it's
probably not a good idea to run AC_DEFINE twice on the same macro.
Something like this might be better:

dnl define buffer queue size
AC_ARG_WITH([queue-size],
    AC_HELP_STRING([--with-queue-size=SIZE],
        [Set the XCB buffer queue size (default is 16384)]),
    [xcb_queue_buffer_size="$withval"],
    [xcb_queue_buffer_size=16384]
)
AC_DEFINE_UNQUOTED(XCB_QUEUE_BUFFER_SIZE, [$xcb_queue_buffer_size],
[XCB buffer queue size])

--
Dan