Current tinderbox regression (libX11)

[James Cloos]

[Grrr.  Forgot to CC the list.... -JimC]

>>>>> "Chris" == Chris Ball <cjb at laptop.org> writes:

Chris> http://tinderbox.x.org/builds/2008-10-25-0007/
Chris> http://tinderbox.x.org/builds/2008-10-25-0007/logs/libX11/#build

Chris> /bin/sh: line 1: 17581 Segmentation fault      ../src/util/makekeys <
Chris> /home/cjb/xorg-build/include/X11/keysymdef.h > ks_tables_h

I got a divide-by-zero error instead of a segv; assuming it is due to
the same bug, I just pushed a work-around:

commit b1022fa6d7e97640049e93ffa108083fc8d71b05
Author: James Cloos <cloos at jhcloos.com>
Date:   Sat Oct 25 09:12:45 2008 -0400

    Increase size of working arrays in the makekeys utility program.
    
    Makekeys is used to create an optimal hash of the keysyms defined
    in x11proto’s keysymdef.h.
    
    The recent addition of new keysyms there has triggered a bug in
    makekeys where it tries to use a zero on the rhs of the % (mod)
    operator (resulting in a divide by zero error) whenever it fails
    to find a solution within its constraints.
    
    Increasing the size of the arrays allows it to find a solution for
    the current set of keysyms.
    
    Makekeys is only run durring the build process, so this has no impact
    on users of libX11, only on the amount of VM needed to build it.
    
    It still needs a more complete fix, but this allows compiles to
    progress until that is completed.

-JimC
-- 
James Cloos <cloos at jhcloos.com>         OpenPGP: 1024D/ED7DAEA6