[PATCH 3/3] Xi: ask handlers before deletion of property.
Simon Thum
simon.thum at gmx.de
Mon Sep 22 02:30:59 PDT 2008
Hi Peter,
its good news you're done with that. A thing though:
> -DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop)
> +DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop,
> + BOOL delete)
> {
> if (property == XIGetKnownProperty(XI_PROP_ENABLED))
> {
> + if (delete) /* you're not allowed to delete any server-internal prop */
> + return BadAccess;
> +
Isn't that impossible anyway? If not, how about XI_PROP_MODE?
In general, I must admit I don't really get the scenario: Client props
don't have handlers, and server-side props can only be deleted by
in-server code, right?
So what problem does the patch solve, then?
Cheers,
Simon
More information about the xorg
mailing list