[PATCH] xkb: fix core keyboard map generation. #14373

[Daniel Stone]

On Mon, Sep 22, 2008 at 12:15:33PM +0930, Peter Hutterer wrote:
> According to Section 12.4 of the XKB Protocol Spec, if a key only has a single
> group but the keyboard has multiple groups defined, the core description of
> the key is a duplication of the single group across all symbols. i.e.
> G1L1 G1L2 G1L1 G1L2 G1L3 G1L4 G1L3 G1L4
> 
> The previous code generated G1L1 G1L2 G1L3 G1L4 G1L3 G1L4, leading to
> "invented" groups when the process is reversed.
> 
> Note that this creates wrong key types on reconstruction from core to xkb,
> i.e. any single-group key with a key type that is not one of the canonical
> four (Sec 12.2.3), will get the assigned type on group 1, and a canonical type
> for the other gruops.
> 
> X.Org Bug 14373 <http://bugs.freedesktop.org/show_bug.cgi?id=14373>

Nice catch! ACK to both patches, though untested.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20080922/547fddea/attachment.pgp>