[PATCH] __GLX_MEM_COPY() is never used on possible NULL pointers

[Peter Hutterer]

On Wed, Feb 04, 2009 at 12:05:57AM +0100, Tomas Carnecky wrote:
> Signed-off-by: Tomas Carnecky <tom at dbservice.com>
> ---
>  glx/unpack.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/glx/unpack.h b/glx/unpack.h
> index a1dd17d..675d8cc 100644
> --- a/glx/unpack.h
> +++ b/glx/unpack.h
> @@ -47,7 +47,7 @@
>  ** Fetch a double from potentially unaligned memory.
>  */
>  #ifdef __GLX_ALIGN64
> -#define __GLX_MEM_COPY(dst,src,n)	if (src && dst) memcpy(dst,src,n)
> +#define __GLX_MEM_COPY(dst,src,n)	memcpy(dst,src,n)
>  #define __GLX_GET_DOUBLE(dst,src)	__GLX_MEM_COPY(&dst,src,8)
>  #else
>  #define __GLX_GET_DOUBLE(dst,src)	(dst) = *((GLdouble*)(src))
> -- 
> 1.6.1.2
 
Can you provide a bit more context for this? Why is removing the check
beneficial?

Cheers,
  Peter