[PATCH] Fix "warning: format not a string literal and no format arguments"

Tomas Carnecky tom at dbservice.com
Wed Feb 4 06:22:28 PST 2009


Signed-off-by: Tomas Carnecky <tom at dbservice.com>
---

static char* __xtransname = "...";

The variable is initialized to different strings depending on
a preprocessor define. A different fix would be to make __xtransname
itself a preprocessor define. But I think the following fix does
work equally well.

 Xtransint.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Xtransint.h b/Xtransint.h
index 523751e..623cdef 100644
--- a/Xtransint.h
+++ b/Xtransint.h
@@ -372,7 +372,7 @@ static int trans_mkdir (
 			int hack= 0, saveerrno=errno; \
                         struct timeval tp;\
                         gettimeofday(&tp,0); \
-			ErrorF(__xtransname); \
+			ErrorF("%s",__xtransname);	\
 			ErrorF(x+hack,a,b,c); \
                         ErrorF("timestamp (ms): %d\n",tp.tv_sec*1000+tp.tv_usec/1000); \
 			errno=saveerrno; \
@@ -382,7 +382,7 @@ static int trans_mkdir (
 			int hack= 0, saveerrno=errno; \
                         struct timeval tp;\
                         gettimeofday(&tp,0); \
-			fprintf(stderr, __xtransname); fflush(stderr); \
+			fprintf(stderr, "%s", __xtransname); fflush(stderr); \
 			fprintf(stderr, x+hack,a,b,c); fflush(stderr); \
                         fprintf(stderr, "timestamp (ms): %d\n",tp.tv_sec*1000+tp.tv_usec/1000); \
                         fflush(stderr); \
@@ -394,14 +394,14 @@ static int trans_mkdir (
 /* Use ErrorF() for the X server */
 #define PRMSG(lvl,x,a,b,c)	if (lvl <= XTRANSDEBUG){ \
 			int hack= 0, saveerrno=errno; \
-			ErrorF(__xtransname); \
+			ErrorF("%s",__xtransname);    \
 			ErrorF(x+hack,a,b,c); \
 			errno=saveerrno; \
 			} else ((void)0)
 #else
 #define PRMSG(lvl,x,a,b,c)	if (lvl <= XTRANSDEBUG){ \
 			int hack= 0, saveerrno=errno; \
-			fprintf(stderr, __xtransname); fflush(stderr); \
+			fprintf(stderr, "%s", __xtransname); fflush(stderr); \
 			fprintf(stderr, x+hack,a,b,c); fflush(stderr); \
 			errno=saveerrno; \
 			} else ((void)0)
-- 
1.6.1.2





More information about the xorg mailing list