[PATCH] Fix two warnings about incompatible pointer types

Tomas Carnecky tom at dbservice.com
Wed Feb 4 12:14:51 PST 2009


On 02/04/2009 09:00 PM, Thomas Dickey wrote:
> On Wed, Feb 04, 2009 at 08:36:49PM +0100, Tomas Carnecky wrote:
>> diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
>> index 732a1fd..6b9b8f0 100644
>> --- a/hw/xfree86/common/xf86Helper.c
>> +++ b/hw/xfree86/common/xf86Helper.c
>> @@ -2738,5 +2738,5 @@ int
>>   xf86GetMotionEvents(DeviceIntPtr pDev, xTimecoord *buff, unsigned long start,
>>                       unsigned long stop, ScreenPtr pScreen, BOOL core)
>>   {
>> -    return GetMotionHistory(pDev, buff, start, stop, pScreen, core);
>> +    return GetMotionHistory(pDev, (xTimecoord **) buff, start, stop, pScreen, core);
>
> that presumably quiets a warning, but it's unlikely to be correct.

Indeed, 0b88510069bd changes the prototype and implementation of 
GetMotionHistory(). So all the callers of xf86GetMotionEvents() should 
also be updated, but I haven't found any. Hence my question whether this 
function is still being used.

(Cc: author of said commit)

tom




More information about the xorg mailing list