Question wrt xf86ReadMmio{8,16}

Adam Jackson ajax at nwnk.net
Wed Feb 4 14:32:43 PST 2009


On Sat, 2009-01-31 at 13:22 -0500, Matt Turner wrote:
> Hi,
> 
> xf86ReadMmio{8,16} both return a 32-bit int. Should the result be zero
> or sign extended?

Zero, if I had to pick.  The things you're reading are like as not to be
bitfields, so it's not like sign extension would be meaningful.  But
it's probably better to change them to return the right type.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20090204/a589c6d5/attachment.pgp>


More information about the xorg mailing list