[PATCH] Fix "warning: unused variable XXX"

[Peter Hutterer]

On Wed, Feb 04, 2009 at 01:56:08PM -0800, Ian Romanick wrote:
> On Tue, Feb 03, 2009 at 11:54:53PM +0100, Tomas Carnecky wrote:
> 
> > diff --git a/dix/events.c b/dix/events.c
> > index 0c8d198..2a35aa3 100644
> > --- a/dix/events.c
> > +++ b/dix/events.c
> > @@ -4611,7 +4611,6 @@ ProcQueryPointer(ClientPtr client)
> >      xQueryPointerReply rep;
> >      WindowPtr pWin, t;
> >      DeviceIntPtr mouse = PickPointer(client);
> > -    DeviceIntPtr kbd = PickKeyboard(client);
> 
> Are you sure that PickKeyboard doesn't have any side-effect?  It seems
> unlikely, but it's better to check and be sure.

PickKeyboard has one side-effect: if no ClientPointer is assigned yet, it'll
assign the selected one to this client. In this case, this is a noop, as
PickPointer has done so already anyway.

If we didn't have the PickPointer() call it'd still be wrong, as we shouldn't
force a ClientPointer if we don't need one right now anyway.

Cheers,
  Peter