[PATCH] xkb: Set sane build time XKB defaults

Alan Coopersmith Alan.Coopersmith at Sun.COM
Wed Jan 14 13:19:58 PST 2009



Daniel Stone wrote:
> On Sat, Jan 10, 2009 at 02:40:04PM +0200, Daniel Stone wrote:
>> On Wed, Jan 07, 2009 at 08:27:39AM -0800, Dan Nicholson wrote:
>>> On Wed, Jan 7, 2009 at 7:44 AM, Daniel Stone <daniel at fooishbar.org> wrote:
>>>> NAK of sorts: I'd like to fix this properly.  In particular, hardcoded
>>>> paths are not the way.
>>> Sure. However, as it stands on both master and 1.6-branch, all the DDX
>>> except Xorg start with these defaults. So, they have an invalid
>>> default model of "dflt" as far as I can tell. Also, the
>>> XKB_BASE_DIRECTORY setting could be dropped from this patch. It's
>>> always defined in configure, so the hardcoded /usr/share/X11/xkb
>>> should never actually get used.
>>>
>>> What did you have in mind to fix this properly?
>> Something like this?
> 
> Or maybe even something like this, rather ...

The attached updated version worked better for me - fixes the Xnest issue
I mentioned previously, and makes the --with-default-xkb-* options work
by using the same variable names as used later in configure.ac.   It also
updates the default rules definition exported to drivers in xorg-server.h
to the new name -  still need to update at least xf86-input-keyboard to use
the new define if it's present, haven't checked any other drivers.

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xkb-defaults.patch
Type: text/x-patch
Size: 11292 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090114/b179b69e/attachment.bin>


More information about the xorg mailing list