XORG_MACROS_VERSION test is filled with hate

[Ian Romanick]

I think these lines, when added to configure.ac don't do what they're
intended to do:

m4_ifndef([XORG_MACROS_VERSION], [AC_FATAL([must install xorg-macros 1.2
or later before running autoconf/autogen])])
XORG_MACROS_VERSION(1.2)

I run autogen.sh in, for example, app/rendercheck as:

CC=gcc ACLOCAL="aclocal -I /opt/xorg-master-x86_64/share/aclocal"
sh ./autogen.sh --prefix=/opt/xorg-master-x86_64
--libdir=/opt/xorg-master-x86_64/lib64 --disable-dmx --disable-xvfb
--disable-xnest --disable-xwin --disable-xgl --disable-xglx
--disable-xegl --disable-kdrive --disable-xprint --enable-glx
--enable-glx-tls --enable-dri CFLAGS="-momit-leaf-frame-pointer
-march=core2"

The xorg-macros.m4 in /opt/xorg-master-x86_64/share/aclocal is version
1.2.1:

[idr at oscar rendercheck]$ grep
1.2. /opt/xorg-master-x86_64/share/aclocal/xorg-macros.m4 
	[XORG_MACROS_version=1.2.1
# Minimum version: 1.2.0
# Minimum version: 1.2.0

But I get the error message:

checking if xorg-macros used to generate configure is at least 1.2...
configure: error: configure built with too old of a version of
xorg-macros.m4 - requires version 1.1.0 or newer

My first question is WTF?  My second question is do people who commit
changes to the build system even test that their changes continue to
build?  About once a month I have to chase down a build failure caused
by something stupid.  It's really frustrating.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20090120/97ef01e1/attachment.pgp>