[PATCH] Update synaptics to XInput 7 ABI

Peter Hutterer peter.hutterer at who-t.net
Sun Jun 21 23:59:52 PDT 2009


On Mon, Jun 22, 2009 at 01:56:07AM -0400, Ben Gamari wrote:
> On Fri, Jun 19, 2009 at 04:34:33PM +1000, Peter Hutterer wrote:
> > On Fri, Jun 19, 2009 at 02:01:30AM -0400, Ben Gamari wrote:
> > > > How about this one (obviously on top of fd939)?
> > > 
> > > Looks good (once someone figures out the button label situation).
> > 
> > So getting the labels right is mostly candy now anyway, and getting them
> > for the ones after 7 is something we can worry about in the future, but
> > don't have to worry about right now.
> > 
> 
> Oops, it seems I messed up. When I tested your patches it turned out
> that I wasn't actually testing your patches. It seems that providing a
> label of 0 causes gnome-settings-daemon to crash with the following
> backtrace,
[...]
> Changing the third argument of the InitPointerDeviceStruct() call in
> synaptics' DeviceInit() from SYN_MAX_BUTTONS to 7 avoids the crash.
> Changing it then to 8 (as was done in the case of the above backtrace)
> triggers the crash. Not really sure what to make of this. Let me know
> what you think. Thanks,
> 

server bug, uncovered by 280b7f92d729ec910ffa3d18dce7bbc215be7a3c.
http://bugs.freedesktop.org/show_bug.cgi?id=22392

Cheers,
  Peter



More information about the xorg mailing list