xf86-video-intel : SDVO TV out with Component output: proposing a fix

[Wang, Zhenyu Z]

On 2009.03.31 19:42:02 +0800, Jacques, Hugo wrote:
> > >
> > > (WW) intel(0): SDVOB: Unknown SDVO output type (0x0400)
> > 
> > Interesting, this looks violate SDVO spec. As device shouldn't have xxxx1
> > output
> > unless it has xxxx0 output, and only one TV output, so 0x0400 (CVBS1)
> > should always
> > be invalid. But real hw vendor could possibly break this as your case.
> > 
> 
> Actually, because the code to dump the flag in case of unknown type is not little-endian friendly, an unknown type of 0x0400 in the log actually means 0x0040 which is really CVBS0.  There might not be any SDVO spec violation after all.
> 
> 	memcpy (bytes, &flag, 2);
> 	xf86DrvMsg(intel_output->pI2CBus->scrnIndex, X_WARNING,
> 		   "%s: Unknown SDVO output type (0x%02x%02x)\n",
> 		   SDVO_NAME(dev_priv),
> 		   bytes[0], bytes[1]);
> 

oh, good catch!

> 
> I will post a patch for CVBS0 in the right format at http://bugs.freedesktop.org/show_bug.cgi?id=20947
> 

Pushed! Thanks.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20090401/fe958e34/attachment.pgp>