[PATCH 2/2] kdrive: do not undef DEBUG macro in mouse driver
Olivier Blin
blino at mandriva.com
Wed May 27 10:00:09 PDT 2009
Peter Hutterer <peter.hutterer at who-t.net> writes:
> On Tue, May 26, 2009 at 03:30:14PM +0200, Olivier Blin wrote:
>> The mouse driver had some code to unconditionnally disable debug, even
>> if configured with --enable-debug. This adds back the mouse driver
>> debug output when built with debug option.
>>
>> Signed-off-by: Olivier Blin <blino at mandriva.com>
>> ---
>> hw/kdrive/linux/mouse.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/kdrive/linux/mouse.c b/hw/kdrive/linux/mouse.c
>> index 253da26..8b638ae 100644
>> --- a/hw/kdrive/linux/mouse.c
>> +++ b/hw/kdrive/linux/mouse.c
>> @@ -32,7 +32,6 @@
>> #include "scrnintstr.h"
>> #include "kdrive.h"
>>
>> -#undef DEBUG
>> #undef DEBUG_BYTES
>
> what about DEBUG_BYTES? Is that of any importance? Why is it undef'd?
It looks extremly verbose to enable it, I think it would pollute logs
too much to enable it if DEBUG is on.
I guess it is undef'd explicitely at the top of the file so that people
debugging notice it can be enabled (this code dates from 2001)
--
Olivier Blin (blino) - Mandriva
More information about the xorg
mailing list