XI2 pull warning

[Thomas Jaeger]

Thanks for the quick response.

Peter Hutterer wrote:
> On Thu, May 28, 2009 at 02:54:22PM -0400, Thomas Jaeger wrote:
>> Thanks for the work you've put into this.  I haven't spent a lot of time
>>  testing the new code, but here are my first impressions.  You're
>> probably aware of most of the issues below already, but I'll mention
>> them just in case.
>>
>> * The biggest issue for me right now is reporting of XI1 (see the
>> attached test program).  XSelectExtensionEvents and
>> XGrabDevice/XGrabDeviceButton will only report press events; motion and
>> release events are lost.
> 
> Fixed. missing mask assignment in the case of an explicit passive grab.
Thanks, this is working now.  However, xournal is still won't accept any
input (unless patched) because it discards events due to device_state
not being set correctly.

> 
>> * A driver sending a proximity event crashes the server.
> 
> Fixed, thanks. GetProximityEvents still had the valuator event calculation
> in there and returned a wrong number of events. That, an an uninitialized
> pointer that was only triggerd for proximity events. Both fixes pushed.
Thanks, this is mostly working now.  There are still instances where
proximity events lead to a crash, see the attached gdb session.

>> * XIGrabButton always fails with a BadDevice error.
> 
> Fixed, thanks. The check was in there to prevent passive grabbing of
> attaches slave devices, which in hindsight might have its use-cases though
> dealing with the modifiers can be trick. Documented in inputproto.
It seems like XIGrabButton doesn't accept XIAnyModifier.  Also, the
example code in xinput uses an older incompatible interface (patch
attached).
If XIGrabButton is called on a SD, the SD is not detached when the grab
is activated.

>> * libXi doens't support parallel builds (make -j2) anymore.
> 
> works fine for me, not sure what's going on there.

Okay, fair enough, this is not really important anyway.

Thanks,
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-test-xi2-fix-modifiers-for-XIGrabButton-call.patch
Type: text/x-patch
Size: 781 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090530/8e2a83c6/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: crash.gdb
URL: <http://lists.x.org/archives/xorg/attachments/20090530/8e2a83c6/attachment.ksh>