[PATCH 1/2] Always call the flush callback chain when we might send out damage events

Keith Packard keithp at keithp.com
Sun Aug 1 12:20:14 PDT 2010

On Sun, 1 Aug 2010 14:39:46 -0400, Kristian Høgsberg <krh at bitplanet.net> wrote:
> Before this gets drowned out in janitorial patches... Keith, do you
> want a pull request for this and the damageext patch?  Did you have
> have a look at the damage change?

I read through the change and reviewed the potential impacts on the
server. I'm a little concerned about having the semantics of the damage
extension accidentally change as the code paths for the post-activity
damage region processing. And, I'd love to have that code 'fixed' so
that there wasn't additional region processing needed. So, it's not my
favorite change, but anything additional seems like a riskier
proposition for 1.9.

So, I was planning to merge the damage change along with your other
fixes for 1.9. It'd be lovely to get other people to take another look
at the damage code to see if they can identify potential issues with
your change.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20100801/99d19f45/attachment.pgp>

More information about the xorg mailing list