Problem with xorg-server and s3c2410fb driver

[Adam Jackson]

On Mon, 2010-08-02 at 18:24 +0200, Michel Dänzer wrote:

> AFAICT this will only work when using the 'built-in' mode, otherwise
> mode->PrivFlags will never be set? One possible solution for that could
> be
> 
> - var->pixclock = mode->Clock ? 1000000000/mode->Clock : 0;
> + var->pixclock = mode->PrivFlags ? mode->PrivFlags :
> (mode->Clock ? 1000000000/mode->Clock : 0);
> 
> in xfree2fbdev_timing().

Right you are.

So I guess the question is what we're trying to accomplish with the
fbdev_modes_equal() check at all.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20100802/6c6542b3/attachment.pgp>