[PATCH] os: Don't write the reply that overflows output buffer

Keith Packard keithp at keithp.com
Mon Aug 2 11:36:27 PDT 2010

On Mon,  2 Aug 2010 11:29:55 -0400, Kristian Høgsberg <krh at bitplanet.net> wrote:
> Here's the other approach for fixing damage vs flush client.  In writing the
> commit message, it certainly does feel like damage should just be fixed to
> not reply on that behaviour.  And writing the patch, I realize that the
> optimization is not just about saving a syscall, but also about avoiding
> having to realloc the output buffer to hold a request that's bigger than
> BUFSIZE (hello, XkbSendMap()).  The current code only does that when it
> fails to write the output buffer + extra request and the remaining bytes
> don't fit in a standard sized buffer.

This doesn't really fix the issue as we're potentially sending a stream
of events from the damage extension. We'd have to buffer all of them
until FlushAllOutput, I think.

It is a nice cleanup though; let's look at this post-1.9 separately.

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20100802/9c0cbfea/attachment.pgp>

More information about the xorg mailing list