[PATCH 2/5] build: use proper quoting in autogen.sh

Gaetan Nadon memsize at videotron.ca
Sun Nov 28 10:47:54 PST 2010


On Sun, 2010-11-28 at 15:47 +0100, Jan Engelhardt wrote:

> Signed-off-by: Jan Engelhardt <jengelh at medozas.de>
> ---
>  autogen.sh |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/autogen.sh b/autogen.sh
> index 904cd67..90d2520 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,12 +1,12 @@
>  #! /bin/sh
>  
> -srcdir=`dirname $0`
> +srcdir=`dirname "$0"`
>  test -z "$srcdir" && srcdir=.
>  
>  ORIGDIR=`pwd`
> -cd $srcdir
> +cd "$srcdir"
>  
>  autoreconf -v --install || exit 1
> -cd $ORIGDIR || exit $?
> +cd "$ORIGDIR" || exit $?
>  
> -$srcdir/configure --enable-maintainer-mode "$@"
> +exec "$srcdir/configure" --enable-maintainer-mode "$@"


I am not expert in quoting, can you explain how this is more
appropriate?
If it is, then all other autogen.sh should be changed as well.
I am always looking for improvement.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg/attachments/20101128/48d9641b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20101128/48d9641b/attachment.pgp>


More information about the xorg mailing list