[PATCH 1/5] build: use AC_CONFIG_MACRO_DIR as per libtoolize warning

[Gaetan Nadon]

On Mon, 2010-11-29 at 06:02 -0800, Dan Nicholson wrote:

> Pretty sure it's coming from libtoolize :)

It does.

> 
> libtoolize: Consider adding "AC_CONFIG_MACRO_DIR([m4])" to
> configure.ac and
> libtoolize: rerunning libtoolize, to keep the correct libtool macros
> in-tree.
> libtoolize: Consider adding "-I m4" to ACLOCAL_AMFLAGS in Makefile.am.
> 
> It's suggesting that you add AC_CONFIG_MACRO_DIR([m4]) so that it will
> helpfully install it's m4 files there and attempt to make them
> persistent. Jeremy Huddleston asked not to do this a while back
> because it's then harder to replace the included libtool with the
> patched version on OSX. Not sure if this is still a problem, but there
> are definitely pros and cons to distributing the libtool macros in the
> tree.
> 

There are quite a few modules having an m4 directory. This is where
modules put their additional
m4 macros (unrelated to libtool). There may be additional behaviours
associated with having an m4 directory.
It's still not clear to me. In any case, the libtool macros are shipped
in aclocal.m4. I think the issue was libtool v2 versus 1.5.
I don't think it's a problem anymore.

The -I m4 should not be added when you have no macros in git. Libtool
does not need that to work and it will break
the build on a fresh repo clone because m4 cannot be found.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg/attachments/20101129/e9bde821/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20101129/e9bde821/attachment.pgp>