combining Render's Composite + SHM's PutImage

[Chris Wilson]

On Thu, Apr 09, 2015 at 07:22:34PM +1000, Nigel Tao wrote:
> On Thu, Apr 9, 2015 at 6:39 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > You can either read cairo for an example of how to mix SHM and Render,
> > or http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/tools/virtual.c#n1819
> 
> Thanks for the tip. I'll give it more than a skim later, but one thing
> looked odd in that virtual.c code. Lines 1855-1856 say:
> 
> } else if (c->dst.pixmap) {
> DBG(DRAW, ("%s-%s using SHM pixmap\n",
> 
> Should that "dst.pixmap" be "dst.use_shm_pixmap"?? That would be
> consistent with the
> 
> if (c->dst.use_shm_pixmap) {
> 
> at line 1827.

The DBG is misleading. Another source for the pixmap has been added
since the DBG and the comment not updated. That pixmap could also be for
DRI3 transport.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre