xorgproto: missing _EVDEVK() entries for some keys

[Oliver Gerlich]

Hello,

in xorgproto project in include/X11/XF86keysym.h file there are some
keys for which no _EVDEVK(...) line exists. E.g. for the subtitle key
there is only this line:

> #define XF86XK_Subtitle              0x1008ff9a  /* cycle through subtitle      */

But there is no line like this:

> #define XF86XK_Subtitle                 _EVDEVK(0x172)  /*         KEY_SUBTITLE */

My understanding is that the XF86keysym.h file is used to generate the
"evdev" section in
https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/blob/master/symbols/inet
; but only lines with an _EVDEVK() entry are regarded by the generator.

I want to use XKB to map some keys from infrared remote controls, to
improve out-of-the-box support for remote controls in Kodi media center
(for https://github.com/xbmc/xbmc/issues/16834). Since these keys are
not listed in the symbols/inet file, XKB cannot map them, and therefore
Kodi cannot handle them.

I have now run scripts/keysym-generator.py without a --kernel-versions
parameter, to generate an XF86keysym.h file that contains _EVDEVK()
entries for _all_ keys, regardless of the kernel version. The script was
run on a system with libevdev 1.12.1+dfsg-1 and python-libevdev 0.11.
The diff to
https://gitlab.freedesktop.org/xorg/proto/xorgproto/-/blob/e312ab76c4d93f2e637ac0c73987b22cd43420c7/include/X11/XF86keysym.h
is attached.

In the diff I see that additional _EVDEVK() lines were generated for 132
keys.

Would it be possible and sensible to add _EVDEVK() lines for all of
these keys, so that XF86keysym.h supports all evdev keys?

Alternatively, would it be possible to add _EVDEVK() lines for keys that
are related to media controls? The table at
https://www.kernel.org/doc/html/v6.11/userspace-api/media/rc/rc-tables.html
shows which keys would be interesting.

Should I just submit a merge request for one of these approaches?

Thanks,
Oliver Gerlich
-------------- next part --------------
A non-text attachment was scrubbed...
Name: XF86keysym.h_for_all_keys_1.diff
Type: text/x-patch
Size: 14372 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg/attachments/20241215/f3c66588/attachment.bin>