[Zeitgeist-bugs] [Bug 53662] Add foreach support for libzeitgeist2's SimpleResultSet

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=53662

--- Comment #6 from Michal Hruby <michal.mhr at gmail.com> 2012-08-18 14:31:39 UTC ---
Comment on attachment 65740
  --> https://bugs.freedesktop.org/attachment.cgi?id=65740
Add foreach support to ResultSet

Review of attachment 65740:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=53662&attachment=65740)
-----------------------------------------------------------------

Looking great, just one thing:

::: test/direct/datamodel-test.vala
@@ +25,5 @@
>  {
>      Test.init (ref argv);
>  
>      Test.add_func ("/Datamodel/MatchesTemplate/anything", matches_template_anything_test);
> +    Test.add_func ("/Datamodel/MatchesTemplate/foreach", foreach_test);

Please add one more test that runs foreach twice on the ResultSet instance.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.