[Zeitgeist-bugs] [Bug 52971] insert_events: group data insertion from separate events

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52971

--- Comment #2 from Michal Hruby <michal.mhr at gmail.com> 2012-07-30 16:09:00 UTC ---
Comment on attachment 64958
  --> https://bugs.freedesktop.org/attachment.cgi?id=64958
forgot to commit a comment

Review of attachment 64958:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=52971&attachment=64958)
-----------------------------------------------------------------

Looking fine, just a few comments:

::: src/engine.vala
@@ -79,3 @@
>              for (int i = 0; i < events.length; ++i)
>              {
> -                if (events[i] != null)

Why did the null check disappear?

@@ +149,5 @@
> +        private Database database;
> +        private string type;
> +        private GenericArray<string> data;
> +
> +        public DataInserter (Database db, string data_type)

Can we add a destructor with if (data.length > 0) warning(...)?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.