dri-devel October 2021

dri-devel@lists.freedesktop.org

347 participants
825 discussions

[PATCH] drm/v3d: fix copy_from_user() error codes
by Dan Carpenter 11 Oct '21

11 Oct '21

The copy_to/from_user() function returns the number of bytes remaining to be copied, but we want to return -EFAULT on error. Fixes: e4165ae8304e ("drm/v3d: add multiple syncobjs support") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/v3d/v3d_gem.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 6a000d77c568..e47ae40a865a 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -487,8 +487,8 @@ v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv, for (i = 0; i < se->in_sync_count; i++) { struct drm_v3d_sem in; - ret = copy_from_user(&in, handle++, sizeof(in)); - if (ret) { + if (copy_from_user(&in, handle++, sizeof(in))) { + ret = -EFAULT; DRM_DEBUG("Failed to copy wait dep handle.\n"); goto fail_deps; } @@ -609,8 +609,8 @@ v3d_get_multisync_post_deps(struct drm_file *file_priv, for (i = 0; i < count; i++) { struct drm_v3d_sem out; - ret = copy_from_user(&out, post_deps++, sizeof(out)); - if (ret) { + if (copy_from_user(&out, post_deps++, sizeof(out))) { + ret = -EFAULT; DRM_DEBUG("Failed to copy post dep handles\n"); goto fail; } @@ -646,9 +646,8 @@ v3d_get_multisync_submit_deps(struct drm_file *file_priv, struct v3d_submit_ext *se = data; int ret; - ret = copy_from_user(&multisync, ext, sizeof(multisync)); - if (ret) - return ret; + if (copy_from_user(&multisync, ext, sizeof(multisync))) + return -EFAULT; if (multisync.pad) return -EINVAL; -- 2.20.1

2 1

[PATCH] drm/msm: unlock on error in get_sched_entity()
by Dan Carpenter 11 Oct '21

11 Oct '21

Add a missing unlock on the error path if drm_sched_entity_init() fails. Fixes: 68002469e571 ("drm/msm: One sched entity per process per priority") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- drivers/gpu/drm/msm/msm_submitqueue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_submitqueue.c b/drivers/gpu/drm/msm/msm_submitqueue.c index b8621c6e0554..7cb158bcbcf6 100644 --- a/drivers/gpu/drm/msm/msm_submitqueue.c +++ b/drivers/gpu/drm/msm/msm_submitqueue.c @@ -101,6 +101,7 @@ get_sched_entity(struct msm_file_private *ctx, struct msm_ringbuffer *ring, ret = drm_sched_entity_init(entity, sched_prio, &sched, 1, NULL); if (ret) { + mutex_unlock(&entity_lock); kfree(entity); return ERR_PTR(ret); } -- 2.20.1

1 0

[PATCH] video: fbdev: use memset_io() instead of memset()
by Christophe Leroy 11 Oct '21

11 Oct '21

While investigating a lockup at startup on Powerbook 3400C, it was identified that the fbdev driver generates alignment exception at startup: --- interrupt: 600 at memset+0x60/0xc0 NIP: c0021414 LR: c03fc49c CTR: 00007fff REGS: ca021c10 TRAP: 0600 Tainted: G W (5.14.2-pmac-00727-g12a41fa69492) MSR: 00009032 <EE,ME,IR,DR,RI> CR: 44008442 XER: 20000100 DAR: cab80020 DSISR: 00017c07 GPR00: 00000007 ca021cd0 c14412e0 cab80000 00000000 00100000 cab8001c 00000004 GPR08: 00100000 00007fff 00000000 00000000 84008442 00000000 c0006fb4 00000000 GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00100000 GPR24: 00000000 81800000 00000320 c15fa400 c14d1878 00000000 c14d1800 c094e19c NIP [c0021414] memset+0x60/0xc0 LR [c03fc49c] chipsfb_pci_init+0x160/0x580 --- interrupt: 600 [ca021cd0] [c03fc46c] chipsfb_pci_init+0x130/0x580 (unreliable) [ca021d20] [c03a3a70] pci_device_probe+0xf8/0x1b8 [ca021d50] [c043d584] really_probe.part.0+0xac/0x388 [ca021d70] [c043d914] __driver_probe_device+0xb4/0x170 [ca021d90] [c043da18] driver_probe_device+0x48/0x144 [ca021dc0] [c043e318] __driver_attach+0x11c/0x1c4 [ca021de0] [c043ad30] bus_for_each_dev+0x88/0xf0 [ca021e10] [c043c724] bus_add_driver+0x190/0x22c [ca021e40] [c043ee94] driver_register+0x9c/0x170 [ca021e60] [c0006c28] do_one_initcall+0x54/0x1ec [ca021ed0] [c08246e4] kernel_init_freeable+0x1c0/0x270 [ca021f10] [c0006fdc] kernel_init+0x28/0x11c [ca021f30] [c0017148] ret_from_kernel_thread+0x14/0x1c Instruction dump: 7d4601a4 39490777 7d4701a4 39490888 7d4801a4 39490999 7d4901a4 39290aaa 7d2a01a4 4c00012c 4bfffe88 0fe00000 <4bfffe80> 9421fff0 38210010 48001970 This is due to 'dcbz' instruction being used on non-cached memory. 'dcbz' instruction is used by memset() to zeroize a complete cacheline at once, and memset() is not expected to be used on non cached memory. When performing a 'sparse' check on fbdev driver, it also appears that the use of memset() is unexpected: drivers/video/fbdev/chipsfb.c:334:17: warning: incorrect type in argument 1 (different address spaces) drivers/video/fbdev/chipsfb.c:334:17: expected void * drivers/video/fbdev/chipsfb.c:334:17: got char [noderef] __iomem *screen_base drivers/video/fbdev/chipsfb.c:334:15: warning: memset with byte count of 1048576 Use fb_memset() instead of memset(). fb_memset() is defined as memset_io() for powerpc. Fixes: 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK") Reported-by: Stan Johnson <userm57(a)yahoo.com> Cc: Finn Thain <fthain(a)linux-m68k.org> Signed-off-by: Christophe Leroy <christophe.leroy(a)csgroup.eu> --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c index 998067b701fa..393894af26f8 100644 --- a/drivers/video/fbdev/chipsfb.c +++ b/drivers/video/fbdev/chipsfb.c @@ -331,7 +331,7 @@ static const struct fb_var_screeninfo chipsfb_var = { static void init_chips(struct fb_info *p, unsigned long addr) { - memset(p->screen_base, 0, 0x100000); + fb_memset(p->screen_base, 0, 0x100000); p->fix = chipsfb_fix; p->fix.smem_start = addr; -- 2.31.1

3 2

[PATCH 0/3] drm/nouveau: fix a use-after-free in postclose()
by Jeremy Cline 11 Oct '21

11 Oct '21

This series fixes a number of use-after-frees in nouveau's postclose() handler. It was discovered by pointing IGT's core_hotunplug tests at a nouveau device, but the steps to reproduce it are simple: 1. Open the device file 2. Unbind the driver or remove the device 3. Close the file opened in step 1. During the device removal, the nouveau_drm structure is de-allocated, but is dereferenced in the postclose() handler. One obvious solution is to ensure all the operations in the postclose() handler are valid by extending the lifetime of the nouveau_drm structure. This is possible with the new devm_drm_dev_alloc() interface, but the change is somewhat invasive so I thought it best to submit that work separately. Instead, we make use of the drm_dev_unplug() API, clean up all clients in the device removal call, and check to make sure the device has not been unplugged in the postclose() handler. While this does not enable hot-unplug support for nouveau, it's enough to avoid crashing the kernel and leads to all the core_hotunplug tests to pass. Jeremy Cline (3): drm/nouveau: use drm_dev_unplug() during device removal drm/nouveau: Add a dedicated mutex for the clients list drm/nouveau: clean up all clients on device removal drivers/gpu/drm/nouveau/nouveau_drm.c | 39 +++++++++++++++++++++++---- drivers/gpu/drm/nouveau/nouveau_drv.h | 5 ++++ 2 files changed, 39 insertions(+), 5 deletions(-) -- 2.28.0

4 15

[PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer()
by Tim Gardner 11 Oct '21

11 Oct '21

Coverity complains of an unused return code: CID 120459 (#1 of 1): Unchecked return value (CHECKED_RETURN) 7. check_return: Calling regmap_bulk_write without checking return value (as is done elsewhere 199 out of 291 times). 204 regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, 205 ARRAY_SIZE(addr_len)); While I was at it I noticed 2 other places where return codes were not being used, or used incorrectly (which is a real bug). Fix these errors by correctly using the returned error codes. Cc: William Breathitt Gray <vilhelm.gray(a)gmail.com> Cc: Syed Nayyar Waris <syednwaris(a)gmail.com> Cc: Andrzej Hajda <a.hajda(a)samsung.com> Cc: Neil Armstrong <narmstrong(a)baylibre.com> Cc: Robert Foss <robert.foss(a)linaro.org> Cc: Laurent Pinchart <Laurent.pinchart(a)ideasonboard.com> Cc: Jonas Karlman <jonas(a)kwiboo.se> Cc: Jernej Skrabec <jernej.skrabec(a)gmail.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: linux-iio(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: dri-devel(a)lists.freedesktop.org Signed-off-by: Tim Gardner <tim.gardner(a)canonical.com> --- drivers/gpu/drm/bridge/parade-ps8640.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 3aaa90913bf8..591da962970a 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -201,8 +201,12 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, addr_len[PAGE0_SWAUX_LENGTH - base] = (len == 0) ? SWAUX_NO_PAYLOAD : ((len - 1) & SWAUX_LENGTH_MASK); - regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, + ret = regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, ARRAY_SIZE(addr_len)); + if (ret) { + DRM_DEV_ERROR(dev, "failed to bulk write ADDR_7_0: %d\n", ret); + return ret; + } if (len && (request == DP_AUX_NATIVE_WRITE || request == DP_AUX_I2C_WRITE)) { @@ -218,13 +222,17 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, } } - regmap_write(map, PAGE0_SWAUX_CTRL, SWAUX_SEND); + ret = regmap_write(map, PAGE0_SWAUX_CTRL, SWAUX_SEND); + if (ret) { + DRM_DEV_ERROR(dev, "failed to write SEND: %d\n", ret); + return ret; + } /* Zero delay loop because i2c transactions are slow already */ regmap_read_poll_timeout(map, PAGE0_SWAUX_CTRL, data, !(data & SWAUX_SEND), 0, 50 * 1000); - regmap_read(map, PAGE0_SWAUX_STATUS, &data); + ret = regmap_read(map, PAGE0_SWAUX_STATUS, &data); if (ret) { DRM_DEV_ERROR(dev, "failed to read PAGE0_SWAUX_STATUS: %d\n", ret); -- 2.33.0

3 3

[PATCH] drm/virtio: fix the missed drm_gem_object_put() in virtio_gpu_user_framebuffer_create()
by Jing Xiangfeng 11 Oct '21

11 Oct '21

virtio_gpu_user_framebuffer_create() misses to call drm_gem_object_put() in an error path. Add the missed function call to fix it. Signed-off-by: Jing Xiangfeng <jingxiangfeng(a)huawei.com> --- drivers/gpu/drm/virtio/virtgpu_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index a6caebd4a0dd..5b00310ac4cd 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -308,8 +308,10 @@ virtio_gpu_user_framebuffer_create(struct drm_device *dev, return ERR_PTR(-EINVAL); virtio_gpu_fb = kzalloc(sizeof(*virtio_gpu_fb), GFP_KERNEL); - if (virtio_gpu_fb == NULL) + if (virtio_gpu_fb == NULL) { + drm_gem_object_put(obj); return ERR_PTR(-ENOMEM); + } ret = virtio_gpu_framebuffer_init(dev, virtio_gpu_fb, mode_cmd, obj); if (ret) { -- 2.26.0.106.g9fadedd

2 1

[PATCH] drm: of: Add drm_of_lvds_get_data_mapping
by Marek Vasut 11 Oct '21

11 Oct '21

Add helper function to convert DT "data-mapping" property string value into media bus format value, and deduplicate the code in panel-lvds.c and lvds-codec.c . Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Sam Ravnborg <sam(a)ravnborg.org> To: dri-devel(a)lists.freedesktop.org --- drivers/gpu/drm/bridge/lvds-codec.c | 21 ++++++------------ drivers/gpu/drm/drm_of.c | 33 +++++++++++++++++++++++++++++ drivers/gpu/drm/panel/panel-lvds.c | 18 ++++------------ include/drm/drm_of.h | 7 ++++++ 4 files changed, 51 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c index ad460b96c0a3..f991842a161f 100644 --- a/drivers/gpu/drm/bridge/lvds-codec.c +++ b/drivers/gpu/drm/bridge/lvds-codec.c @@ -14,6 +14,7 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_bridge.h> +#include <drm/drm_of.h> #include <drm/drm_panel.h> struct lvds_codec { @@ -118,7 +119,6 @@ static int lvds_codec_probe(struct platform_device *pdev) struct device_node *bus_node; struct drm_panel *panel; struct lvds_codec *lvds_codec; - const char *mapping; int ret; lvds_codec = devm_kzalloc(dev, sizeof(*lvds_codec), GFP_KERNEL); @@ -174,22 +174,15 @@ static int lvds_codec_probe(struct platform_device *pdev) return -ENXIO; } - ret = of_property_read_string(bus_node, "data-mapping", - &mapping); + ret = drm_of_lvds_get_data_mapping(bus_node); of_node_put(bus_node); - if (ret < 0) { + if (ret == -ENODEV) { dev_warn(dev, "missing 'data-mapping' DT property\n"); + } else if (ret) { + dev_err(dev, "invalid 'data-mapping' DT property\n"); + return ret; } else { - if (!strcmp(mapping, "jeida-18")) { - lvds_codec->bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG; - } else if (!strcmp(mapping, "jeida-24")) { - lvds_codec->bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA; - } else if (!strcmp(mapping, "vesa-24")) { - lvds_codec->bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG; - } else { - dev_err(dev, "invalid 'data-mapping' DT property\n"); - return -EINVAL; - } + lvds_codec->bus_format = ret; lvds_codec->bridge.funcs = &funcs_decoder; } } diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 37c34146eea8..a9217bc18e8f 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -402,3 +402,36 @@ int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, DRM_LVDS_DUAL_LINK_ODD_EVEN_PIXELS; } EXPORT_SYMBOL_GPL(drm_of_lvds_get_dual_link_pixel_order); + +/** + * drm_of_lvds_get_data_mapping - Get LVDS data mapping + * @port: DT port node of the LVDS source or sink + * + * Convert DT "data-mapping" property string value into media bus format value. + * + * Return: + * MEDIA_BUS_FMT_RGB666_1X7X3_SPWG - data-mapping is "jeida-18" + * MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA - data-mapping is "jeida-24" + * MEDIA_BUS_FMT_RGB888_1X7X4_SPWG - data-mapping is "vesa-24" + * -EINVAL - the "data-mapping" property is unsupported + * -ENODEV - the "data-mapping" property is missing + */ +int drm_of_lvds_get_data_mapping(const struct device_node *port) +{ + const char *mapping; + int ret; + + ret = of_property_read_string(port, "data-mapping", &mapping); + if (ret < 0) + return -ENODEV; + + if (!strcmp(mapping, "jeida-18")) + return MEDIA_BUS_FMT_RGB666_1X7X3_SPWG; + if (!strcmp(mapping, "jeida-24")) + return MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA; + if (!strcmp(mapping, "vesa-24")) + return MEDIA_BUS_FMT_RGB888_1X7X4_SPWG; + + return -EINVAL; +} +EXPORT_SYMBOL_GPL(drm_of_lvds_get_data_mapping); diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index 59a8d99e777d..27a1c9923b09 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -20,6 +20,7 @@ #include <video/videomode.h> #include <drm/drm_crtc.h> +#include <drm/drm_of.h> #include <drm/drm_panel.h> struct panel_lvds { @@ -116,7 +117,6 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) { struct device_node *np = lvds->dev->of_node; struct display_timing timing; - const char *mapping; int ret; ret = of_drm_get_panel_orientation(np, &lvds->orientation); @@ -149,24 +149,14 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) of_property_read_string(np, "label", &lvds->label); - ret = of_property_read_string(np, "data-mapping", &mapping); + ret = drm_of_lvds_get_data_mapping(np); if (ret < 0) { dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n", np, "data-mapping"); - return -ENODEV; + return ret; } - if (!strcmp(mapping, "jeida-18")) { - lvds->bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG; - } else if (!strcmp(mapping, "jeida-24")) { - lvds->bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA; - } else if (!strcmp(mapping, "vesa-24")) { - lvds->bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG; - } else { - dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n", - np, "data-mapping"); - return -EINVAL; - } + lvds->bus_format = ret; lvds->data_mirror = of_property_read_bool(np, "data-mirror"); diff --git a/include/drm/drm_of.h b/include/drm/drm_of.h index b9b093add92e..4b6d4a6463d3 100644 --- a/include/drm/drm_of.h +++ b/include/drm/drm_of.h @@ -49,6 +49,7 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, struct drm_bridge **bridge); int drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, const struct device_node *port2); +int drm_of_lvds_get_data_mapping(const struct device_node *port); #else static inline uint32_t drm_of_crtc_port_mask(struct drm_device *dev, struct device_node *port) @@ -98,6 +99,12 @@ drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, { return -EINVAL; } + +static inline int +drm_of_lvds_get_data_mapping(const struct device_node *port); +{ + return -EINVAL; +} #endif /* -- 2.33.0

2 3

linux-next: manual merge of the drm tree with Linus' tree
by Stephen Rothwell 11 Oct '21

11 Oct '21

Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/display/include/dal_asic_id.h between commit: 7ab0965079bb ("drm/amd/display: USB4 bring up set correct address") from Linus' tree and commit: 13900e6fde3f ("drm/amd/display: Fix for null pointer access for ddc pin and aux engine.") from the drm tree. I fixed it up (I used the former) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell

1 0

imx_ldb: lockdep warning on 5.14.x
by Fabio Estevam 10 Oct '21

10 Oct '21

Hi, I am getting the lockdep warning below on a imx6q-sabred running 5.14.9. Haven't debugged this yet, but just wanted to report in case someone has any suggestions. Thanks, Fabio Estevam [ 4.913294] imx-drm display-subsystem: bound imx-ipuv3-crtc.2 (ops ipu_crtc_ops) [ 4.921640] imx-drm display-subsystem: bound imx-ipuv3-crtc.3 (ops ipu_crtc_ops) [ 4.929798] imx-drm display-subsystem: bound imx-ipuv3-crtc.6 (ops ipu_crtc_ops) [ 4.937977] imx-drm display-subsystem: bound imx-ipuv3-crtc.7 (ops ipu_crtc_ops) [ 4.946850] imx-drm display-subsystem: bound 120000.hdmi (ops dw_hdmi_imx_ops) [ 4.954685] imx-drm display-subsystem: bound ldb (ops imx_ldb_ops) [ 4.966943] [drm] Initialized imx-drm 1.0.0 20120507 for display-subsystem on minor 0 [ 5.001801] [ 5.001811] ====================================================== [ 5.001817] WARNING: possible circular locking dependency detected [ 5.001824] 5.14.9-01225-g45da36cc6fcc-dirty #1 Tainted: G W [ 5.001833] ------------------------------------------------------ [ 5.001838] kworker/u8:0/7 is trying to acquire lock: [ 5.001848] c1752080 (regulator_list_mutex){+.+.}-{3:3}, at: regulator_lock_dependent+0x40/0x294 [ 5.001903] [ 5.001903] but task is already holding lock: [ 5.001909] c176df78 (dma_fence_map){++++}-{0:0}, at: imx_drm_atomic_commit_tail+0x10/0x160 [ 5.001957] [ 5.001957] which lock already depends on the new lock. [ 5.001957] [ 5.001963] [ 5.001963] the existing dependency chain (in reverse order) is: [ 5.001968] [ 5.001968] -> #3 (dma_fence_map){++++}-{0:0}: [ 5.001993] dma_resv_lockdep+0x1c4/0x2b8 [ 5.002010] do_one_initcall+0x84/0x3b8 [ 5.002026] kernel_init_freeable+0x198/0x22c [ 5.002040] kernel_init+0x10/0x128 [ 5.002061] ret_from_fork+0x14/0x38 [ 5.002072] 0x0 [ 5.002081] [ 5.002081] -> #2 (fs_reclaim){+.+.}-{0:0}: [ 5.002105] kmem_cache_alloc+0x28/0x38c [ 5.002125] __d_alloc+0x20/0x224 [ 5.002141] d_alloc+0x10/0x60 [ 5.002152] d_alloc_parallel+0x48/0xa60 [ 5.002165] __lookup_slow+0x8c/0x178 [ 5.002184] lookup_one_len+0x98/0xd8 [ 5.002196] start_creating+0x94/0x14c [ 5.002216] debugfs_create_dir+0x10/0x100 [ 5.002231] pinctrl_init+0x1c/0xd4 [ 5.002247] do_one_initcall+0x84/0x3b8 [ 5.002259] kernel_init_freeable+0x198/0x22c [ 5.002271] kernel_init+0x10/0x128 [ 5.002286] ret_from_fork+0x14/0x38 [ 5.002296] 0x0 [ 5.002303] [ 5.002303] -> #1 (&sb->s_type->i_mutex_key#2){+.+.}-{3:3}: [ 5.002335] simple_recursive_removal+0x54/0x33c [ 5.002350] debugfs_remove+0x30/0x4c [ 5.002364] _regulator_put.part.0+0x30/0x1d8 [ 5.002383] regulator_put+0x2c/0x3c [ 5.002395] release_nodes+0x50/0x190 [ 5.002415] devres_release_all+0x80/0xd4 [ 5.002426] really_probe+0xd4/0x314 [ 5.002438] __driver_probe_device+0x80/0xe4 [ 5.002449] driver_probe_device+0x30/0xd4 [ 5.002459] __driver_attach_async_helper+0x20/0x38 [ 5.002470] async_run_entry_fn+0x20/0xb4 [ 5.002483] process_one_work+0x2a0/0x7c0 [ 5.002500] worker_thread+0x30/0x510 [ 5.002512] kthread+0x154/0x17c [ 5.002526] ret_from_fork+0x14/0x38 [ 5.002537] 0x0 [ 5.002546] [ 5.002546] -> #0 (regulator_list_mutex){+.+.}-{3:3}: [ 5.002569] lock_acquire+0x13c/0x418 [ 5.002581] __mutex_lock+0x94/0x97c [ 5.002595] mutex_lock_nested+0x1c/0x24 [ 5.002605] regulator_lock_dependent+0x40/0x294 [ 5.002622] regulator_enable+0x2c/0xec [ 5.002632] panel_simple_resume+0x38/0x1f4 [ 5.002648] __rpm_callback+0x3c/0x108 [ 5.002661] rpm_callback+0x68/0x70 [ 5.002671] rpm_resume+0x604/0x7f4 [ 5.002681] __pm_runtime_resume+0x64/0x90 [ 5.002692] panel_simple_prepare+0x2c/0x50 [ 5.002703] imx_ldb_encoder_enable+0x58/0x2b0 [ 5.002715] drm_atomic_helper_commit_modeset_enables+0x230/0x26c [ 5.002734] imx_drm_atomic_commit_tail+0x3c/0x160 [ 5.002753] commit_tail+0x9c/0x18c [ 5.002766] drm_atomic_helper_commit+0x158/0x18c [ 5.002778] drm_client_modeset_commit_atomic+0x23c/0x288 [ 5.002795] drm_client_modeset_commit_locked+0x60/0x1d0 [ 5.002806] drm_client_modeset_commit+0x24/0x40 [ 5.002819] __drm_fb_helper_restore_fbdev_mode_unlocked+0x9c/0xc8 [ 5.002835] drm_fb_helper_set_par+0x38/0x68 [ 5.002845] fbcon_init+0x2bc/0x550 [ 5.002862] visual_init+0xbc/0x104 [ 5.002881] do_bind_con_driver+0x1c8/0x3b0 [ 5.002896] do_take_over_console+0x134/0x1f0 [ 5.002910] do_fbcon_takeover+0x60/0xc0 [ 5.002924] register_framebuffer+0x1c8/0x2e8 [ 5.002936] __drm_fb_helper_initial_config_and_unlock+0x3c8/0x614 [ 5.002950] drm_fbdev_client_hotplug+0xf8/0x194 [ 5.002961] drm_fbdev_generic_setup+0x9c/0x194 [ 5.002971] imx_drm_bind+0xe0/0x124 [ 5.002985] try_to_bring_up_master+0x15c/0x1a8 [ 5.003002] __component_add+0x94/0x140 [ 5.003013] imx_ldb_probe+0x32c/0x4e8 [ 5.003025] platform_probe+0x58/0xb8 [ 5.003040] really_probe+0x14c/0x314 [ 5.003050] __driver_probe_device+0x80/0xe4 [ 5.003060] driver_probe_device+0x30/0xd4 [ 5.003070] __device_attach_driver+0x8c/0xb4 [ 5.003081] bus_for_each_drv+0x80/0xd0 [ 5.003093] __device_attach+0xec/0x160 [ 5.003105] bus_probe_device+0x88/0x90 [ 5.003116] deferred_probe_work_func+0x7c/0xac [ 5.003127] process_one_work+0x2a0/0x7c0 [ 5.003143] worker_thread+0x30/0x510 [ 5.003154] kthread+0x154/0x17c [ 5.003164] ret_from_fork+0x14/0x38 [ 5.003174] 0x0 [ 5.003182] [ 5.003182] other info that might help us debug this: [ 5.003182] [ 5.003188] Chain exists of: [ 5.003188] regulator_list_mutex --> fs_reclaim --> dma_fence_map [ 5.003188] [ 5.003218] Possible unsafe locking scenario: [ 5.003218] [ 5.003222] CPU0 CPU1 [ 5.003227] ---- ---- [ 5.003232] lock(dma_fence_map); [ 5.003244] lock(fs_reclaim); [ 5.003257] lock(dma_fence_map); [ 5.003269] lock(regulator_list_mutex); [ 5.003280] [ 5.003280] *** DEADLOCK *** [ 5.003280] [ 5.003284] 13 locks held by kworker/u8:0/7: [ 5.003292] #0: c2006ca8 ((wq_completion)events_unbound){+.+.}-{0:0}, at: process_one_work+0x1ec/0x7c0 [ 5.003331] #1: c20c9f28 (deferred_probe_work){+.+.}-{0:0}, at: process_one_work+0x1ec/0x7c0 [ 5.003367] #2: c21448d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x30/0x160 [ 5.003404] #3: c1769c90 (component_mutex){+.+.}-{3:3}, at: __component_add+0x44/0x140 [ 5.003440] #4: c174c8f4 (registration_lock){+.+.}-{3:3}, at: register_framebuffer+0x28/0x2e8 [ 5.003475] #5: c1618454 (console_lock){+.+.}-{0:0}, at: register_framebuffer+0x248/0x2e8 [ 5.003508] #6: c263dc48 (&fb_info->lock){+.+.}-{3:3}, at: register_framebuffer+0x1c0/0x2e8 [ 5.003543] #7: c2b8fb6c (&helper->lock){+.+.}-{3:3}, at: __drm_fb_helper_restore_fbdev_mode_unlocked+0x4c/0xc8 [ 5.003578] #8: c2be90e8 (&dev->master_mutex){+.+.}-{3:3}, at: drm_master_internal_acquire+0x18/0x3c [ 5.003614] #9: c2b8fa50 (&client->modeset_mutex){+.+.}-{3:3}, at: drm_client_modeset_commit_locked+0x20/0x1d0 [ 5.003653] #10: c20c9ae0 (crtc_ww_class_acquire){+.+.}-{0:0}, at: drm_client_modeset_commit_atomic+0x34/0x288 [ 5.003691] #11: c263c488 (crtc_ww_class_mutex){+.+.}-{3:3}, at: drm_modeset_backoff+0x90/0x228 [ 5.003734] #12: c176df78 (dma_fence_map){++++}-{0:0}, at: imx_drm_atomic_commit_tail+0x10/0x160 [ 5.003775] [ 5.003775] stack backtrace: [ 5.003783] CPU: 0 PID: 7 Comm: kworker/u8:0 Tainted: G W 5.14.9-01225-g45da36cc6fcc-dirty #1 [ 5.003797] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 5.003808] Workqueue: events_unbound deferred_probe_work_func [ 5.003831] [<c01119b0>] (unwind_backtrace) from [<c010c020>] (show_stack+0x10/0x14) [ 5.003860] [<c010c020>] (show_stack) from [<c0e76ab0>] (dump_stack_lvl+0x58/0x70) [ 5.003887] [<c0e76ab0>] (dump_stack_lvl) from [<c0188dd4>] (check_noncircular+0xf4/0x168) [ 5.003917] [<c0188dd4>] (check_noncircular) from [<c018cc78>] (__lock_acquire+0x1698/0x3208) [ 5.003938] [<c018cc78>] (__lock_acquire) from [<c018f274>] (lock_acquire+0x13c/0x418) [ 5.003955] [<c018f274>] (lock_acquire) from [<c0e88c18>] (__mutex_lock+0x94/0x97c) [ 5.003974] [<c0e88c18>] (__mutex_lock) from [<c0e8951c>] (mutex_lock_nested+0x1c/0x24) [ 5.003991] [<c0e8951c>] (mutex_lock_nested) from [<c06aecdc>] (regulator_lock_dependent+0x40/0x294) [ 5.004019] [<c06aecdc>] (regulator_lock_dependent) from [<c06b26cc>] (regulator_enable+0x2c/0xec) [ 5.004039] [<c06b26cc>] (regulator_enable) from [<c07ce850>] (panel_simple_resume+0x38/0x1f4) [ 5.004062] [<c07ce850>] (panel_simple_resume) from [<c080698c>] (__rpm_callback+0x3c/0x108) [ 5.004082] [<c080698c>] (__rpm_callback) from [<c0806ac0>] (rpm_callback+0x68/0x70) [ 5.004098] [<c0806ac0>] (rpm_callback) from [<c08065e4>] (rpm_resume+0x604/0x7f4) [ 5.004114] [<c08065e4>] (rpm_resume) from [<c0806838>] (__pm_runtime_resume+0x64/0x90) [ 5.004131] [<c0806838>] (__pm_runtime_resume) from [<c07ce69c>] (panel_simple_prepare+0x2c/0x50) [ 5.004149] [<c07ce69c>] (panel_simple_prepare) from [<c07ccfa0>] (imx_ldb_encoder_enable+0x58/0x2b0) [ 5.004169] [<c07ccfa0>] (imx_ldb_encoder_enable) from [<c07043f8>] (drm_atomic_helper_commit_modeset_enables+0x230/0x26c) [ 5.004194] [<c07043f8>] (drm_atomic_helper_commit_modeset_enables) from [<c07c8bf8>] (imx_drm_atomic_commit_tail+0x3c/0x160) [ 5.004222] [<c07c8bf8>] (imx_drm_atomic_commit_tail) from [<c07060a0>] (commit_tail+0x9c/0x18c) [ 5.004244] [<c07060a0>] (commit_tail) from [<c07062f0>] (drm_atomic_helper_commit+0x158/0x18c) [ 5.004266] [<c07062f0>] (drm_atomic_helper_commit) from [<c073b678>] (drm_client_modeset_commit_atomic+0x23c/0x288) [ 5.004290] [<c073b678>] (drm_client_modeset_commit_atomic) from [<c073b794>] (drm_client_modeset_commit_locked+0x60/0x1d0) [ 5.004311] [<c073b794>] (drm_client_modeset_commit_locked) from [<c073b928>] (drm_client_modeset_commit+0x24/0x40) [ 5.004330] [<c073b928>] (drm_client_modeset_commit) from [<c070c474>] (__drm_fb_helper_restore_fbdev_mode_unlocked+0x9c/0xc8) [ 5.004353] [<c070c474>] (__drm_fb_helper_restore_fbdev_mode_unlocked) from [<c070c508>] (drm_fb_helper_set_par+0x38/0x68) [ 5.004373] [<c070c508>] (drm_fb_helper_set_par) from [<c0677938>] (fbcon_init+0x2bc/0x550) [ 5.004395] [<c0677938>] (fbcon_init) from [<c06d7144>] (visual_init+0xbc/0x104) [ 5.004419] [<c06d7144>] (visual_init) from [<c06d8574>] (do_bind_con_driver+0x1c8/0x3b0) [ 5.004440] [<c06d8574>] (do_bind_con_driver) from [<c06d8ab8>] (do_take_over_console+0x134/0x1f0) [ 5.004462] [<c06d8ab8>] (do_take_over_console) from [<c067557c>] (do_fbcon_takeover+0x60/0xc0) [ 5.004484] [<c067557c>] (do_fbcon_takeover) from [<c066da40>] (register_framebuffer+0x1c8/0x2e8) [ 5.004503] [<c066da40>] (register_framebuffer) from [<c070be0c>] (__drm_fb_helper_initial_config_and_unlock+0x3c8/0x614) [ 5.004522] [<c070be0c>] (__drm_fb_helper_initial_config_and_unlock) from [<c070c744>] (drm_fbdev_client_hotplug+0xf8/0x194) [ 5.004541] [<c070c744>] (drm_fbdev_client_hotplug) from [<c070c87c>] (drm_fbdev_generic_setup+0x9c/0x194) [ 5.004559] [<c070c87c>] (drm_fbdev_generic_setup) from [<c07c8b78>] (imx_drm_bind+0xe0/0x124) [ 5.004583] [<c07c8b78>] (imx_drm_bind) from [<c07f0ce4>] (try_to_bring_up_master+0x15c/0x1a8) [ 5.004608] [<c07f0ce4>] (try_to_bring_up_master) from [<c07f0dc4>] (__component_add+0x94/0x140) [ 5.004628] [<c07f0dc4>] (__component_add) from [<c07cc9dc>] (imx_ldb_probe+0x32c/0x4e8) [ 5.004647] [<c07cc9dc>] (imx_ldb_probe) from [<c07fae98>] (platform_probe+0x58/0xb8) [ 5.004670] [<c07fae98>] (platform_probe) from [<c07f8748>] (really_probe+0x14c/0x314) [ 5.004690] [<c07f8748>] (really_probe) from [<c07f8990>] (__driver_probe_device+0x80/0xe4) [ 5.004709] [<c07f8990>] (__driver_probe_device) from [<c07f8a24>] (driver_probe_device+0x30/0xd4) [ 5.004728] [<c07f8a24>] (driver_probe_device) from [<c07f8d40>] (__device_attach_driver+0x8c/0xb4) [ 5.004748] [<c07f8d40>] (__device_attach_driver) from [<c07f6b0c>] (bus_for_each_drv+0x80/0xd0) [ 5.004767] [<c07f6b0c>] (bus_for_each_drv) from [<c07f8580>] (__device_attach+0xec/0x160) [ 5.004785] [<c07f8580>] (__device_attach) from [<c07f77e0>] (bus_probe_device+0x88/0x90) [ 5.004803] [<c07f77e0>] (bus_probe_device) from [<c07f7c9c>] (deferred_probe_work_func+0x7c/0xac) [ 5.004820] [<c07f7c9c>] (deferred_probe_work_func) from [<c0147cc0>] (process_one_work+0x2a0/0x7c0) [ 5.004845] [<c0147cc0>] (process_one_work) from [<c0148210>] (worker_thread+0x30/0x510) [ 5.004865] [<c0148210>] (worker_thread) from [<c0151088>] (kthread+0x154/0x17c) [ 5.004885] [<c0151088>] (kthread) from [<c010013c>] (ret_from_fork+0x14/0x38) [ 5.004904] Exception stack(0xc20c9fb0 to 0xc20c9ff8) [ 5.004916] 9fa0: 00000000 00000000 00000000 00000000 [ 5.004929] 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 5.004940] 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 5.054205] Console: switching to colour frame buffer device 128x48 [ 6.236262] imx-drm display-subsystem: [drm] fb0: imx-drm frame buffer device [ 6.251485] etnaviv etnaviv: bound 130000.gpu (ops gpu_ops) [ 6.257459] etnaviv etnaviv: bound 134000.gpu (ops gpu_ops) [ 6.263513] etnaviv etnaviv: bound 2204000.gpu (ops gpu_ops) [ 6.269228] etnaviv-gpu 130000.gpu: model: GC2000, revision: 5108 [ 6.275723] etnaviv-gpu 134000.gpu: model: GC320, revision: 5007 [ 6.281932] etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 [ 6.288047] etnaviv-gpu 2204000.gpu: Ignoring GPU with VG and FE2.0 [ 6.295155] [drm] Initialized etnaviv 1.3.0 20151214 for etnaviv on minor 1

1 1

[PATCH v5 0/2] Add support for Sharp LS060T1SX01 panel
by Dmitry Baryshkov 10 Oct '21

10 Oct '21

Add driver to support Sharp LS06T1SX01 6.0" FullHD panel found e.g. in the kwaek.ca Dragonboard Display Adapter Bundle. Changes since v4: - Use MIPI_DSI_MODE_NO_EOT_PACKET instead of the old name Changes since v3: - Replaced small msleeps with usleep_range Changes since v2: - Add missing power supplies used by the panel according to the datasheet Changes since v1: - Fix the id in the schema file ---------------------------------------------------------------- Dmitry Baryshkov (2): dt-bindings: add bindings for the Sharp LS060T1SX01 panel drm/panel: Add support for Sharp LS060T1SX01 panel .../bindings/display/panel/sharp,ls060t1sx01.yaml | 56 ++++ drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c | 333 +++++++++++++++++++++ 4 files changed, 400 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,ls060t1sx01.yaml create mode 100644 drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c

2 4

← Newer
1
...
60
61
62
63
64
65
66
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel October 2021