dri-devel December 2021

dri-devel@lists.freedesktop.org

310 participants
720 discussions

[PULL] drm-intel-next
by Jani Nikula 14 Dec '21

14 Dec '21

Hi Dave & Daniel - drm-intel-next-2021-12-14: drm/i915 feature pull #2 for v5.17: Features and functionality: - Add eDP privacy screen support (Hans) - Add Raptor Lake S (RPL-S) support (Anusha) - Add CD clock squashing support (Mika) - Properly support ADL-P without force probe (Clint) - Enable pipe color support (10 bit gamma) for display 13 platforms (Uma) - Update ADL-P DMC firmware to v2.14 (Madhumitha) Refactoring and cleanups: - More FBC refactoring preparing for multiple FBC instances (Ville) - Plane register cleanups (Ville) - Header refactoring and include cleanups (Jani) - Crtc helper and vblank wait function cleanups (Jani, Ville) - Move pipe/transcoder/abox masks under intel_device_info.display (Ville) Fixes: - Add a delay to let eDP source OUI write take effect (Lyude) - Use div32 version of MPLLB word clock for UHBR on SNPS PHY (Jani) - Fix DMC firmware loader overflow check (Harshit Mogalapalli) - Fully disable FBC on FIFO underruns (Ville) - Disable FBC with double wide pipe as mutually exclusive (Ville) - DG2 workarounds (Matt) - Non-x86 build fixes (Siva) - Fix HDR plane max width for NV12 (Vidya) - Disable IRQ for selftest timestamp calculation (Anshuman) - ADL-P VBT DDC pin mapping fix (Tejas) Merges: - Backmerge drm-next for privacy screen plumbing (Jani) BR, Jani. The following changes since commit c8a04cbeedbc9f71c475141baa656f14f4879792: Merge tag 'drm-misc-next-2021-11-29' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2021-12-09 09:31:45 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-2021-12-14 for you to fetch changes up to 96db14432d979532be4cb6d5d52a127317e68b3f: drm/i915: Fix implicit use of struct pci_dev (2021-12-14 10:38:29 +0200) ---------------------------------------------------------------- drm/i915 feature pull #2 for v5.17: Features and functionality: - Add eDP privacy screen support (Hans) - Add Raptor Lake S (RPL-S) support (Anusha) - Add CD clock squashing support (Mika) - Properly support ADL-P without force probe (Clint) - Enable pipe color support (10 bit gamma) for display 13 platforms (Uma) - Update ADL-P DMC firmware to v2.14 (Madhumitha) Refactoring and cleanups: - More FBC refactoring preparing for multiple FBC instances (Ville) - Plane register cleanups (Ville) - Header refactoring and include cleanups (Jani) - Crtc helper and vblank wait function cleanups (Jani, Ville) - Move pipe/transcoder/abox masks under intel_device_info.display (Ville) Fixes: - Add a delay to let eDP source OUI write take effect (Lyude) - Use div32 version of MPLLB word clock for UHBR on SNPS PHY (Jani) - Fix DMC firmware loader overflow check (Harshit Mogalapalli) - Fully disable FBC on FIFO underruns (Ville) - Disable FBC with double wide pipe as mutually exclusive (Ville) - DG2 workarounds (Matt) - Non-x86 build fixes (Siva) - Fix HDR plane max width for NV12 (Vidya) - Disable IRQ for selftest timestamp calculation (Anshuman) - ADL-P VBT DDC pin mapping fix (Tejas) Merges: - Backmerge drm-next for privacy screen plumbing (Jani) ---------------------------------------------------------------- Anshuman Gupta (1): drm/i915/selftest: Disable IRQ for timestamp calculation Anusha Srivatsa (3): drm/i915/rpl-s: Add PCI IDS for Raptor Lake S drm/i915/rpl-s: Add PCH Support for Raptor Lake S drm/i915/rpl-s: Enable guc submission by default Clint Taylor (1): drm/i915/adlp: Remove require_force_probe protection Hans de Goede (2): drm/i915: Add intel_modeset_probe_defer() helper drm/i915: Add privacy-screen support (v3) Harshit Mogalapalli (1): drm/i915/display: Fix an unsigned subtraction which can never be negative. Jani Nikula (24): drm/i915/display: add intel_crtc_wait_for_next_vblank() and use it drm/i915/crtc: rename intel_get_crtc_for_pipe() to intel_crtc_for_pipe() drm/i915/crtc: rename intel_get_crtc_for_plane() to intel_crtc_for_plane() drm/i915/display: remove intel_wait_for_vblank() drm/i915/crtc: un-inline some crtc functions and move to intel_crtc.[ch] drm/i915/fb: move intel_fb_uses_dpt to intel_fb.c and un-inline drm/i915: split out intel_pm_types.h drm/i915: move enum hpd_pin to intel_display.h drm/i915/display: convert dp_to_i915() to a macro drm/i915/display: stop including i915_drv.h from intel_display_types.h drm/i915/snps: use div32 version of MPLLB word clock for UHBR drm/i915/ddi: add use_edp_hobl() and use_edp_low_vswing() helpers drm/i915/trace: clean up boilerplate organization drm/i915/trace: split out display trace to a separate file Merge drm/drm-next into drm-intel-next drm/i915/reset: include intel_display.h instead of intel_display_types.h drm/i915/active: remove useless i915_utils.h include drm/i915/psr: avoid intel_frontbuffer.h include with declaration drm/i915/fbc: avoid intel_frontbuffer.h include with declaration drm/i915/fb: reduce include dependencies drm/i915/pxp: un-inline intel_pxp_is_enabled() drm/i915/pxp: remove useless includes drm/i915/cdclk: move intel_atomic_check_cdclk() to intel_cdclk.c drm/i915/cdclk: hide struct intel_cdclk_vals Lyude Paul (1): drm/i915/dp: Perform 30ms delay after source OUI write Madhumitha Tolakanahalli Pradeep (2): drm/i915/dmc: Change max DMC FW size on ADL-P drm/i915/dmc: Update DMC to v2.14 on ADL-P Mark Brown (1): drm/i915: Fix implicit use of struct pci_dev Matt Atwood (1): drm/i915/dg2: extend Wa_1409120013 to DG2 Matt Roper (2): drm/i915/dg2: s/DISP_STEPPING/DISPLAY_STEPPING/ drm/i915/dg2: Add Wa_14010547955 Mika Kahola (4): drm/i915/display/dg2: Introduce CD clock squashing table drm/i915/display/dg2: Sanitize CD clock drm/i915/display/dg2: Set CD clock squashing registers drm/i915/display/dg2: Read CD clock from squasher table Siva Mullati (1): drm/i915: Skip remap_io_mapping() for non-x86 platforms Tejas Upadhyay (1): drm/i915/adl_p: Add ddc pin mapping Uma Shankar (3): drm/i915/xelpd: Enable Pipe color support for D13 platform drm/i915/xelpd: Enable Pipe Degamma drm/i915/xelpd: Add Pipe Color Lut caps to platform config Vidya Srinivas (1): drm/i915: Add PLANE_CUS_CTL restriction in max_width Ville Syrjälä (29): drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio drm/i915: Rename plane YUV order bits drm/i915: Rename PLANE_CUS_CTL Y plane bits drm/i915/fbc: Eliminate racy intel_fbc_is_active() usage drm/i915/fbc: Pass whole plane state to intel_fbc_min_limit() drm/i915/fbc: Nuke lots of crap from intel_fbc_state_cache drm/i915/fbc: Relocate intel_fbc_override_cfb_stride() drm/i915/fbc: Nuke more FBC state drm/i915/fbc: Reuse the same struct for the cache and params drm/i915/fbc: Pass around FBC instance instead of crtc drm/i915/fbc: Track FBC usage per-plane drm/i915/fbc: Flatten __intel_fbc_pre_update() drm/i915/fbc: Pass i915 instead of FBC instance to FBC underrun stuff drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c drm/i915/fbc: Introduce intel_fbc_add_plane() drm/i915/fbc: Allocate intel_fbc dynamically drm/i915/fbc: Move stuff from intel_fbc_can_enable() into intel_fbc_check_plane() drm/i915/fbc: Disable FBC fully on FIFO underrun drm/i915/fbc: Nuke state_cache drm/i915/fbc: Move plane pointer into intel_fbc_state drm/i915/fbc: s/parms/fbc_state/ drm/i915/fbc: No FBC+double wide pipe drm/i915/fbc: Pimp the FBC debugfs output drm/i915: Get rid of the "sizes are 0 based" stuff drm/i915: Allow cdclk squasher to be reconfigured live drm/i915: Nuke {pipe,plane}_to_crtc_mapping[] drm/i915: Relocate intel_crtc_for_plane() drm/i915: s/intel_get_first_crtc/intel_first_crtc/ drm/i915: Move pipe/transcoder/abox masks under intel_device_info.display arch/x86/kernel/early-quirks.c | 1 + drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/g4x_dp.c | 1 + drivers/gpu/drm/i915/display/g4x_hdmi.c | 1 + drivers/gpu/drm/i915/display/i9xx_plane.c | 15 +- drivers/gpu/drm/i915/display/intel_atomic.c | 1 + drivers/gpu/drm/i915/display/intel_atomic_plane.c | 7 +- drivers/gpu/drm/i915/display/intel_audio.c | 3 +- drivers/gpu/drm/i915/display/intel_bios.c | 14 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 200 +++- drivers/gpu/drm/i915/display/intel_cdclk.h | 10 +- drivers/gpu/drm/i915/display/intel_color.c | 23 +- drivers/gpu/drm/i915/display/intel_crt.c | 6 +- drivers/gpu/drm/i915/display/intel_crtc.c | 48 +- drivers/gpu/drm/i915/display/intel_crtc.h | 7 + drivers/gpu/drm/i915/display/intel_ddi.c | 16 + drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 94 +- drivers/gpu/drm/i915/display/intel_display.c | 153 ++- drivers/gpu/drm/i915/display/intel_display.h | 30 +- .../gpu/drm/i915/display/intel_display_debugfs.c | 54 +- drivers/gpu/drm/i915/display/intel_display_power.c | 4 +- drivers/gpu/drm/i915/display/intel_display_trace.c | 9 + drivers/gpu/drm/i915/display/intel_display_trace.h | 587 ++++++++++ drivers/gpu/drm/i915/display/intel_display_types.h | 79 +- drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- drivers/gpu/drm/i915/display/intel_dp.c | 14 +- drivers/gpu/drm/i915/display/intel_dp.h | 2 + .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 6 + .../gpu/drm/i915/display/intel_dp_link_training.c | 2 +- drivers/gpu/drm/i915/display/intel_dpll.c | 2 +- drivers/gpu/drm/i915/display/intel_dsi.c | 2 + drivers/gpu/drm/i915/display/intel_fb.c | 11 + drivers/gpu/drm/i915/display/intel_fb.h | 2 + drivers/gpu/drm/i915/display/intel_fb_pin.c | 10 +- drivers/gpu/drm/i915/display/intel_fbc.c | 1177 ++++++++++---------- drivers/gpu/drm/i915/display/intel_fbc.h | 16 +- drivers/gpu/drm/i915/display/intel_fdi.c | 5 +- drivers/gpu/drm/i915/display/intel_fifo_underrun.c | 14 +- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 7 +- drivers/gpu/drm/i915/display/intel_frontbuffer.h | 2 +- drivers/gpu/drm/i915/display/intel_plane_initial.c | 5 +- drivers/gpu/drm/i915/display/intel_psr.h | 11 +- drivers/gpu/drm/i915/display/intel_quirks.c | 1 + drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +- drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 + drivers/gpu/drm/i915/display/intel_sprite.c | 34 +- drivers/gpu/drm/i915/display/intel_tv.c | 8 +- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 7 +- drivers/gpu/drm/i915/display/intel_vdsc.c | 17 +- drivers/gpu/drm/i915/display/skl_universal_plane.c | 61 +- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 1 + drivers/gpu/drm/i915/gt/intel_reset.c | 2 +- drivers/gpu/drm/i915/gt/selftest_gt_pm.c | 4 +- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +- drivers/gpu/drm/i915/i915_active_types.h | 2 - drivers/gpu/drm/i915/i915_debugfs.c | 1 - drivers/gpu/drm/i915/i915_driver.c | 1 - drivers/gpu/drm/i915/i915_drv.h | 210 +--- drivers/gpu/drm/i915/i915_irq.c | 8 +- drivers/gpu/drm/i915/i915_mm.c | 28 +- drivers/gpu/drm/i915/i915_mm.h | 35 + drivers/gpu/drm/i915/i915_pci.c | 91 +- drivers/gpu/drm/i915/i915_reg.h | 48 +- drivers/gpu/drm/i915/i915_trace.h | 577 +--------- drivers/gpu/drm/i915/intel_device_info.c | 31 +- drivers/gpu/drm/i915/intel_device_info.h | 12 +- drivers/gpu/drm/i915/intel_pch.c | 1 + drivers/gpu/drm/i915/intel_pch.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 41 +- drivers/gpu/drm/i915/intel_pm_types.h | 76 ++ drivers/gpu/drm/i915/pxp/intel_pxp.c | 5 + drivers/gpu/drm/i915/pxp/intel_pxp.h | 15 +- drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 2 - include/drm/i915_pciids.h | 9 + 75 files changed, 2104 insertions(+), 1895 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_trace.c create mode 100644 drivers/gpu/drm/i915/display/intel_display_trace.h create mode 100644 drivers/gpu/drm/i915/i915_mm.h create mode 100644 drivers/gpu/drm/i915/intel_pm_types.h -- Jani Nikula, Intel Open Source Graphics Center

1 0

[PATCH v2 0/3] io-pgtable-arm + drm/msm: Extend iova fault debugging
by Rob Clark 14 Dec '21

14 Dec '21

From: Rob Clark <robdclark(a)chromium.org> This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. The motivation is tracking down an obscure iova fault triggered crash on the address of the IB1 cmdstream. This is one of the few places where the GPU address written into the cmdstream is soley under control of the kernel mode driver, so I don't think it can be a userspace bug. The logged cmdstream from the devcore's I've looked at look correct, and the TTBR0 read back from arm-smmu agrees with the kernel emitted cmdstream. Unfortunately it happens infrequently enough (something like once per 1000hrs of usage, from what I can tell from our telemetry) that actually reproducing it with an instrumented debug kernel is not an option. So further spiffying out the devcore dumps and hoping we can spot a clue is the plan I'm shooting for. See https://gitlab.freedesktop.org/drm/msm/-/issues/8 for more info on the issue I'm trying to debug. v2: Fix an armv7/32b build error in the last patch Rob Clark (3): iommu/io-pgtable-arm: Add way to debug pgtable walk drm/msm: Show all smmu info for iova fault devcore dumps drm/msm: Extend gpu devcore dumps with pgtbl info drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 35 +++++++++++++++++----- drivers/gpu/drm/msm/msm_gpu.c | 10 +++++++ drivers/gpu/drm/msm/msm_gpu.h | 10 ++++++- drivers/gpu/drm/msm/msm_iommu.c | 17 +++++++++++ drivers/gpu/drm/msm/msm_mmu.h | 2 ++ drivers/iommu/io-pgtable-arm.c | 40 ++++++++++++++++++++----- include/linux/io-pgtable.h | 9 ++++++ 8 files changed, 107 insertions(+), 18 deletions(-) -- 2.31.1

2 4

[PATCH] iommu/arm-smmu-qcom: Fix TTBR0 read
by Rob Clark 14 Dec '21

14 Dec '21

From: Rob Clark <robdclark(a)chromium.org> It is a 64b register, lets not lose the upper bits. Fixes: ab5df7b953d8 ("iommu/arm-smmu-qcom: Add an adreno-smmu-priv callback to get pagefault info") Signed-off-by: Rob Clark <robdclark(a)chromium.org> --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c index 55690af1b25d..c998960495b4 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c @@ -51,7 +51,7 @@ static void qcom_adreno_smmu_get_fault_info(const void *cookie, info->fsynr1 = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_FSYNR1); info->far = arm_smmu_cb_readq(smmu, cfg->cbndx, ARM_SMMU_CB_FAR); info->cbfrsynra = arm_smmu_gr1_read(smmu, ARM_SMMU_GR1_CBFRSYNRA(cfg->cbndx)); - info->ttbr0 = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_TTBR0); + info->ttbr0 = arm_smmu_cb_readq(smmu, cfg->cbndx, ARM_SMMU_CB_TTBR0); info->contextidr = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_CONTEXTIDR); } -- 2.31.1

3 2

[PATCH] drm/i915/ttm: fix large buffer population trucation
by Robert Beckett 14 Dec '21

14 Dec '21

ttm->num_pages is uint32_t which was causing very large buffers to only populate a truncated size. This fixes gem_create@create-clear igt test on large memory systems. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Robert Beckett <bob.beckett(a)collabora.com> --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 218a9b3037c7..923cc7ad8d70 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -166,7 +166,7 @@ static int i915_ttm_tt_shmem_populate(struct ttm_device *bdev, struct intel_memory_region *mr = i915->mm.regions[INTEL_MEMORY_SYSTEM]; struct i915_ttm_tt *i915_tt = container_of(ttm, typeof(*i915_tt), ttm); const unsigned int max_segment = i915_sg_segment_size(); - const size_t size = ttm->num_pages << PAGE_SHIFT; + const size_t size = (size_t)ttm->num_pages << PAGE_SHIFT; struct file *filp = i915_tt->filp; struct sgt_iter sgt_iter; struct sg_table *st; -- 2.25.1

3 2

[PATCH] drm/amdkfd: Fix missing check in kfd_parse_subtype_iolink
by Miaoqian Lin 14 Dec '21

14 Dec '21

The kmemdup() function may return NULL in case of error. Add NULL checking to prevent potential null deference. Signed-off-by: Miaoqian Lin <linmq006(a)gmail.com> --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index cfedfb1e8596..59d55f752aa7 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c @@ -1060,6 +1060,8 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink, return -ENODEV; /* same everything but the other direction */ props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL); + if (!props2) + return -ENOMEM; props2->node_from = id_to; props2->node_to = id_from; props2->kobj = NULL; -- 2.17.1

1 0

[PATCH v2] drm: mali-dp: potential dereference of null pointer
by Jiasheng Jiang 14 Dec '21

14 Dec '21

The return value of kzalloc() needs to be checked. To avoid use of null pointer '&state->base' in case of the failure of alloc. Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct") Signed-off-by: Jiasheng Jiang <jiasheng(a)iscas.ac.cn> Reported-by: Brian Starkey <brian.starkey(a)arm.com> --- Changelog: v1 -> v2 *Change 1. Add r-p. --- drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c index 494075ddbef6..b5928b52e279 100644 --- a/drivers/gpu/drm/arm/malidp_crtc.c +++ b/drivers/gpu/drm/arm/malidp_crtc.c @@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc) if (crtc->state) malidp_crtc_destroy_state(crtc, crtc->state); - __drm_atomic_helper_crtc_reset(crtc, &state->base); + if (state) + __drm_atomic_helper_crtc_reset(crtc, &state->base); + else + __drm_atomic_helper_crtc_reset(crtc, NULL); } static int malidp_crtc_enable_vblank(struct drm_crtc *crtc) -- 2.25.1

2 1

[PATCH v3] drm: mali-dp: potential dereference of null pointer
by Jiasheng Jiang 14 Dec '21

14 Dec '21

The return value of kzalloc() needs to be checked. To avoid use of null pointer '&state->base' in case of the failure of alloc. Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct") Signed-off-by: Jiasheng Jiang <jiasheng(a)iscas.ac.cn> Reviewed-by: Brian Starkey <brian.starkey(a)arm.com> --- Changelog: v2 -> v3 *Change 1. Change reported to reviewed. --- drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c index 494075ddbef6..b5928b52e279 100644 --- a/drivers/gpu/drm/arm/malidp_crtc.c +++ b/drivers/gpu/drm/arm/malidp_crtc.c @@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc) if (crtc->state) malidp_crtc_destroy_state(crtc, crtc->state); - __drm_atomic_helper_crtc_reset(crtc, &state->base); + if (state) + __drm_atomic_helper_crtc_reset(crtc, &state->base); + else + __drm_atomic_helper_crtc_reset(crtc, NULL); } static int malidp_crtc_enable_vblank(struct drm_crtc *crtc) -- 2.25.1

1 0

[PATCH] drm: tegra: use vmemdup_user instead of kvmalloc and copy_from_user
by Qing Wang 14 Dec '21

14 Dec '21

From: Wang Qing <wangqing(a)vivo.com> fix memdup_user.cocci warning: gpu/drm/tegra/submit.c:172:8-16: WARNING opportunity for vmemdup_user Signed-off-by: Wang Qing <wangqing(a)vivo.com> --- drivers/gpu/drm/tegra/submit.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index c326984..842a2d3 --- a/drivers/gpu/drm/tegra/submit.c +++ b/drivers/gpu/drm/tegra/submit.c @@ -169,16 +169,7 @@ static void *alloc_copy_user_array(void __user *from, size_t count, size_t size) if (copy_len > 0x4000) return ERR_PTR(-E2BIG); - data = kvmalloc(copy_len, GFP_KERNEL); - if (!data) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(data, from, copy_len)) { - kvfree(data); - return ERR_PTR(-EFAULT); - } - - return data; + return vmemdup_user(from, copy_len); } static int submit_copy_gather_data(struct gather_bo **pbo, struct device *dev, -- 2.7.4

1 0

[PATCH] drm: nouveau: use vmemdup_user instead of kvmalloc and copy_from_user
by Qing Wang 14 Dec '21

14 Dec '21

From: Wang Qing <wangqing(a)vivo.com> fix memdup_user.cocci warning: nouveau_gem.c:630:7-15: WARNING opportunity for vmemdup_user Signed-off-by: Wang Qing <wangqing(a)vivo.com> --- drivers/gpu/drm/nouveau/nouveau_gem.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 9416bee..befb864 --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -627,16 +627,7 @@ u_memcpya(uint64_t user, unsigned nmemb, unsigned size) size *= nmemb; - mem = kvmalloc(size, GFP_KERNEL); - if (!mem) - return ERR_PTR(-ENOMEM); - - if (copy_from_user(mem, userptr, size)) { - u_free(mem); - return ERR_PTR(-EFAULT); - } - - return mem; + return vmemdup_user(userptr, size); } static int -- 2.7.4

1 0

[PATCH] drm/arm/mali: potential dereference of null pointer
by Jiasheng Jiang 14 Dec '21

14 Dec '21

The return value of kzalloc() needs to be checked. To avoid use of null pointer '&mw_state->base' in case of the failure of alloc. Fixes: 8cbc5caf36ef ("drm: mali-dp: Add writeback connector") Signed-off-by: Jiasheng Jiang <jiasheng(a)iscas.ac.cn> --- drivers/gpu/drm/arm/malidp_mw.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index f5847a79dd7e..612d386ee7d2 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -70,7 +70,11 @@ static void malidp_mw_connector_reset(struct drm_connector *connector) __drm_atomic_helper_connector_destroy_state(connector->state); kfree(connector->state); - __drm_atomic_helper_connector_reset(connector, &mw_state->base); + + if (mw_state) + __drm_atomic_helper_connector_reset(connector, &mw_state->base); + else + __drm_atomic_helper_connector_reset(connector, NULL); } static enum drm_connector_status -- 2.25.1

2 1

← Newer
1
...
43
44
45
46
47
48
49
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel December 2021