dri-devel April 2021

dri-devel@lists.freedesktop.org

317 participants
715 discussions

[PATCH] drivers: i2c: i2c-core-smbus.c: Fix alignment of comment
by Shubhankar Kuranagatti 26 Jun '21

26 Jun '21

Multi line comment have been aligned starting with a * The closing */ has been shifted to a new line. Single space replaced with tab space This is done to maintain code uniformity. Signed-off-by: Shubhankar Kuranagatti <shubhankarvk(a)gmail.com> --- drivers/i2c/i2c-core-smbus.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c index d2d32c0fd8c3..205750518c21 100644 --- a/drivers/i2c/i2c-core-smbus.c +++ b/drivers/i2c/i2c-core-smbus.c @@ -66,10 +66,11 @@ static inline void i2c_smbus_add_pec(struct i2c_msg *msg) } /* Return <0 on CRC error - If there was a write before this read (most cases) we need to take the - partial CRC from the write part into account. - Note that this function does modify the message (we need to decrease the - message length to hide the CRC byte from the caller). */ + * If there was a write before this read (most cases) we need to take the + * partial CRC from the write part into account. + * Note that this function does modify the message (we need to decrease the + * message length to hide the CRC byte from the caller). + */ static int i2c_smbus_check_pec(u8 cpec, struct i2c_msg *msg) { u8 rpec = msg->buf[--msg->len]; @@ -113,7 +114,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte); s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value) { return i2c_smbus_xfer(client->adapter, client->addr, client->flags, - I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL); + I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL); } EXPORT_SYMBOL(i2c_smbus_write_byte); @@ -387,7 +388,8 @@ static s32 i2c_smbus_xfer_emulated(struct i2c_adapter *adapter, u16 addr, if (read_write == I2C_SMBUS_READ) { msg[1].flags |= I2C_M_RECV_LEN; msg[1].len = 1; /* block length will be added by - the underlying bus driver */ + * the underlying bus driver + */ i2c_smbus_try_get_dmabuf(&msg[1], 0); } else { msg[0].len = data->block[0] + 2; @@ -418,7 +420,8 @@ static s32 i2c_smbus_xfer_emulated(struct i2c_adapter *adapter, u16 addr, msg[1].flags |= I2C_M_RECV_LEN; msg[1].len = 1; /* block length will be added by - the underlying bus driver */ + * the underlying bus driver + */ i2c_smbus_try_get_dmabuf(&msg[1], 0); break; case I2C_SMBUS_I2C_BLOCK_DATA: -- 2.17.1

2 1

[Bug 212107] New: Temperature increase by 15°C on radeon gpu
by bugzilla-daemon＠bugzilla.kernel.org 24 Jun '21

24 Jun '21

https://bugzilla.kernel.org/show_bug.cgi?id=212107 Bug ID: 212107 Summary: Temperature increase by 15°C on radeon gpu Product: Drivers Version: 2.5 Kernel Version: 5.11 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: martin.tk(a)gmx.com Regression: No Created attachment 295701 --> https://bugzilla.kernel.org/attachment.cgi?id=295701&action=edit dmesg.log Since upgrading my kernel from 5.10.16 to 5.11.3 I noticed an increase in temperature on my AMD gpu (Radeon RX550). I later tried both 5.10.20 and 5.11.4 and I can notice the increase in temperature only on 5.11 kernel. In addition to the temperature I noticed that the fan on gpu would spin up to max rpm for a second or two right after waking up the PC from sleep. I've never noticed such behaviour before. I can't see any errors in the logs and the system seems to be running normal. No crashes nor degraded performance either. I check temperature using sensors utility. For 5.11.4 it shows the following: 1st run: amdgpu-pci-0100 Adapter: PCI adapter vddgfx: 962.00 mV fan1: 963 RPM (min = 0 RPM, max = 3500 RPM) edge: +54.0°C (crit = +97.0°C, hyst = -273.1°C) power1: 9.13 W (cap = 36.00 W) 2nd run few minutes later: amdgpu-pci-0100 Adapter: PCI adapter vddgfx: 825.00 mV fan1: 978 RPM (min = 0 RPM, max = 3500 RPM) edge: +47.0°C (crit = +97.0°C, hyst = -273.1°C) power1: 7.19 W (cap = 36.00 W) 5.11.3: amdgpu-pci-0100 Adapter: PCI adapter vddgfx: 962.00 mV fan1: 991 RPM (min = 0 RPM, max = 3500 RPM) edge: +57.0°C (crit = +97.0°C, hyst = -273.1°C) power1: 9.08 W (cap = 36.00 W) these two are on 5.10.16: amdgpu-pci-0100 Adapter: PCI adapter vddgfx: 787.00 mV fan1: 976 RPM (min = 0 RPM, max = 3500 RPM) edge: +39.0°C (crit = +97.0°C, hyst = -273.1°C) power1: 6.11 W (cap = 36.00 W) amdgpu-pci-0100 Adapter: PCI adapter vddgfx: 962.00 mV fan1: 976 RPM (min = 0 RPM, max = 3500 RPM) edge: +40.0°C (crit = +97.0°C, hyst = -273.1°C) power1: 8.26 W (cap = 36.00 W) I'm attaching parts of dmesg log I thought relevant. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 14

[PATCH 00/11] dma_fence critical sections annotations for atomic
by Daniel Vetter 22 Jun '21

22 Jun '21

Hi all, Finally gotten around to refreshing all the various fence anntotions I've hast last summer. Or well parts of it: - entire amdgpu and drm/scheduler annotations postponed for now, because there's way too many splats in there that need some work - in recent patches I've seen quite a few dma_resv_lock or kmalloc in atomic_commit_tail, which doesn't work in full generality with the rules for dma_fences we've discussed and encoded in lockdep. These annotations should catch stuff like this. Review comments and testing very much welcome. Cheers, Daniel Daniel Vetter (11): drm/atomic-helper: Add dma-fence annotations drm/vkms: Annotate vblank timer drm/vblank: Annotate with dma-fence signalling section drm/komeda: Annotate dma-fence critical section in commit path drm/malidp: Annotate dma-fence critical section in commit path drm/atmel: Use drm_atomic_helper_commit drm/imx: Annotate dma-fence critical section in commit path drm/omapdrm: Annotate dma-fence critical section in commit path drm/rcar-du: Annotate dma-fence critical section in commit path drm/tegra: Annotate dma-fence critical section in commit path drm/tidss: Annotate dma-fence critical section in commit path .../gpu/drm/arm/display/komeda/komeda_kms.c | 3 + drivers/gpu/drm/arm/malidp_drv.c | 3 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 107 +----------------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 7 -- drivers/gpu/drm/drm_atomic_helper.c | 16 +++ drivers/gpu/drm/drm_vblank.c | 8 +- drivers/gpu/drm/imx/imx-drm-core.c | 2 + drivers/gpu/drm/omapdrm/omap_drv.c | 9 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 + drivers/gpu/drm/tegra/drm.c | 3 + drivers/gpu/drm/tidss/tidss_kms.c | 4 + drivers/gpu/drm/vkms/vkms_crtc.c | 8 +- 12 files changed, 54 insertions(+), 118 deletions(-) -- 2.30.0

4 15

[Bug 210005] New: Kernel stacktrace, Xorg freezes
by bugzilla-daemon＠bugzilla.kernel.org 22 Jun '21

22 Jun '21

https://bugzilla.kernel.org/show_bug.cgi?id=210005 Bug ID: 210005 Summary: Kernel stacktrace, Xorg freezes Product: Drivers Version: 2.5 Kernel Version: 5.8.0-26-generic Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: amarandi(a)dshort.biz Regression: No Created attachment 293391 --> https://bugzilla.kernel.org/attachment.cgi?id=293391&action=edit syslog Hello guys, this is my first kernel bug report, so I hope I am doing it right. One line summary of the problem: At any unspecific point my whole system freezes and I cant recover it without an RESIUB / hard restart. Full description of the problem/report: This does not happen before I upgraded to Ubuntu 20.10. Before i had Ubuntu 20.04 (linux-image-5.4.0-52-generic) Distribution specific informations: Ubuntu 20.10 Kernel version: Linux version 5.8.0-26-generic (buildd@lcy01-amd64-025) (gcc (Ubuntu 10.2.0-13ubuntu1) 10.2.0, GNU ld (GNU Binutils for Ubuntu) 2.35.1) #27-Ubuntu SMP Wed Oct 21 22:29:16 UTC 2020 Hardware: Dell XPS 15 9560 Syslog message / kernel log in attachments. If you need additional informations please ask and I will provide them. Thank you! :) -- You are receiving this mail because: You are watching the assignee of the bug.

1 2

[Bug 212327] New: i915 / Kernel Mode Setting - Distorts Screen
by bugzilla-daemon＠bugzilla.kernel.org 22 Jun '21

22 Jun '21

https://bugzilla.kernel.org/show_bug.cgi?id=212327 Bug ID: 212327 Summary: i915 / Kernel Mode Setting - Distorts Screen Product: Drivers Version: 2.5 Kernel Version: 5.12.0-rc3 Hardware: Intel OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: roshan(a)rkarim.xyz Regression: No Created attachment 295913 --> https://bugzilla.kernel.org/attachment.cgi?id=295913&action=edit dmesg output Hello, I have this problem seemingly with the i915 driver. When kernel mode setting is active, only half of my screen attempts to display all of the pixels, with the other half turning all various shades of colours, but not working. Will attach an image below. Not totally sure what information to provide for this, so I've provided my dmesg output. Thanks, RK -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 2

[PATCH 1/2] drm: rcar-du: Don't put reference to drm_device in rcar_du_remove()
by Laurent Pinchart 21 Jun '21

21 Jun '21

The reference to the drm_device that was acquired by devm_drm_dev_alloc() is released automatically by the devres infrastructure. It must not be released manually, as that causes a reference underflow.. Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device") Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 43de3d8686e8..2a06ec1cbefb 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); - drm_dev_put(ddev); - return 0; } -- Regards, Laurent Pinchart

2 3

[PATCH] drm: rcar-du: Shutdown the display on system shutdown
by Laurent Pinchart 21 Jun '21

21 Jun '21

When the system shuts down or warm reboots, the display may be active, with the hardware accessing system memory. Upon reboot, the DDR will not be accessible, which may cause issues. Implement the platform_driver .shutdown() operation and shut down the display to fix this. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas(a)ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index bfbff90588cb..43de3d8686e8 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -561,6 +561,13 @@ static int rcar_du_remove(struct platform_device *pdev) return 0; } +static void rcar_du_shutdown(struct platform_device *pdev) +{ + struct rcar_du_device *rcdu = platform_get_drvdata(pdev); + + drm_atomic_helper_shutdown(&rcdu->ddev); +} + static int rcar_du_probe(struct platform_device *pdev) { struct rcar_du_device *rcdu; @@ -617,6 +624,7 @@ static int rcar_du_probe(struct platform_device *pdev) static struct platform_driver rcar_du_platform_driver = { .probe = rcar_du_probe, .remove = rcar_du_remove, + .shutdown = rcar_du_shutdown, .driver = { .name = "rcar-du", .pm = &rcar_du_pm_ops, -- Regards, Laurent Pinchart

2 1

[PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel
by Stefan Riedmueller 21 Jun '21

21 Jun '21

The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. Add the corresponding connector type and 8 bpc as default bus_format. Signed-off-by: Stefan Riedmueller <s.riedmueller(a)phytec.de> --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4e2dad314c79..44583d0ed902 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = { .width = 211, .height = 158, }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, + .connector_type = DRM_MODE_CONNECTOR_LVDS, }; static const struct drm_display_mode auo_g121ean01_mode = { -- 2.25.1

4 7

[PATCH] drm/atmel-hlcdc: Allow async page flips
by Dan Sneddon 19 Jun '21

19 Jun '21

The driver is capable of doing async page flips so we need to tell the core to allow them. Signed-off-by: Dan Sneddon <dan.sneddon(a)microchip.com> --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 871293d1aeeb..f6c3d8809fd8 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -686,6 +686,7 @@ static int atmel_hlcdc_dc_modeset_init(struct drm_device *dev) dev->mode_config.max_width = dc->desc->max_width; dev->mode_config.max_height = dc->desc->max_height; dev->mode_config.funcs = &mode_config_funcs; + dev->mode_config.async_page_flip = true; return 0; } -- 2.17.1

4 3

[PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc
by Tvrtko Ursulin 17 Jun '21

17 Jun '21

From: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> There is this long standing nit of igt/tools/intel_error_decode asserting when you feed it an error state from a GPU the local libdrm does not know of. To fix this I need a tweak in drm_intel_decode_context_alloc to make it not assert but just return NULL (which seems an already possible return value). Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> --- intel/intel_decode.c | 39 +++++++++++++++++++++------------------ 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/intel/intel_decode.c b/intel/intel_decode.c index e0a516644314..be6f77984d65 100644 --- a/intel/intel_decode.c +++ b/intel/intel_decode.c @@ -3815,32 +3815,35 @@ drm_public struct drm_intel_decode * drm_intel_decode_context_alloc(uint32_t devid) { struct drm_intel_decode *ctx; + int gen = 0; - ctx = calloc(1, sizeof(struct drm_intel_decode)); - if (!ctx) - return NULL; - - ctx->devid = devid; - ctx->out = stdout; - - if (intel_get_genx(devid, &ctx->gen)) + if (intel_get_genx(devid, &gen)) ; else if (IS_GEN8(devid)) - ctx->gen = 8; + gen = 8; else if (IS_GEN7(devid)) - ctx->gen = 7; + gen = 7; else if (IS_GEN6(devid)) - ctx->gen = 6; + gen = 6; else if (IS_GEN5(devid)) - ctx->gen = 5; + gen = 5; else if (IS_GEN4(devid)) - ctx->gen = 4; + gen = 4; else if (IS_9XX(devid)) - ctx->gen = 3; - else { - assert(IS_GEN2(devid)); - ctx->gen = 2; - } + gen = 3; + else if (IS_GEN2(devid)) + gen = 2; + + if (!gen) + return NULL; + + ctx = calloc(1, sizeof(struct drm_intel_decode)); + if (!ctx) + return NULL; + + ctx->devid = devid; + ctx->gen = gen; + ctx->out = stdout; return ctx; } -- 2.25.1

2 5

← Newer
1
...
7
8
9
10
11
12
13
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2021