dri-devel September 2021

dri-devel@lists.freedesktop.org

348 participants
817 discussions

[PATCH] drm/ttm: add a WARN_ON in ttm_set_driver_manager when array bounds (v2)
by Guchun Chen 13 Sep '21

13 Sep '21

Vendor will define their own memory types on top of TTM_PL_PRIV, but call ttm_set_driver_manager directly without checking mem_type value when setting up memory manager. So add such check to aware the case when array bounds. v2: lower check level to WARN_ON Signed-off-by: Leslie Shi <Yuliang.Shi(a)amd.com> Signed-off-by: Guchun Chen <guchun.chen(a)amd.com> --- include/drm/ttm/ttm_device.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h index 07d722950d5b..aa79953c807c 100644 --- a/include/drm/ttm/ttm_device.h +++ b/include/drm/ttm/ttm_device.h @@ -291,6 +291,7 @@ ttm_manager_type(struct ttm_device *bdev, int mem_type) static inline void ttm_set_driver_manager(struct ttm_device *bdev, int type, struct ttm_resource_manager *manager) { + WARN_ON(type >= TTM_NUM_MEM_TYPES); bdev->man_drv[type] = manager; } -- 2.17.1

4 3

[PATCH] drm/msm: Disable frequency clamping on a630
by Rob Clark 13 Sep '21

13 Sep '21

From: Rob Clark <robdclark(a)chromium.org> The more frequent frequency transitions resulting from clamping freq to minimum when the GPU is idle seems to be causing some issue with the bus getting voted off when it should be on. (An enable racing with an async disable?) This might be a problem outside of the GPU, as I can't reproduce this on a618 which uses the same GMU fw and same mechanism to communicate with GMU to set opp. For now, just revert to previous devfreq behavior on a630 until the issue is understood. Reported-by: Caleb Connolly <caleb.connolly(a)linaro.org> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") Signed-off-by: Rob Clark <robdclark(a)chromium.org> --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 3 +++ drivers/gpu/drm/msm/msm_gpu.h | 2 ++ drivers/gpu/drm/msm/msm_gpu_devfreq.c | 12 ++++++++++++ 3 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 748665232d29..9fd08b413010 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -945,6 +945,9 @@ int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev, pm_runtime_use_autosuspend(dev); pm_runtime_enable(dev); + if (adreno_is_a630(adreno_gpu)) + gpu->devfreq.disable_freq_clamping = true; + return msm_gpu_init(drm, pdev, &adreno_gpu->base, &funcs->base, adreno_gpu->info->name, &adreno_gpu_config); } diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 0e4b45bff2e6..7e11b667f939 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -112,6 +112,8 @@ struct msm_gpu_devfreq { * it is inactive. */ unsigned long idle_freq; + + bool disable_freq_clamping; }; struct msm_gpu { diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c index 0a1ee20296a2..a832af436251 100644 --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c @@ -94,6 +94,12 @@ void msm_devfreq_init(struct msm_gpu *gpu) if (!gpu->funcs->gpu_busy) return; + /* Revert to previous polling interval if we aren't using freq clamping + * to preserve previous behavior + */ + if (gpu->devfreq.disable_freq_clamping) + msm_devfreq_profile.polling_ms = 10; + msm_devfreq_profile.initial_freq = gpu->fast_rate; /* @@ -151,6 +157,9 @@ void msm_devfreq_active(struct msm_gpu *gpu) unsigned int idle_time; unsigned long target_freq = df->idle_freq; + if (gpu->devfreq.disable_freq_clamping) + return; + /* * Hold devfreq lock to synchronize with get_dev_status()/ * target() callbacks @@ -186,6 +195,9 @@ void msm_devfreq_idle(struct msm_gpu *gpu) struct msm_gpu_devfreq *df = &gpu->devfreq; unsigned long idle_freq, target_freq = 0; + if (gpu->devfreq.disable_freq_clamping) + return; + /* * Hold devfreq lock to synchronize with get_dev_status()/ * target() callbacks -- 2.31.1

7 37

[PATCH] dt-bindings: More use 'enum' instead of 'oneOf' plus 'const' entries
by Rob Herring 13 Sep '21

13 Sep '21

'enum' is equivalent to 'oneOf' with a list of 'const' entries, but 'enum' is more concise and yields better error messages. Fix a couple more cases which have appeared. Cc: Rob Clark <robdclark(a)gmail.com> Cc: Sean Paul <sean(a)poorly.run> Cc: Mark Brown <broonie(a)kernel.org> Cc: Wim Van Sebroeck <wim(a)linux-watchdog.org> Cc: Guenter Roeck <linux(a)roeck-us.net> Cc: Jonathan Marek <jonathan(a)marek.ca> Cc: Aswath Govindraju <a-govindraju(a)ti.com> Cc: Marc Zyngier <maz(a)kernel.org> Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: dri-devel(a)lists.freedesktop.org Cc: freedreno(a)lists.freedesktop.org Cc: linux-spi(a)vger.kernel.org Cc: linux-watchdog(a)vger.kernel.org Signed-off-by: Rob Herring <robh(a)kernel.org> --- .../bindings/display/msm/dsi-phy-7nm.yaml | 8 ++++---- .../devicetree/bindings/spi/omap-spi.yaml | 6 +++--- .../bindings/watchdog/maxim,max63xx.yaml | 14 +++++++------- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml index 4265399bb154..c851770bbdf2 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml @@ -14,10 +14,10 @@ allOf: properties: compatible: - oneOf: - - const: qcom,dsi-phy-7nm - - const: qcom,dsi-phy-7nm-8150 - - const: qcom,sc7280-dsi-phy-7nm + enum: + - qcom,dsi-phy-7nm + - qcom,dsi-phy-7nm-8150 + - qcom,sc7280-dsi-phy-7nm reg: items: diff --git a/Documentation/devicetree/bindings/spi/omap-spi.yaml b/Documentation/devicetree/bindings/spi/omap-spi.yaml index e55538186cf6..9952199cae11 100644 --- a/Documentation/devicetree/bindings/spi/omap-spi.yaml +++ b/Documentation/devicetree/bindings/spi/omap-spi.yaml @@ -84,9 +84,9 @@ unevaluatedProperties: false if: properties: compatible: - oneOf: - - const: ti,omap2-mcspi - - const: ti,omap4-mcspi + enum: + - ti,omap2-mcspi + - ti,omap4-mcspi then: properties: diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml index f2105eedac2c..ab9641e845db 100644 --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml @@ -15,13 +15,13 @@ maintainers: properties: compatible: - oneOf: - - const: maxim,max6369 - - const: maxim,max6370 - - const: maxim,max6371 - - const: maxim,max6372 - - const: maxim,max6373 - - const: maxim,max6374 + enum: + - maxim,max6369 + - maxim,max6370 + - maxim,max6371 + - maxim,max6372 + - maxim,max6373 + - maxim,max6374 reg: description: This is a 1-byte memory-mapped address -- 2.30.2

4 3

BUG: unable to handle kernel paging request in imageblit
by Hao Sun 13 Sep '21

13 Sep '21

Hello, When using Healer to fuzz the Linux kernel, the following crash was triggered. HEAD commit: ac08b1c68d1b Merge tag 'pci-v5.15-changes' git tree: upstream console output: https://drive.google.com/file/d/1Vvyiebkb1BAbgnM8QXg4XeotLYE7Xrk6/view?usp=… kernel config: https://drive.google.com/file/d/1qrJUXD8ZIeAkg-xojzDpp04v9MtQ8RR6/view?usp=… C reproducer: https://drive.google.com/file/d/1p79Nwcx6l7pC0qLZnbHFvr5FLSR79x0J/view?usp=… Syzlang reproducer: https://drive.google.com/file/d/1MT6DvJG2lMonmimV6XbED-I_STFMvaFo/view?usp=… If you fix this issue, please add the following tag to the commit: Reported-by: Hao Sun <sunhao.th(a)gmail.com> BUG: unable to handle page fault for address: ffffc90007731480 #PF: supervisor write access in kernel mode #PF: error_code(0x0002) - not-present page PGD 8c00067 P4D 8c00067 PUD 8d63067 PMD 1026f8067 PTE 0 Oops: 0002 [#1] PREEMPT SMP CPU: 0 PID: 10837 Comm: syz-executor Not tainted 5.14.0+ #15 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014 RIP: 0010:fast_imageblit drivers/video/fbdev/core/sysimgblt.c:229 [inline] RIP: 0010:sys_imageblit+0x48c/0x830 drivers/video/fbdev/core/sysimgblt.c:275 Code: 04 41 0f be 5d 00 83 fd 1f 0f 87 75 03 00 00 e8 5a d5 f9 fe 89 e9 8b 44 24 14 d3 fb 23 5c 24 08 41 23 04 9f 33 44 24 04 85 ed <41> 89 44 24 fc 75 b9 e8 38 d5 f9 fe 49 83 c5 01 bd 08 00 00 00 e8 RSP: 0018:ffffc9000928f890 EFLAGS: 00010202 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000007 RDX: 0000000000040000 RSI: ffffffff823dbcd6 RDI: ffffc9000928f9f0 RBP: 0000000000000007 R08: 0000000000000018 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000002 R12: ffffc90007731484 R13: ffff88810496f13c R14: ffffc90007731500 R15: ffffffff849e52c0 FS: 00007fef7bf33700(0000) GS:ffff88807dc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc90007731480 CR3: 000000001ef3e000 CR4: 0000000000750ef0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: drm_fb_helper_sys_imageblit+0x18/0x40 drivers/gpu/drm/drm_fb_helper.c:794 drm_fbdev_fb_imageblit+0x4b/0xa0 drivers/gpu/drm/drm_fb_helper.c:2276 bit_putcs_unaligned drivers/video/fbdev/core/bitblit.c:139 [inline] bit_putcs+0x33c/0x590 drivers/video/fbdev/core/bitblit.c:188 fbcon_putcs+0x13f/0x1a0 drivers/video/fbdev/core/fbcon.c:1296 do_update_region+0x163/0x230 drivers/tty/vt/vt.c:676 invert_screen+0x105/0x280 drivers/tty/vt/vt.c:800 highlight drivers/tty/vt/selection.c:57 [inline] clear_selection+0x48/0x60 drivers/tty/vt/selection.c:84 vc_do_resize+0x60b/0x6f0 drivers/tty/vt/vt.c:1257 fbcon_do_set_font+0x188/0x2a0 drivers/video/fbdev/core/fbcon.c:2397 fbcon_set_font+0x333/0x450 drivers/video/fbdev/core/fbcon.c:2483 con_font_set drivers/tty/vt/vt.c:4666 [inline] con_font_op+0x238/0x4b0 drivers/tty/vt/vt.c:4710 vt_k_ioctl drivers/tty/vt/vt_ioctl.c:474 [inline] vt_ioctl+0xd05/0x1890 drivers/tty/vt/vt_ioctl.c:752 tty_ioctl+0x114/0xb00 drivers/tty/tty_io.c:2805 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl fs/ioctl.c:860 [inline] __x64_sys_ioctl+0xb6/0x100 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x34/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x46a9a9 Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fef7bf32c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 000000000078c0a0 RCX: 000000000046a9a9 RDX: 0000000020000080 RSI: 0000000000004b72 RDI: 0000000000000004 RBP: 00000000004e4042 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000078c0a0 R13: 0000000000000000 R14: 000000000078c0a0 R15: 00007fff66610a60 Modules linked in: Dumping ftrace buffer: (ftrace buffer empty) CR2: ffffc90007731480 ---[ end trace b77be2f6638c5c66 ]--- RIP: 0010:fast_imageblit drivers/video/fbdev/core/sysimgblt.c:229 [inline] RIP: 0010:sys_imageblit+0x48c/0x830 drivers/video/fbdev/core/sysimgblt.c:275 Code: 04 41 0f be 5d 00 83 fd 1f 0f 87 75 03 00 00 e8 5a d5 f9 fe 89 e9 8b 44 24 14 d3 fb 23 5c 24 08 41 23 04 9f 33 44 24 04 85 ed <41> 89 44 24 fc 75 b9 e8 38 d5 f9 fe 49 83 c5 01 bd 08 00 00 00 e8 RSP: 0018:ffffc9000928f890 EFLAGS: 00010202 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000007 RDX: 0000000000040000 RSI: ffffffff823dbcd6 RDI: ffffc9000928f9f0 RBP: 0000000000000007 R08: 0000000000000018 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000002 R12: ffffc90007731484 R13: ffff88810496f13c R14: ffffc90007731500 R15: ffffffff849e52c0 FS: 00007fef7bf33700(0000) GS:ffff88807dc00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc90007731480 CR3: 000000001ef3e000 CR4: 0000000000750ef0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 ---------------- Code disassembly (best guess): 0: 04 41 add $0x41,%al 2: 0f be 5d 00 movsbl 0x0(%rbp),%ebx 6: 83 fd 1f cmp $0x1f,%ebp 9: 0f 87 75 03 00 00 ja 0x384 f: e8 5a d5 f9 fe callq 0xfef9d56e 14: 89 e9 mov %ebp,%ecx 16: 8b 44 24 14 mov 0x14(%rsp),%eax 1a: d3 fb sar %cl,%ebx 1c: 23 5c 24 08 and 0x8(%rsp),%ebx 20: 41 23 04 9f and (%r15,%rbx,4),%eax 24: 33 44 24 04 xor 0x4(%rsp),%eax 28: 85 ed test %ebp,%ebp * 2a: 41 89 44 24 fc mov %eax,-0x4(%r12) <-- trapping instruction 2f: 75 b9 jne 0xffffffea 31: e8 38 d5 f9 fe callq 0xfef9d56e 36: 49 83 c5 01 add $0x1,%r13 3a: bd 08 00 00 00 mov $0x8,%ebp 3f: e8 .byte 0xe8

1 0

[PATCH] drm/rockchip: fix a -Werror fail on !CONFIG_PM_SLEEP
by Adam Borowski 12 Sep '21

12 Sep '21

Signed-off-by: Adam Borowski <kilobyte(a)angband.pl> --- With Linus suddenly loving -Werror, let's get clean. drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index 8ab3247dbc4a..bee0f2d2a9be 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -1123,6 +1123,7 @@ static int cdn_dp_suspend(struct device *dev) return ret; } +#ifdef CONFIG_PM_SLEEP static int cdn_dp_resume(struct device *dev) { struct cdn_dp_device *dp = dev_get_drvdata(dev); @@ -1135,6 +1136,7 @@ static int cdn_dp_resume(struct device *dev) return 0; } +#endif static int cdn_dp_probe(struct platform_device *pdev) { -- 2.33.0

2 1

[PATCH] drm/panel-orientation-quirks: add Valve Steam Deck
by Simon Ser 12 Sep '21

12 Sep '21

Valve's Steam Deck has a 800x1280 LCD screen. Signed-off-by: Simon Ser <contact(a)emersion.fr> Cc: Jared Baldridge <jrb(a)expunge.us> Cc: Emil Velikov <emil.l.velikov(a)gmail.com> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Hans de Goede <hdegoede(a)redhat.com> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index f6bdec7fa925..3018d1dcd271 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -231,6 +231,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"), }, .driver_data = (void *)&lcd800x1280_rightside_up, + }, { /* Valve Steam Deck */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"), + }, + .driver_data = (void *)&lcd800x1280_rightside_up, }, {} }; -- 2.33.0

3 3

[PATCH] drm: panel-orientation-quirks: Add quirk for the Chuwi HiBook
by Hans de Goede 12 Sep '21

12 Sep '21

The Chuwi HiBook uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 4e965b0f5502..7e0f581a360e 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -140,6 +140,14 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"), }, .driver_data = (void *)&lcd800x1280_rightside_up, + }, { /* Chuwi HiBook (CWI514) */ + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), + /* Above matches are too generic, add bios-date match */ + DMI_MATCH(DMI_BIOS_DATE, "05/07/2016"), + }, + .driver_data = (void *)&lcd1200x1920_rightside_up, }, { /* Chuwi Hi10 Pro (CWI529) */ .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hampoo"), -- 2.31.1

2 3

[Bug 214369] New: Radeon HD5770 incorrect refresh rate via display port
by bugzilla-daemon＠bugzilla.kernel.org 11 Sep '21

11 Sep '21

https://bugzilla.kernel.org/show_bug.cgi?id=214369 Bug ID: 214369 Summary: Radeon HD5770 incorrect refresh rate via display port Product: Drivers Version: 2.5 Kernel Version: 5.14.2 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: roxmail(a)list.ru Regression: No Created attachment 298751 --> https://bugzilla.kernel.org/attachment.cgi?id=298751&action=edit dmesg Monitor connected via display port to radeon hd5770 card. Mouse cursor and windows movements are choppy, monitor says that video mode are 1920x1080 at 44Hz. $ xrandr Screen 0: minimum 320 x 200, current 1920 x 1080, maximum 8192 x 8192 DisplayPort-0 connected primary 1920x1080+0+0 (normal left inverted right x axis y axis) 600mm x 340mm 1920x1080 60.00*+ 59.94 3840x2160 30.00 2560x1440 59.95 1920x1080_59.94 59.94 1920x1080_59.55 59.53 1920x1080_59.57 59.57 1920x1080_59.56 59.56 1920x1080_59.53 59.53 1600x900 60.00 1280x1024 60.02 1280x800 59.81 1280x720 60.00 59.94 1024x768 60.00 800x600 60.32 720x480 60.00 59.94 640x480 60.00 59.94 HDMI-0 disconnected (normal left inverted right x axis y axis) DVI-0 disconnected (normal left inverted right x axis y axis) DVI-1 disconnected (normal left inverted right x axis y axis) With 2560x1440 refresh rate are 27Hz (from monitor), and there are black screen while trying to set 3840x2160. I don't know whether it's regression. hdmi and dvi works as expected (at least with 1920x1080). -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 0

[PATCH 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status
by AngeloGioacchino Del Regno 11 Sep '21

11 Sep '21

Add a function that returns whether the requested CTL is active or not: this will be used in a later commit to fix command mode panel issues. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno(a)somainline.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 6 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c index 64740ddb983e..3b6fd73eb3a8 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c @@ -91,6 +91,11 @@ static inline void dpu_hw_ctl_trigger_start(struct dpu_hw_ctl *ctx) DPU_REG_WRITE(&ctx->hw, CTL_START, 0x1); } +static inline bool dpu_hw_ctl_is_started(struct dpu_hw_ctl *ctx) +{ + return !!(DPU_REG_READ(&ctx->hw, CTL_START) & BIT(0)); +} + static inline void dpu_hw_ctl_trigger_pending(struct dpu_hw_ctl *ctx) { trace_dpu_hw_ctl_trigger_prepare(ctx->pending_flush_mask, @@ -579,6 +584,7 @@ static void _setup_ctl_ops(struct dpu_hw_ctl_ops *ops, ops->get_pending_flush = dpu_hw_ctl_get_pending_flush; ops->get_flush_register = dpu_hw_ctl_get_flush_register; ops->trigger_start = dpu_hw_ctl_trigger_start; + ops->is_started = dpu_hw_ctl_is_started; ops->trigger_pending = dpu_hw_ctl_trigger_pending; ops->reset = dpu_hw_ctl_reset_control; ops->wait_reset_status = dpu_hw_ctl_wait_reset_status; diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h index 806c171e5df2..ac1544474022 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h @@ -61,6 +61,13 @@ struct dpu_hw_ctl_ops { */ void (*trigger_start)(struct dpu_hw_ctl *ctx); + /** + * check if the ctl is started + * @ctx : ctl path ctx pointer + * @Return: true if started, false if stopped + */ + bool (*is_started)(struct dpu_hw_ctl *ctx); + /** * kickoff prepare is in progress hw operation for sw * controlled interfaces: DSI cmd mode and WB interface -- 2.32.0

2 3

Re: [Intel-gfx] [PATCH] drm/i915: Add ww context to intel_dpt_pin (fwd)
by Julia Lawall 11 Sep '21

11 Sep '21

I don't seem to have received any other message about this, but from the URL below, the referenced code seems to be: if (IS_ERR(iomem)) { err = PTR_ERR(vma); continue; } It seems that the argument of PTR_ERR should be iomem, because vma has already been tested. julia ---------- Forwarded message ---------- Date: Sat, 11 Sep 2021 09:14:18 +0800 From: kernel test robot <lkp(a)intel.com> To: kbuild(a)lists.01.org Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add ww context to intel_dpt_pin CC: kbuild-all(a)lists.01.org In-Reply-To: <20210910081942.1075038-1-maarten.lankhorst(a)linux.intel.com> References: <20210910081942.1075038-1-maarten.lankhorst(a)linux.intel.com> TO: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> TO: intel-gfx(a)lists.freedesktop.org CC: dri-devel(a)lists.freedesktop.org CC: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Hi Maarten, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14 next-20210910] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Add-ww-… base: git://anongit.freedesktop.org/drm/drm-tip drm-tip :::::: branch date: 17 hours ago :::::: commit date: 17 hours ago config: x86_64-randconfig-c002-20210910 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> Reported-by: Julia Lawall <julia.lawall(a)lip6.fr> cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/i915/display/intel_dpt.c:145:6-12: inconsistent IS_ERR and PTR_ERR on line 146. Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

← Newer
1
...
59
60
61
62
63
64
65
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2021