dri-devel September 2021

dri-devel@lists.freedesktop.org

348 participants
817 discussions

linux-next: build failure after merge of the drm tree
by Stephen Rothwell 08 Sep '21

08 Sep '21

Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/gpu/drm/i915/i915_debugfs.c:39: drivers/gpu/drm/i915/gt/intel_gt_requests.h:9:10: fatal error: stddef.h: No such file or directory 9 | #include <stddef.h> | ^~~~~~~~~~ Caused by commit 564f963eabd1 ("isystem: delete global -isystem compile option") from the kbuild tree interacting with commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") I have applied the following patch for today. From: Stephen Rothwell <sfr(a)canb.auug.org.au> Date: Fri, 20 Aug 2021 12:24:19 +1000 Subject: [PATCH] drm/i915: use linux/stddef.h due to "isystem: trim/fixup stdarg.h and other headers" Signed-off-by: Stephen Rothwell <sfr(a)canb.auug.org.au> --- drivers/gpu/drm/i915/gt/intel_gt_requests.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.h b/drivers/gpu/drm/i915/gt/intel_gt_requests.h index 51dbe0e3294e..d2969f68dd64 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_requests.h +++ b/drivers/gpu/drm/i915/gt/intel_gt_requests.h @@ -6,7 +6,7 @@ #ifndef INTEL_GT_REQUESTS_H #define INTEL_GT_REQUESTS_H -#include <stddef.h> +#include <linux/stddef.h> struct intel_engine_cs; struct intel_gt; -- 2.32.0 -- Cheers, Stephen Rothwell

3 6

[PATCH v4] drm/i915: Use Transparent Hugepages when IOMMU is enabled
by Tvrtko Ursulin 08 Sep '21

08 Sep '21

From: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Usage of Transparent Hugepages was disabled in 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A"), but since it appears majority of performance regressions reported with an enabled IOMMU can be almost eliminated by turning them on, lets just do that. To err on the side of safety we keep the current default in cases where IOMMU is not active, and only when it is default to the "huge=within_size" mode. Although there probably would be wins to enable them throughout, more extensive testing across benchmarks and platforms would need to be done. With the patch and IOMMU enabled my local testing on a small Skylake part shows OglVSTangent regression being reduced from ~14% (IOMMU on versus IOMMU off) to ~2% (same comparison but with THP on). More detailed testing done in the below referenced Gitlab issue by Eero: Skylake GT4e: Performance drops from enabling IOMMU: 30-35% SynMark CSDof 20-25% Unigine Heaven, MemBW GPU write, SynMark VSTangent ~20% GLB Egypt (1/2 screen window) 10-15% GLB T-Rex (1/2 screen window) 8-10% GfxBench T-Rex, MemBW GPU blit 7-8% SynMark DeferredAA + TerrainFly* + ZBuffer 6-7% GfxBench Manhattan 3.0 + 3.1, SynMark TexMem128 & CSCloth 5-6% GfxBench CarChase, Unigine Valley 3-5% GfxBench Vulkan & GL AztecRuins + ALU2, MemBW GPU texture, SynMark Fill*, Deferred, TerrainPan* 1-2% Most of the other tests With the patch drops become: 20-25% SynMark TexMem* 15-20% GLB Egypt (1/2 screen window) 10-15% GLB T-Rex (1/2 screen window) 4-7% GfxBench T-Rex, GpuTest Triangle 1-8% GfxBench ALU2 (offscreen 1%, onscreen 8%) 3% GfxBench Manhattan 3.0, SynMark CSDof 2-3% Unigine Heaven + Valley, MemBW GPU texture 1-3 GfxBench Manhattan 3.1 + CarChase + Vulkan & GL AztecRuins Broxton: Performance drops from IOMMU, without patch: 30% MemBW GPU write 25% SynMark ZBuffer + Fill* 20% MemBW GPU blit 15% MemBW GPU blend, GpuTest Triangle 10-15% MemBW GPU texture 10% GLB Egypt, Unigine Heaven (had hangs), SynMark TerrainFly* 7-9% GLB T-Rex, GfxBench Manhattan 3.0 + T-Rex, SynMark Deferred* + TexMem* 6-8% GfxBench CarChase, Unigine Valley, SynMark CSCloth + ShMapVsm + TerrainPan* 5-6% GfxBench Manhattan 3.1 + GL AztecRuins, SynMark CSDof + TexFilterTri 2-4% GfxBench ALU2, SynMark DrvRes + GSCloth + ShMapPcf + Batch[0-5] + TexFilterAniso, GpuTest GiMark + 32-bit Julia And with patch: 15-20% MemBW GPU texture 10% SynMark TexMem* 8-9% GLB Egypt (1/2 screen window) 4-5% GLB T-Rex (1/2 screen window) 3-6% GfxBench Manhattan 3.0, GpuTest FurMark, SynMark Deferred + TexFilterTri 3-4% GfxBench Manhattan 3.1 + T-Rex, SynMark VSInstancing 2-4% GpuTest Triangle, SynMark DeferredAA 2-3% Unigine Heaven + Valley 1-3% SynMark Terrain* 1-2% GfxBench CarChase, SynMark TexFilterAniso + ZBuffer Tigerlake-H: 20-25% MemBW GPU texture 15-20% GpuTest Triangle 13-15% SynMark TerrainFly* + DeferredAA + HdrBloom 8-10% GfxBench Manhattan 3.1, SynMark TerrainPan* + DrvRes 6-7% GfxBench Manhattan 3.0, SynMark TexMem* 4-8% GLB onscreen Fill + T-Rex + Egypt (more in onscreen than offscreen versions of T-Rex/Egypt) 4-6% GfxBench CarChase + GLES AztecRuins + ALU2, GpuTest 32-bit Julia, SynMark CSDof + DrvState 3-5% GfxBench T-Rex + Egypt, Unigine Heaven + Valley, GpuTest Plot3D 1-7% Media tests 2-3% MemBW GPU blit 1-3% Most of the rest of 3D tests With the patch: 6-8% MemBW GPU blend => the only regression in these tests (compared to IOMMU without THP) 4-6% SynMark DrvState (not impacted) + HdrBloom (improved) 3-4% GLB T-Rex ~3% GLB Egypt, SynMark DrvRes 1-3% GfxBench T-Rex + Egypt, SynMark TexFilterTri 1-2% GfxBench CarChase + GLES AztecRuins, Unigine Valley, GpuTest Triangle ~1% GfxBench Manhattan 3.0/3.1, Unigine Heaven Perf of several tests actually improved with IOMMU + THP, compared to no IOMMU / no THP: 10-15% SynMark Batch[0-3] 5-10% MemBW GPU texture, SynMark ShMapVsm 3-4% SynMark Fill* + Geom* 2-3% SynMark TexMem512 + CSCloth 1-2% SynMark TexMem128 + DeferredAA v2: * Add Kconfig dependency to transparent hugepages and some help text. * Move to helper for easier handling of kernel build options. v3: * Drop Kconfig. (Daniel) v4: * Add some benchmark results to commit message. References: b901bb89324a ("drm/i915/gemfs: enable THP") References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A") References: https://gitlab.freedesktop.org/drm/intel/-/issues/430 Co-developed-by: Chris Wilson <chris(a)chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Matthew Auld <matthew.auld(a)intel.com> Cc: Eero Tamminen <eero.t.tamminen(a)intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi(a)intel.com> # v1 --- drivers/gpu/drm/i915/gem/i915_gemfs.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c index 5e6e8c91ab38..dbdbdc344d87 100644 --- a/drivers/gpu/drm/i915/gem/i915_gemfs.c +++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c @@ -6,7 +6,6 @@ #include <linux/fs.h> #include <linux/mount.h> -#include <linux/pagemap.h> #include "i915_drv.h" #include "i915_gemfs.h" @@ -15,6 +14,7 @@ int i915_gemfs_init(struct drm_i915_private *i915) { struct file_system_type *type; struct vfsmount *gemfs; + char *opts; type = get_fs_type("tmpfs"); if (!type) @@ -26,10 +26,26 @@ int i915_gemfs_init(struct drm_i915_private *i915) * * One example, although it is probably better with a per-file * control, is selecting huge page allocations ("huge=within_size"). - * Currently unused due to bandwidth issues (slow reads) on Broadwell+. + * However, we only do so to offset the overhead of iommu lookups + * due to bandwidth issues (slow reads) on Broadwell+. */ - gemfs = kern_mount(type); + opts = NULL; + if (intel_vtd_active()) { + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { + static char huge_opt[] = "huge=within_size"; /* r/w */ + + opts = huge_opt; + drm_info(&i915->drm, + "Transparent Hugepage mode '%s'\n", + opts); + } else { + drm_notice(&i915->drm, + "Transparent Hugepage support is recommended for optimal performance when IOMMU is enabled!\n"); + } + } + + gemfs = vfs_kern_mount(type, SB_KERNMOUNT, type->name, opts); if (IS_ERR(gemfs)) return PTR_ERR(gemfs); -- 2.30.2

2 2

[drm:i915-vtable-cleanup 12/12] drivers/gpu/drm/i915/display/intel_audio.c:852:24: error: member reference type 'const struct drm_i915_display_audio_funcs *' is a pointer; did you mean to use '->'?
by kernel test robot 08 Sep '21

08 Sep '21

tree: git://people.freedesktop.org/~airlied/linux.git i915-vtable-cleanup head: b0d0061aeef594fc572295c0e3c02ba91596cbf6 commit: b0d0061aeef594fc572295c0e3c02ba91596cbf6 [12/12] drm/i915/display: constify the audio functions config: x86_64-randconfig-a016-20210906 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9c476172b93367d2cb88d7d3f4b1b5b456fa6020) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add drm git://people.freedesktop.org/~airlied/linux.git git fetch --no-tags drm i915-vtable-cleanup git checkout b0d0061aeef594fc572295c0e3c02ba91596cbf6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): >> drivers/gpu/drm/i915/display/intel_audio.c:852:24: error: member reference type 'const struct drm_i915_display_audio_funcs *' is a pointer; did you mean to use '->'? dev_priv->audio_funcs.audio_codec_enable(encoder, ~~~~~~~~~~~~~~~~~~~~~^ -> drivers/gpu/drm/i915/display/intel_audio.c:897:24: error: member reference type 'const struct drm_i915_display_audio_funcs *' is a pointer; did you mean to use '->'? dev_priv->audio_funcs.audio_codec_disable(encoder, ~~~~~~~~~~~~~~~~~~~~~^ -> >> drivers/gpu/drm/i915/display/intel_audio.c:919:46: error: expected '}' .audio_codec_enable = g4x_audio_codec_enable; ^ drivers/gpu/drm/i915/display/intel_audio.c:918:68: note: to match this '{' static const struct drm_i915_display_audio_funcs g4x_audio_funcs = { ^ >> drivers/gpu/drm/i915/display/intel_audio.c:920:2: error: expected identifier or '(' .audio_codec_disable = g4x_audio_codec_disable; ^ >> drivers/gpu/drm/i915/display/intel_audio.c:921:1: error: extraneous closing brace ('}') }; ^ drivers/gpu/drm/i915/display/intel_audio.c:924:46: error: expected '}' .audio_codec_enable = ilk_audio_codec_enable; ^ drivers/gpu/drm/i915/display/intel_audio.c:923:68: note: to match this '{' static const struct drm_i915_display_audio_funcs ilk_audio_funcs = { ^ drivers/gpu/drm/i915/display/intel_audio.c:925:2: error: expected identifier or '(' .audio_codec_disable = ilk_audio_codec_disable; ^ drivers/gpu/drm/i915/display/intel_audio.c:926:1: error: extraneous closing brace ('}') }; ^ drivers/gpu/drm/i915/display/intel_audio.c:929:46: error: expected '}' .audio_codec_enable = hsw_audio_codec_enable; ^ drivers/gpu/drm/i915/display/intel_audio.c:928:68: note: to match this '{' static const struct drm_i915_display_audio_funcs hsw_audio_funcs = { ^ drivers/gpu/drm/i915/display/intel_audio.c:930:2: error: expected identifier or '(' .audio_codec_disable = hsw_audio_codec_disable; ^ drivers/gpu/drm/i915/display/intel_audio.c:931:1: error: extraneous closing brace ('}') }; ^ 11 errors generated. vim +852 drivers/gpu/drm/i915/display/intel_audio.c 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 814 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 815 /** 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 816 * intel_audio_codec_enable - Enable the audio codec for HD audio 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 817 * @encoder: encoder on which to enable audio bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 818 * @crtc_state: pointer to the current crtc state. bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 819 * @conn_state: pointer to the current connector state. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 820 * 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 821 * The enable sequences may only be performed after enabling the transcoder and 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 822 * port, and after completed link training. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 823 */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 824 void intel_audio_codec_enable(struct intel_encoder *encoder, bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 825 const struct intel_crtc_state *crtc_state, bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 826 const struct drm_connector_state *conn_state) 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 827 { 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 828 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 829 struct i915_audio_component *acomp = dev_priv->audio_component; 2225f3c6f1d793 drivers/gpu/drm/i915/display/intel_audio.c Maarten Lankhorst 2019-10-31 830 struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 831 struct drm_connector *connector = conn_state->connector; 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 832 const struct drm_display_mode *adjusted_mode = 1326a92c346641 drivers/gpu/drm/i915/display/intel_audio.c Maarten Lankhorst 2019-10-31 833 &crtc_state->hw.adjusted_mode; 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 834 enum port port = encoder->port; 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 835 enum pipe pipe = crtc->pipe; 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 836 abf4b8ed42e9dc drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2019-04-30 837 /* FIXME precompute the ELD in .compute_config() */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 838 if (!connector->eld[0]) 6385514932d5fc drivers/gpu/drm/i915/display/intel_audio.c Wambui Karuga 2020-01-21 839 drm_dbg_kms(&dev_priv->drm, 6385514932d5fc drivers/gpu/drm/i915/display/intel_audio.c Wambui Karuga 2020-01-21 840 "Bogus ELD on [CONNECTOR:%d:%s]\n", abf4b8ed42e9dc drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2019-04-30 841 connector->base.id, connector->name); 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 842 6385514932d5fc drivers/gpu/drm/i915/display/intel_audio.c Wambui Karuga 2020-01-21 843 drm_dbg(&dev_priv->drm, "ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n", 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 844 connector->base.id, 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 845 connector->name, 79003e61b1fbfd drivers/gpu/drm/i915/display/intel_audio.c Ville Syrjälä 2019-12-04 846 encoder->base.base.id, 79003e61b1fbfd drivers/gpu/drm/i915/display/intel_audio.c Ville Syrjälä 2019-12-04 847 encoder->base.name); 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 848 124abe076fd8b3 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2015-09-08 849 connector->eld[6] = drm_av_sync_delay(connector, adjusted_mode) / 2; 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 850 b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 851 if (dev_priv->audio_funcs) 9c1ce0dbf2c66b drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 @852 dev_priv->audio_funcs.audio_codec_enable(encoder, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 853 crtc_state, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 854 conn_state); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 855 cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 856 mutex_lock(&dev_priv->av_mutex); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 857 encoder->audio_connector = connector; f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 858 9dfbffcf4ac070 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2016-02-24 859 /* referred in audio callbacks */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 860 dev_priv->av_enc_map[pipe] = encoder; cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 861 mutex_unlock(&dev_priv->av_mutex); cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 862 ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 863 if (acomp && acomp->base.audio_ops && ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 864 acomp->base.audio_ops->pin_eld_notify) { f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 865 /* audio drivers expect pipe = -1 to indicate Non-MST cases */ 9f846643c788bb drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 866 if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 867 pipe = -1; ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 868 acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr, f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 869 (int) port, (int) pipe); 9c9191f3de5926 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2017-01-31 870 } 9c9191f3de5926 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2017-01-31 871 20be551e6d0a59 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-04-27 872 intel_lpe_audio_notify(dev_priv, pipe, port, connector->eld, b5f2be9ae5bf88 drivers/gpu/drm/i915/intel_audio.c Pierre-Louis Bossart 2017-01-31 873 crtc_state->port_clock, 9f846643c788bb drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 874 intel_crtc_has_dp_encoder(crtc_state)); 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 875 } 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 876 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 877 /** 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 878 * intel_audio_codec_disable - Disable the audio codec for HD audio 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 879 * @encoder: encoder on which to disable audio 764b9f2c4d252f drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-11-14 880 * @old_crtc_state: pointer to the old crtc state. 764b9f2c4d252f drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-11-14 881 * @old_conn_state: pointer to the old connector state. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 882 * 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 883 * The disable sequences must be performed before disabling the transcoder or 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 884 * port. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 885 */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 886 void intel_audio_codec_disable(struct intel_encoder *encoder, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 887 const struct intel_crtc_state *old_crtc_state, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 888 const struct drm_connector_state *old_conn_state) 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 889 { 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 890 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 891 struct i915_audio_component *acomp = dev_priv->audio_component; 2225f3c6f1d793 drivers/gpu/drm/i915/display/intel_audio.c Maarten Lankhorst 2019-10-31 892 struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 893 enum port port = encoder->port; f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 894 enum pipe pipe = crtc->pipe; 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 895 b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 896 if (dev_priv->audio_funcs) 9c1ce0dbf2c66b drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 897 dev_priv->audio_funcs.audio_codec_disable(encoder, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 898 old_crtc_state, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 899 old_conn_state); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 900 cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 901 mutex_lock(&dev_priv->av_mutex); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 902 encoder->audio_connector = NULL; f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 903 dev_priv->av_enc_map[pipe] = NULL; cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 904 mutex_unlock(&dev_priv->av_mutex); cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 905 ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 906 if (acomp && acomp->base.audio_ops && ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 907 acomp->base.audio_ops->pin_eld_notify) { f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 908 /* audio drivers expect pipe = -1 to indicate Non-MST cases */ 9f846643c788bb drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 909 if (!intel_crtc_has_type(old_crtc_state, INTEL_OUTPUT_DP_MST)) f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 910 pipe = -1; ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 911 acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr, f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 912 (int) port, (int) pipe); 9c9191f3de5926 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2017-01-31 913 } 46d196ec460b9c drivers/gpu/drm/i915/intel_audio.c Jerome Anand 2017-01-25 914 20be551e6d0a59 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-04-27 915 intel_lpe_audio_notify(dev_priv, pipe, port, NULL, 0, false); 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 916 } 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 917 b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 918 static const struct drm_i915_display_audio_funcs g4x_audio_funcs = { b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 @919 .audio_codec_enable = g4x_audio_codec_enable; b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 @920 .audio_codec_disable = g4x_audio_codec_disable; b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 @921 }; b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 922 :::::: The code at line 852 was first introduced by commit :::::: 9c1ce0dbf2c66b4038b09b712764ccdb272c03f6 drm/i915/display: split out display related audio funcs. :::::: TO: Dave Airlie <airlied(a)redhat.com> :::::: CC: Dave Airlie <airlied(a)redhat.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH 0/8] [CI] Enable GuC submission by default on DG1
by John.C.Harrison＠Intel.com 08 Sep '21

08 Sep '21

From: John Harrison <John.C.Harrison(a)Intel.com> Minimum set of patches to enable GuC submission on DG1 and enable it by default. A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...). Hence extra patches at the end to enable some features / add debugging info. Signed-off-by: Matthew Brost <matthew.brost(a)intel.com> Signed-off-by: John Harrison <John.C.Harrison(a)Intel.com> Daniele Ceraolo Spurio (1): drm/i915/guc: put all guc objects in lmem when available Matthew Brost (5): drm/i915/guc: Add DG1 GuC / HuC firmware defs drm/i915/guc: Enable GuC submission by default on DG1 Me: Allow relocs on DG1 for CI Me: Workaround LMEM blow up Me: Dump GuC log to dmesg on SLPC load failure Venkata Sandeep Dhanalakota (1): drm/i915: Do not define vma on stack Vinay Belgaumkar (1): drm/i915: Get PM ref before accessing HW register .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 26 +++++ drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 4 + drivers/gpu/drm/i915/gt/intel_rps.c | 8 +- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 9 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 13 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 3 + drivers/gpu/drm/i915/gt/uc/intel_huc.c | 14 ++- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 90 ++++++++++++++--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 2 + drivers/gpu/drm/i915/i915_gpu_error.c | 99 ++++++++++++++++++- drivers/gpu/drm/i915/i915_gpu_error.h | 3 + 13 files changed, 251 insertions(+), 24 deletions(-) -- 2.25.1

1 8

[drm:i915-vtable-cleanup 12/12] drivers/gpu/drm/i915/display/intel_audio.c:852:24: error: 'dev_priv->audio_funcs' is a pointer; did you mean to use '->'?
by kernel test robot 08 Sep '21

08 Sep '21

tree: git://people.freedesktop.org/~airlied/linux.git i915-vtable-cleanup head: b0d0061aeef594fc572295c0e3c02ba91596cbf6 commit: b0d0061aeef594fc572295c0e3c02ba91596cbf6 [12/12] drm/i915/display: constify the audio functions config: i386-buildonly-randconfig-r006-20210906 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): git remote add drm git://people.freedesktop.org/~airlied/linux.git git fetch --no-tags drm i915-vtable-cleanup git checkout b0d0061aeef594fc572295c0e3c02ba91596cbf6 # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/i915/display/intel_audio.c: In function 'intel_audio_codec_enable': >> drivers/gpu/drm/i915/display/intel_audio.c:852:24: error: 'dev_priv->audio_funcs' is a pointer; did you mean to use '->'? 852 | dev_priv->audio_funcs.audio_codec_enable(encoder, | ^ | -> drivers/gpu/drm/i915/display/intel_audio.c: In function 'intel_audio_codec_disable': drivers/gpu/drm/i915/display/intel_audio.c:897:24: error: 'dev_priv->audio_funcs' is a pointer; did you mean to use '->'? 897 | dev_priv->audio_funcs.audio_codec_disable(encoder, | ^ | -> drivers/gpu/drm/i915/display/intel_audio.c: At top level: >> drivers/gpu/drm/i915/display/intel_audio.c:919:46: error: expected '}' before ';' token 919 | .audio_codec_enable = g4x_audio_codec_enable; | ^ drivers/gpu/drm/i915/display/intel_audio.c:918:68: note: to match this '{' 918 | static const struct drm_i915_display_audio_funcs g4x_audio_funcs = { | ^ drivers/gpu/drm/i915/display/intel_audio.c:924:46: error: expected '}' before ';' token 924 | .audio_codec_enable = ilk_audio_codec_enable; | ^ drivers/gpu/drm/i915/display/intel_audio.c:923:68: note: to match this '{' 923 | static const struct drm_i915_display_audio_funcs ilk_audio_funcs = { | ^ drivers/gpu/drm/i915/display/intel_audio.c:929:46: error: expected '}' before ';' token 929 | .audio_codec_enable = hsw_audio_codec_enable; | ^ drivers/gpu/drm/i915/display/intel_audio.c:928:68: note: to match this '{' 928 | static const struct drm_i915_display_audio_funcs hsw_audio_funcs = { | ^ drivers/gpu/drm/i915/display/intel_audio.c:685:13: warning: 'ilk_audio_codec_disable' defined but not used [-Wunused-function] 685 | static void ilk_audio_codec_disable(struct intel_encoder *encoder, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_audio.c:486:13: warning: 'hsw_audio_codec_disable' defined but not used [-Wunused-function] 486 | static void hsw_audio_codec_disable(struct intel_encoder *encoder, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_audio.c:323:13: warning: 'g4x_audio_codec_disable' defined but not used [-Wunused-function] 323 | static void g4x_audio_codec_disable(struct intel_encoder *encoder, | ^~~~~~~~~~~~~~~~~~~~~~~ vim +852 drivers/gpu/drm/i915/display/intel_audio.c 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 814 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 815 /** 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 816 * intel_audio_codec_enable - Enable the audio codec for HD audio 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 817 * @encoder: encoder on which to enable audio bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 818 * @crtc_state: pointer to the current crtc state. bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 819 * @conn_state: pointer to the current connector state. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 820 * 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 821 * The enable sequences may only be performed after enabling the transcoder and 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 822 * port, and after completed link training. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 823 */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 824 void intel_audio_codec_enable(struct intel_encoder *encoder, bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 825 const struct intel_crtc_state *crtc_state, bbf35e9defb9a6 drivers/gpu/drm/i915/intel_audio.c Maarten Lankhorst 2016-11-08 826 const struct drm_connector_state *conn_state) 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 827 { 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 828 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 829 struct i915_audio_component *acomp = dev_priv->audio_component; 2225f3c6f1d793 drivers/gpu/drm/i915/display/intel_audio.c Maarten Lankhorst 2019-10-31 830 struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 831 struct drm_connector *connector = conn_state->connector; 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 832 const struct drm_display_mode *adjusted_mode = 1326a92c346641 drivers/gpu/drm/i915/display/intel_audio.c Maarten Lankhorst 2019-10-31 833 &crtc_state->hw.adjusted_mode; 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 834 enum port port = encoder->port; 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 835 enum pipe pipe = crtc->pipe; 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 836 abf4b8ed42e9dc drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2019-04-30 837 /* FIXME precompute the ELD in .compute_config() */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 838 if (!connector->eld[0]) 6385514932d5fc drivers/gpu/drm/i915/display/intel_audio.c Wambui Karuga 2020-01-21 839 drm_dbg_kms(&dev_priv->drm, 6385514932d5fc drivers/gpu/drm/i915/display/intel_audio.c Wambui Karuga 2020-01-21 840 "Bogus ELD on [CONNECTOR:%d:%s]\n", abf4b8ed42e9dc drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2019-04-30 841 connector->base.id, connector->name); 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 842 6385514932d5fc drivers/gpu/drm/i915/display/intel_audio.c Wambui Karuga 2020-01-21 843 drm_dbg(&dev_priv->drm, "ELD on [CONNECTOR:%d:%s], [ENCODER:%d:%s]\n", 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 844 connector->base.id, 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 845 connector->name, 79003e61b1fbfd drivers/gpu/drm/i915/display/intel_audio.c Ville Syrjälä 2019-12-04 846 encoder->base.base.id, 79003e61b1fbfd drivers/gpu/drm/i915/display/intel_audio.c Ville Syrjälä 2019-12-04 847 encoder->base.name); 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 848 124abe076fd8b3 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2015-09-08 849 connector->eld[6] = drm_av_sync_delay(connector, adjusted_mode) / 2; 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 850 b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 851 if (dev_priv->audio_funcs) 9c1ce0dbf2c66b drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 @852 dev_priv->audio_funcs.audio_codec_enable(encoder, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 853 crtc_state, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 854 conn_state); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 855 cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 856 mutex_lock(&dev_priv->av_mutex); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 857 encoder->audio_connector = connector; f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 858 9dfbffcf4ac070 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2016-02-24 859 /* referred in audio callbacks */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 860 dev_priv->av_enc_map[pipe] = encoder; cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 861 mutex_unlock(&dev_priv->av_mutex); cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 862 ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 863 if (acomp && acomp->base.audio_ops && ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 864 acomp->base.audio_ops->pin_eld_notify) { f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 865 /* audio drivers expect pipe = -1 to indicate Non-MST cases */ 9f846643c788bb drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 866 if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 867 pipe = -1; ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 868 acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr, f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 869 (int) port, (int) pipe); 9c9191f3de5926 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2017-01-31 870 } 9c9191f3de5926 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2017-01-31 871 20be551e6d0a59 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-04-27 872 intel_lpe_audio_notify(dev_priv, pipe, port, connector->eld, b5f2be9ae5bf88 drivers/gpu/drm/i915/intel_audio.c Pierre-Louis Bossart 2017-01-31 873 crtc_state->port_clock, 9f846643c788bb drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 874 intel_crtc_has_dp_encoder(crtc_state)); 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 875 } 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 876 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 877 /** 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 878 * intel_audio_codec_disable - Disable the audio codec for HD audio 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 879 * @encoder: encoder on which to disable audio 764b9f2c4d252f drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-11-14 880 * @old_crtc_state: pointer to the old crtc state. 764b9f2c4d252f drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-11-14 881 * @old_conn_state: pointer to the old connector state. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 882 * 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 883 * The disable sequences must be performed before disabling the transcoder or 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 884 * port. 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 885 */ 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 886 void intel_audio_codec_disable(struct intel_encoder *encoder, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 887 const struct intel_crtc_state *old_crtc_state, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 888 const struct drm_connector_state *old_conn_state) 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 889 { 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 890 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 891 struct i915_audio_component *acomp = dev_priv->audio_component; 2225f3c6f1d793 drivers/gpu/drm/i915/display/intel_audio.c Maarten Lankhorst 2019-10-31 892 struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 893 enum port port = encoder->port; f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 894 enum pipe pipe = crtc->pipe; 69bfe1a9b4dffc drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 895 b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 896 if (dev_priv->audio_funcs) 9c1ce0dbf2c66b drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 897 dev_priv->audio_funcs.audio_codec_disable(encoder, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 898 old_crtc_state, 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 899 old_conn_state); 51e1d83cab9988 drivers/gpu/drm/i915/intel_audio.c David Henningsson 2015-08-19 900 cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 901 mutex_lock(&dev_priv->av_mutex); 8ec47de21bfab9 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 902 encoder->audio_connector = NULL; f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 903 dev_priv->av_enc_map[pipe] = NULL; cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 904 mutex_unlock(&dev_priv->av_mutex); cae666ceb8c3f1 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2015-11-12 905 ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 906 if (acomp && acomp->base.audio_ops && ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 907 acomp->base.audio_ops->pin_eld_notify) { f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 908 /* audio drivers expect pipe = -1 to indicate Non-MST cases */ 9f846643c788bb drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-10-30 909 if (!intel_crtc_has_type(old_crtc_state, INTEL_OUTPUT_DP_MST)) f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 910 pipe = -1; ae891abe7c2ccf drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2018-07-11 911 acomp->base.audio_ops->pin_eld_notify(acomp->base.audio_ops->audio_ptr, f931894194b939 drivers/gpu/drm/i915/intel_audio.c Pandiyan, Dhinakaran 2016-09-21 912 (int) port, (int) pipe); 9c9191f3de5926 drivers/gpu/drm/i915/intel_audio.c Takashi Iwai 2017-01-31 913 } 46d196ec460b9c drivers/gpu/drm/i915/intel_audio.c Jerome Anand 2017-01-25 914 20be551e6d0a59 drivers/gpu/drm/i915/intel_audio.c Ville Syrjälä 2017-04-27 915 intel_lpe_audio_notify(dev_priv, pipe, port, NULL, 0, false); 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 916 } 7c10a2b5876e01 drivers/gpu/drm/i915/intel_audio.c Jani Nikula 2014-10-27 917 b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 918 static const struct drm_i915_display_audio_funcs g4x_audio_funcs = { b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 @919 .audio_codec_enable = g4x_audio_codec_enable; b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 920 .audio_codec_disable = g4x_audio_codec_disable; b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 921 }; b0d0061aeef594 drivers/gpu/drm/i915/display/intel_audio.c Dave Airlie 2021-09-08 922 :::::: The code at line 852 was first introduced by commit :::::: 9c1ce0dbf2c66b4038b09b712764ccdb272c03f6 drm/i915/display: split out display related audio funcs. :::::: TO: Dave Airlie <airlied(a)redhat.com> :::::: CC: Dave Airlie <airlied(a)redhat.com> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH] drm/msm/dsi: Use division result from div_u64_rem in 7nm and 14nm PLL
by Marijn Suijten 07 Sep '21

07 Sep '21

div_u64_rem provides the result of the divison and additonally the remainder; don't use this function to solely calculate the remainder while calculating the division again with div_u64. A similar improvement was applied earlier to the 10nm pll in 5c191fef4ce2 ("drm/msm/dsi_pll_10nm: Fix dividing the same numbers twice"). Signed-off-by: Marijn Suijten <marijn.suijten(a)somainline.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 4 +--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c index 3c1e2106d962..8905f365c932 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -213,9 +213,7 @@ static void pll_14nm_dec_frac_calc(struct dsi_pll_14nm *pll, struct dsi_pll_conf DBG("vco_clk_rate=%lld ref_clk_rate=%lld", vco_clk_rate, fref); dec_start_multiple = div_u64(vco_clk_rate * multiplier, fref); - div_u64_rem(dec_start_multiple, multiplier, &div_frac_start); - - dec_start = div_u64(dec_start_multiple, multiplier); + dec_start = div_u64_rem(dec_start_multiple, multiplier, &div_frac_start); pconf->dec_start = (u32)dec_start; pconf->div_frac_start = div_frac_start; diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c index c77c30628cca..1a5abbd9fb76 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -114,9 +114,7 @@ static void dsi_pll_calc_dec_frac(struct dsi_pll_7nm *pll, struct dsi_pll_config multiplier = 1 << FRAC_BITS; dec_multiple = div_u64(pll_freq * multiplier, divider); - div_u64_rem(dec_multiple, multiplier, &frac); - - dec = div_u64(dec_multiple, multiplier); + dec = div_u64_rem(dec_multiple, multiplier, &frac); if (!(pll->phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V4_1)) config->pll_clock_inverters = 0x28; -- 2.33.0

2 1

[PATCH] drm/mcde: Make use of the helper function devm_platform_ioremap_resource()
by Cai Huoqing 07 Sep '21

07 Sep '21

Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing(a)baidu.com> --- drivers/gpu/drm/mcde/mcde_drv.c | 4 +--- drivers/gpu/drm/mcde/mcde_dsi.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index e60566a5739c..5b5afc6aaf8e 100644 --- a/drivers/gpu/drm/mcde/mcde_drv.c +++ b/drivers/gpu/drm/mcde/mcde_drv.c @@ -276,7 +276,6 @@ static int mcde_probe(struct platform_device *pdev) struct drm_device *drm; struct mcde *mcde; struct component_match *match = NULL; - struct resource *res; u32 pid; int irq; int ret; @@ -344,8 +343,7 @@ static int mcde_probe(struct platform_device *pdev) goto clk_disable; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - mcde->regs = devm_ioremap_resource(dev, res); + mcde->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mcde->regs)) { dev_err(dev, "no MCDE regs\n"); ret = -EINVAL; diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index 180ebbccbeda..5651734ce977 100644 --- a/drivers/gpu/drm/mcde/mcde_dsi.c +++ b/drivers/gpu/drm/mcde/mcde_dsi.c @@ -1169,7 +1169,6 @@ static int mcde_dsi_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct mcde_dsi *d; struct mipi_dsi_host *host; - struct resource *res; u32 dsi_id; int ret; @@ -1187,8 +1186,7 @@ static int mcde_dsi_probe(struct platform_device *pdev) return PTR_ERR(d->prcmu); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - d->regs = devm_ioremap_resource(dev, res); + d->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(d->regs)) return PTR_ERR(d->regs); -- 2.25.1

2 1

[PATCH v3] drm/dp_mst: Fix return code on sideband message failure
by Kuogee Hsieh 07 Sep '21

07 Sep '21

From: Rajkumar Subbiah <rsubbia(a)codeaurora.org> Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests") added some debug code for sideband message tracing. But it seems to have unintentionally changed the behavior on sideband message failure. It catches and returns failure only if DRM_UT_DP is enabled. Otherwise it ignores the error code and returns success. So on an MST unplug, the caller is unaware that the clear payload message failed and ends up waiting for 4 seconds for the response. Fixes the issue by returning the proper error code. Changes in V2: -- Revise commit text as review comment -- add Fixes text Changes in V3: -- remove "unlikely" optimization Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests") Signed-off-by: Rajkumar Subbiah <rsubbia(a)codeaurora.org> Signed-off-by: Kuogee Hsieh <khsieh(a)codeaurora.org> Reviewed-by: Stephen Boyd <swboyd(a)chromium.org> --- drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index 1590144..df91110 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr, idx += tosend + 1; ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx); - if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) { - struct drm_printer p = drm_debug_printer(DBG_PREFIX); + if (ret) { + if (drm_debug_enabled(DRM_UT_DP)) { + struct drm_printer p = drm_debug_printer(DBG_PREFIX); - drm_printf(&p, "sideband msg failed to send\n"); - drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); + drm_printf(&p, "sideband msg failed to send\n"); + drm_dp_mst_dump_sideband_msg_tx(&p, txmsg); + } return ret; } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

5 13

[PATCH v10 0/4] drm: update locking for modesetting
by Desmond Cheong Zhi Xi 07 Sep '21

07 Sep '21

Sorry for the noise, rebasing on top of drm-misc-next. Please ignore the v9 series. Hi, I updated the patch set with some suggestions by Daniel Vetter, and dropped the patches after patch 4 so that we can stick the landing for avoiding races with modesetting rights before dealing with the tricky spinlock. Overall, this series fixes races with modesetting rights, and converts drm_device.master_mutex into master_rwsem. - Patch 1: Fix a potential null ptr dereference in drm_master_release - Patch 2: Convert master_mutex into rwsem (avoids creating a new lock) - Patch 3: Update global mutex locking in the ioctl handler (avoids deadlock when grabbing read lock on master_rwsem in drm_ioctl_kernel) - Patch 4: Plug races with drm modesetting rights v9 -> v10: - Rebase on top of drm-misc-next, caught by Intel-gfx CI v8 -> v9 (suggested by Daniel Vetter): - Drop patches 5-7 to handle it in another series - Add the appropriate Fixes: tag for the null ptr dereference fix (patch 1) - Create a locked_ioctl bool to clarify locking/unlocking patterns in the ioctl handler (patch 3) - Clarify the kernel doc for master_rwsem (patch 4) v7 -> v8: - Avoid calling drm_lease_held in drm_mode_setcrtc and drm_wait_vblank_ioctl, caught by Intel-gfx CI v6 -> v7: - Export __drm_mode_object_find for loadable modules, caught by the Intel-gfx CI v5 -> v6: - Fix recursive locking on master_rwsem, caught by the Intel-gfx CI v4 -> v5: - Avoid calling drm_file_get_master while holding on to the modeset mutex, caught by the Intel-gfx CI v3 -> v4 (suggested by Daniel Vetter): - Drop a patch that added an unnecessary master_lookup_lock in drm_master_release - Drop a patch that addressed a non-existent race in drm_is_current_master_locked - Remove fixes for non-existent null ptr dereferences - Protect drm_master.magic_map,unique{_len} with master_rwsem instead of master_lookup_lock - Drop the patch that moved master_lookup_lock into struct drm_device - Drop a patch to export task_work_add - Revert the check for the global mutex in the ioctl handler to use drm_core_check_feature instead of drm_dev_needs_global_mutex - Push down master_rwsem locking for selected ioctls to avoid lock hierarchy inversions, and to allow us to hold write locks on master_rwsem instead of flushing readers - Remove master_lookup_lock by replacing it with master_rwsem v2 -> v3: - Unexport drm_master_flush, as suggested by Daniel Vetter. - Merge master_mutex and master_rwsem, as suggested by Daniel Vetter. - Export task_work_add, reported by kernel test robot. - Make master_flush static, reported by kernel test robot. - Move master_lookup_lock into struct drm_device. - Add a missing lock on master_lookup_lock in drm_master_release. - Fix a potential race in drm_is_current_master_locked. - Fix potential null ptr dereferences in drm_{auth, ioctl}. - Protect magic_map,unique{_len} with master_lookup_lock. - Convert master_mutex into a rwsem. - Update global mutex locking in the ioctl handler. v1 -> v2 (suggested by Daniel Vetter): - Address an additional race when drm_open runs. - Switch from SRCU to rwsem to synchronise readers and writers. - Implement drm_master_flush with task_work so that flushes can be queued to run before returning to userspace without creating a new DRM_MASTER_FLUSH ioctl flag. Best wishes, Desmond Desmond Cheong Zhi Xi (4): drm: fix null ptr dereference in drm_master_release drm: convert drm_device.master_mutex into a rwsem drm: lock drm_global_mutex earlier in the ioctl handler drm: avoid races with modesetting rights drivers/gpu/drm/drm_auth.c | 39 ++++++++++++++++------------ drivers/gpu/drm/drm_debugfs.c | 4 +-- drivers/gpu/drm/drm_drv.c | 3 +-- drivers/gpu/drm/drm_file.c | 6 ++--- drivers/gpu/drm/drm_ioctl.c | 49 ++++++++++++++++++++++------------- drivers/gpu/drm/drm_lease.c | 35 +++++++++++++++++-------- include/drm/drm_auth.h | 6 ++--- include/drm/drm_device.h | 16 +++++++++--- include/drm/drm_file.h | 12 ++++----- 9 files changed, 104 insertions(+), 66 deletions(-) -- 2.25.1

1 5

[PATCH 0/2] drm/panel: Add support for LG.Philips SW43101 DSI video mode panel
by Yassine Oudjana 07 Sep '21

07 Sep '21

This adds a driver for the LG.Philips SW43101 FHD (1080x1920) 58Hz OLED DSI video mode panel, found on the Xiaomi Mi Note 2. Yassine Oudjana (2): drm/panel: Add driver for LG.Philips SW43101 DSI video mode panel dt-bindings: display: Add binding for LG.Philips SW43101 .../display/panel/lgphilips,sw43101.yaml | 52 +++ drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-lgphilips-sw43101.c | 331 ++++++++++++++++++ 4 files changed, 394 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/lgphilips,sw43101.yaml create mode 100644 drivers/gpu/drm/panel/panel-lgphilips-sw43101.c -- 2.33.0

2 3

← Newer
1
...
68
69
70
71
72
73
74
...
82
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel September 2021