dri-devel January 2022

dri-devel@lists.freedesktop.org

373 participants
842 discussions

[v4 0/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support
by Rajeev Nandan 30 Jan '22

30 Jan '22

This series is to add DSI PHY tuning support in Qualcomm Snapdragon SoCs with 10nm DSI PHY e.g. SC7180 In most cases the default values of DSI PHY tuning registers should be sufficient as they are fully optimized. However, in some cases (for example, where extreme board parasitics cause the eye shape to degrade), the override bits can be used to improve the signal quality. Different DSI PHY versions have different configurations to adjust the drive strength, drive level, de-emphasis, etc. The current series has only those configuration options supported by 10nm PHY, e.g. drive strength and drive level. The number of registers to configure the drive strength are different for 7nm PHY. The design can be extended to other DSI PHY versions if required, as each PHY version can have its callback to get the input from DT and prepare register values. Changes in v2: - Addressed dt-bindings comments (Stephen Boyd, Dmitry Baryshkov) - Split into generic code and 10nm-specific part (Dmitry Baryshkov) - Fix the backward compatibility (Dmitry Baryshkov) Changes in v3: - Addressed dt-bindings comments (Rob Herring, Dmitry Baryshkov) - Address comments for phy tuning data structure (Dmitry Baryshkov) - s/ops.tuning_cfg_init/ops.parse_dt_properties (Dmitry Baryshkov) Changes in v4: - Fixed dt_binding_check error (Rob Herring's bot) - Return error in case of out of range values (Dmitry Baryshkov) - Return error if dt property is present but parsing is failing Rajeev Nandan (3): dt-bindings: msm/dsi: Add 10nm dsi phy tuning properties drm/msm/dsi: Add dsi phy tuning configuration support drm/msm/dsi: Add 10nm dsi phy tuning configuration support .../bindings/display/msm/dsi-phy-10nm.yaml | 36 +++++++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 6 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 4 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 118 +++++++++++++++++++-- 4 files changed, 158 insertions(+), 6 deletions(-) -- 2.7.4

1 3

[Bug 214197] New: [Asus G713QY] RX6800M not usable after exiting Vulkan application
by bugzilla-daemon＠bugzilla.kernel.org 30 Jan '22

30 Jan '22

https://bugzilla.kernel.org/show_bug.cgi?id=214197 Bug ID: 214197 Summary: [Asus G713QY] RX6800M not usable after exiting Vulkan application Product: Drivers Version: 2.5 Kernel Version: 5.13.13 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: velemas(a)gmail.com Regression: No Asus ROG Strix G17 Advantage Edition (G713QY) has hybrid-graphics with dGPU RX6800M. After exiting any Vulkan application, it becomes unusable. Vulkaninfo sees dGPU before Vulkan app and does not see RX6800M after. After Vulkan app close, dmesg reports: [ 154.385749] amdgpu 0000:03:00.0: amdgpu: RAS: optional ras ta ucode is not available [ 154.401405] amdgpu 0000:03:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available [ 154.401409] amdgpu 0000:03:00.0: amdgpu: SMU is resuming... [ 159.038150] amdgpu 0000:03:00.0: amdgpu: message: RunDcBtc (54) param: 0x00000000 is timeout (no response) [ 159.038154] amdgpu 0000:03:00.0: amdgpu: Failed to setup smc hw! [ 159.038156] [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <smu> failed -62 [ 159.038220] amdgpu 0000:03:00.0: amdgpu: amdgpu_device_ip_resume failed (-62). Using amdgpu.runpm=0 parameter fixes the issue. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

2 9

[PATCH v2 0/1] drm/lsdc: add drm driver for loongson display controller
by Sui Jingfeng 30 Jan '22

30 Jan '22

v2: fixup warnings reported by kernel test robot There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge, and the DC in those chip is a PCI device. This display controller have two display pipes but with only one hardware cursor. This display controller is uncommon outside of china, it don't have rich document either. This patch try to provided a minimal support for this display controller which is for graphic environment bring up. Hope the code can speak for itself. For ls7a1000, there are 4 gpios who register is located at dc register space which is used to emulation i2c. LS2K1000 and LS2K0500 SoC don't have those hardware, they use general purpose gpio or hardware i2c to serve this purpose. LS2K1000 is a double core 1.0Ghz mips64r2 compatible SoC[1]. LS7A1000 is a bridge chip made by Loongson corporation which act as north and/or south bridge of loongson's desktop and server level processor. It is equivalent to RS780E or something like that. More details can be read from its user manual[2]. This bridge chip is typically use with LS3A3000, LS3A4000 and LS3A5000 cpu. LS3A3000 is 4 core 1.45gHz mips64r2 compatible cpu. LS3A4000 is 4 core 1.8gHz mips64r5 compatible cpu. LS3A5000 is 4 core 2.5gHz loongarch cpu[3]. [1] https://wiki.debian.org/InstallingDebianOn/Lemote/Loongson2K1000 [2] https://loongson.github.io/LoongArch-Documentation/Loongson-7A1000-usermanu… [3] https://loongson.github.io/LoongArch-Documentation/Loongson-3A5000-usermanu… Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: suijingfeng <suijingfeng(a)loongson.cn> Signed-off-by: Sui Jingfeng <15330273260(a)189.cn> suijingfeng (1): drm/lsdc: add drm driver for loongson display controller drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/lsdc/Kconfig | 38 ++ drivers/gpu/drm/lsdc/Makefile | 15 + drivers/gpu/drm/lsdc/lsdc_connector.c | 439 ++++++++++++++ drivers/gpu/drm/lsdc/lsdc_connector.h | 60 ++ drivers/gpu/drm/lsdc/lsdc_crtc.c | 438 ++++++++++++++ drivers/gpu/drm/lsdc/lsdc_drv.c | 824 ++++++++++++++++++++++++++ drivers/gpu/drm/lsdc/lsdc_drv.h | 214 +++++++ drivers/gpu/drm/lsdc/lsdc_encoder.c | 79 +++ drivers/gpu/drm/lsdc/lsdc_i2c.c | 220 +++++++ drivers/gpu/drm/lsdc/lsdc_i2c.h | 61 ++ drivers/gpu/drm/lsdc/lsdc_irq.c | 77 +++ drivers/gpu/drm/lsdc/lsdc_irq.h | 37 ++ drivers/gpu/drm/lsdc/lsdc_plane.c | 694 ++++++++++++++++++++++ drivers/gpu/drm/lsdc/lsdc_pll.c | 605 +++++++++++++++++++ drivers/gpu/drm/lsdc/lsdc_pll.h | 109 ++++ drivers/gpu/drm/lsdc/lsdc_regs.h | 242 ++++++++ 18 files changed, 4155 insertions(+) create mode 100644 drivers/gpu/drm/lsdc/Kconfig create mode 100644 drivers/gpu/drm/lsdc/Makefile create mode 100644 drivers/gpu/drm/lsdc/lsdc_connector.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_connector.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_crtc.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_drv.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_drv.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_encoder.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_i2c.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_i2c.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_irq.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_irq.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_plane.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_pll.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_pll.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_regs.h -- 2.20.1

2 2

[PATCH] drm/lsdc: add drm driver support for loongson display controller
by Sui Jingfeng 30 Jan '22

30 Jan '22

There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge, and the DC in those chip is a PCI device. This display controller have two display pipes but with only one hardware cursor. This display controller is uncommon outside of china, it don't have rich document either. This patch try to provide a minimal support for it, which is mainly for graphic environment bring up. Hope the code can speak for itself. For LS7A1000, there are 4 gpios whoes register is located at dc register space which is used to emulation i2c. LS2K1000 and LS2K0500 SoC don't have those hardware, they use general purpose gpio or hardware i2c to serve this purpose. LS2K1000 is a double core 1.0Ghz mips64r2 compatible SoC[3]. LS7A1000 is a bridge chip made by Loongson corporation which act as north and/or south bridge of loongson's desktop and server level processor. It is equivalent to RS780E or something like that. More details can be read from its user manual[1]. This bridge chip is typically use with LS3A3000, LS3A4000 and LS3A5000 cpu. LS3A3000 is 4 core 1.45gHz mips64r2 compatible cpu. LS3A4000 is 4 core 1.8gHz mips64r5 compatible cpu. LS3A5000 is 4 core 2.5gHz loongarch cpu[2]. [1] https://loongson.github.io/LoongArch-Documentation/Loongson-7A1000-usermanu… [2] https://loongson.github.io/LoongArch-Documentation/Loongson-3A5000-usermanu… [3] https://wiki.debian.org/InstallingDebianOn/Lemote/Loongson2K1000 Signed-off-by: suijingfeng <suijingfeng(a)loongson.cn> Signed-off-by: Sui Jingfeng <15330273260(a)189.cn> --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/lsdc/Kconfig | 32 + drivers/gpu/drm/lsdc/Makefile | 15 + drivers/gpu/drm/lsdc/lsdc_connector.c | 441 ++++++++++++++ drivers/gpu/drm/lsdc/lsdc_connector.h | 60 ++ drivers/gpu/drm/lsdc/lsdc_crtc.c | 438 ++++++++++++++ drivers/gpu/drm/lsdc/lsdc_drv.c | 823 ++++++++++++++++++++++++++ drivers/gpu/drm/lsdc/lsdc_drv.h | 212 +++++++ drivers/gpu/drm/lsdc/lsdc_encoder.c | 79 +++ drivers/gpu/drm/lsdc/lsdc_i2c.c | 220 +++++++ drivers/gpu/drm/lsdc/lsdc_i2c.h | 61 ++ drivers/gpu/drm/lsdc/lsdc_irq.c | 49 ++ drivers/gpu/drm/lsdc/lsdc_irq.h | 37 ++ drivers/gpu/drm/lsdc/lsdc_plane.c | 711 ++++++++++++++++++++++ drivers/gpu/drm/lsdc/lsdc_pll.c | 596 +++++++++++++++++++ drivers/gpu/drm/lsdc/lsdc_pll.h | 109 ++++ drivers/gpu/drm/lsdc/lsdc_regs.h | 242 ++++++++ 18 files changed, 4128 insertions(+) create mode 100644 drivers/gpu/drm/lsdc/Kconfig create mode 100644 drivers/gpu/drm/lsdc/Makefile create mode 100644 drivers/gpu/drm/lsdc/lsdc_connector.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_connector.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_crtc.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_drv.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_drv.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_encoder.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_i2c.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_i2c.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_irq.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_irq.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_plane.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_pll.c create mode 100644 drivers/gpu/drm/lsdc/lsdc_pll.h create mode 100644 drivers/gpu/drm/lsdc/lsdc_regs.h diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index dfdd3ec5f793..18de1485e2ed 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -405,6 +405,8 @@ source "drivers/gpu/drm/gud/Kconfig" source "drivers/gpu/drm/sprd/Kconfig" +source "drivers/gpu/drm/lsdc/Kconfig" + config DRM_HYPERV tristate "DRM Support for Hyper-V synthetic video device" depends on DRM && PCI && MMU && HYPERV diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 8675c2af7ae1..2c5a76ced323 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -133,3 +133,4 @@ obj-y += xlnx/ obj-y += gud/ obj-$(CONFIG_DRM_HYPERV) += hyperv/ obj-$(CONFIG_DRM_SPRD) += sprd/ +obj-$(CONFIG_DRM_LSDC) += lsdc/ diff --git a/drivers/gpu/drm/lsdc/Kconfig b/drivers/gpu/drm/lsdc/Kconfig new file mode 100644 index 000000000000..744009dfcdde --- /dev/null +++ b/drivers/gpu/drm/lsdc/Kconfig @@ -0,0 +1,32 @@ +config DRM_LSDC + tristate "DRM Support for loongson's display controller" + depends on DRM && PCI + depends on MACH_LOONGSON64 || LOONGARCH || MIPS || COMPILE_TEST + select OF + select CMA if HAVE_DMA_CONTIGUOUS + select DMA_CMA if HAVE_DMA_CONTIGUOUS + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_GEM_CMA_HELPER + select VIDEOMODE_HELPERS + select BACKLIGHT_PWM if CPU_LOONGSON2K + select I2C_GPIO if CPU_LOONGSON2K + select I2C_LS2X if CPU_LOONGSON2K + default m + help + This is a KMS driver for the display controller in the LS7A1000 + bridge chip and LS2K1000 SoC. The display controller have two + display pipes and it is a pci device. + When using it on LS2K1000/LS2K0500 SoC, its framebuffer is + located at system memory. + If "M" is selected, the module will be called lsdc. + + If in doubt, say "Y". + +config DRM_LSDC_VRAM_DRIVER + bool "vram helpper based device driver support" + depends on DRM_LSDC + select DRM_VRAM_HELPER + default y + help + If in doubt, say "n". diff --git a/drivers/gpu/drm/lsdc/Makefile b/drivers/gpu/drm/lsdc/Makefile new file mode 100644 index 000000000000..342990654478 --- /dev/null +++ b/drivers/gpu/drm/lsdc/Makefile @@ -0,0 +1,15 @@ +# +# Makefile for the lsdc drm device driver. +# + +lsdc-y := \ + lsdc_drv.o \ + lsdc_crtc.o \ + lsdc_irq.o \ + lsdc_plane.o \ + lsdc_pll.o \ + lsdc_i2c.o \ + lsdc_encoder.o \ + lsdc_connector.o + +obj-$(CONFIG_DRM_LSDC) += lsdc.o diff --git a/drivers/gpu/drm/lsdc/lsdc_connector.c b/drivers/gpu/drm/lsdc/lsdc_connector.c new file mode 100644 index 000000000000..cd20bf6a4281 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_connector.c @@ -0,0 +1,441 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#include <drm/drm_print.h> +#include <drm/drm_edid.h> +#include <drm/drm_probe_helper.h> +#include <drm/drm_atomic_helper.h> +#include <drm/drm_crtc_helper.h> +#include <drm/drm_connector.h> + +#include <video/videomode.h> +#include <video/of_display_timing.h> + +#include "lsdc_drv.h" +#include "lsdc_i2c.h" +#include "lsdc_connector.h" + + +static int lsdc_get_modes_from_edid(struct drm_connector *connector) +{ + struct drm_device *ddev = connector->dev; + struct lsdc_connector *lconn = to_lsdc_connector(connector); + struct edid *edid_p = (struct edid *)lconn->edid_data; + int num = drm_add_edid_modes(connector, edid_p); + + if (num) + drm_connector_update_edid_property(connector, edid_p); + + drm_dbg_kms(ddev, "%d modes added\n", num); + + return num; +} + + +static int lsdc_get_modes_from_timings(struct drm_connector *connector) +{ + struct drm_device *ddev = connector->dev; + struct lsdc_connector *lconn = to_lsdc_connector(connector); + struct display_timings *disp_tim = lconn->disp_tim; + unsigned int i; + unsigned int num = 0; + + for (i = 0; i < disp_tim->num_timings; i++) { + const struct display_timing *dt = disp_tim->timings[i]; + struct drm_display_mode *mode; + struct videomode vm; + + videomode_from_timing(dt, &vm); + mode = drm_mode_create(ddev); + if (!mode) { + drm_err(ddev, "failed to add mode %ux%u\n", + dt->hactive.typ, dt->vactive.typ); + continue; + } + + drm_display_mode_from_videomode(&vm, mode); + + mode->type |= DRM_MODE_TYPE_DRIVER; + + if (i == disp_tim->native_mode) + mode->type |= DRM_MODE_TYPE_PREFERRED; + + drm_mode_probed_add(connector, mode); + num++; + } + + drm_dbg_kms(ddev, "%d modes added\n", num); + + return num; +} + + +static int lsdc_get_modes_from_ddc(struct drm_connector *connector, + struct i2c_adapter *ddc) +{ + struct drm_device *ddev = connector->dev; + struct edid *edid = NULL; + unsigned int num = 0; + + if (ddc) { + edid = drm_get_edid(connector, ddc); + if (edid) { + drm_connector_update_edid_property(connector, edid); + num = drm_add_edid_modes(connector, edid); + kfree(edid); + } else + goto fallback; + + return num; + } else + drm_warn(ddev, "Grab EDID failed because of no DDC\n"); + +fallback: + + /* + * In case we cannot retrieve the EDIDs (broken or missing i2c + * bus), fallback on the XGA standards + */ + num = drm_add_modes_noedid(connector, 1920, 1200); + + /* And prefer a mode pretty much anyone can handle */ + drm_set_preferred_mode(connector, 1024, 768); + + return num; +} + + +static int lsdc_get_modes(struct drm_connector *connector) +{ + struct lsdc_connector *lconn = to_lsdc_connector(connector); + + if (lconn->has_edid) + return lsdc_get_modes_from_edid(connector); + + if (lconn->has_disp_tim) + return lsdc_get_modes_from_timings(connector); + + if (connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL) { + struct drm_device *ddev = connector->dev; + int count; + + count = drm_add_modes_noedid(connector, + ddev->mode_config.max_width, + ddev->mode_config.max_height); + + drm_set_preferred_mode(connector, 1024, 768); + + return count; + } + + return lsdc_get_modes_from_ddc(connector, lconn->ddc); +} + + +static enum drm_connector_status +lsdc_connector_detect(struct drm_connector *connector, bool force) +{ + struct lsdc_connector *lconn = to_lsdc_connector(connector); + + if (lconn->has_edid == true) + return connector_status_connected; + + if (lconn->has_disp_tim == true) + return connector_status_connected; + + if (lconn->ddc && drm_probe_ddc(lconn->ddc)) + return connector_status_connected; + + if ((connector->connector_type == DRM_MODE_CONNECTOR_DVIA) || + (connector->connector_type == DRM_MODE_CONNECTOR_DVID) || + (connector->connector_type == DRM_MODE_CONNECTOR_DVII)) + return connector_status_disconnected; + + if ((connector->connector_type == DRM_MODE_CONNECTOR_HDMIA) || + (connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)) + return connector_status_disconnected; + + if (connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL) + return connector_status_connected; + + return connector_status_unknown; +} + + +/* + * @connector: point to the drm_connector structure + * + * Clean up connector resources + */ +static void lsdc_connector_destroy(struct drm_connector *connector) +{ + struct drm_device *ddev = connector->dev; + struct lsdc_connector *lconn = to_lsdc_connector(connector); + + if (lconn) { + if (lconn->ddc) + lsdc_destroy_i2c(connector->dev, lconn->ddc); + + drm_info(ddev, "destroying connector%u\n", lconn->index); + + devm_kfree(ddev->dev, lconn); + } + + drm_connector_cleanup(connector); +} + + +static const struct drm_connector_helper_funcs lsdc_connector_helpers = { + .get_modes = lsdc_get_modes, +}; + +/** + * These provide the minimum set of functions required to handle a connector + * + * Control connectors on a given device. + * + * Each CRTC may have one or more connectors attached to it. + * The functions below allow the core DRM code to control + * connectors, enumerate available modes, etc. + */ +static const struct drm_connector_funcs lsdc_connector_funcs = { + .dpms = drm_helper_connector_dpms, + .detect = lsdc_connector_detect, + .fill_modes = drm_helper_probe_single_connector_modes, + .destroy = lsdc_connector_destroy, + .reset = drm_atomic_helper_connector_reset, + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, +}; + + +/* Get the simple EDID data from the device tree + * the length must be EDID_LENGTH, since it is simple. + * + * @np: device node contain edid data + * @edid_data: where the edid data to store to + */ +static bool lsdc_get_edid_from_dtb(struct device_node *np, + unsigned char *edid_data) +{ + int length; + const void *prop; + + if (np == NULL) + return false; + + prop = of_get_property(np, "edid", &length); + if (prop && (length == EDID_LENGTH)) { + memcpy(edid_data, prop, EDID_LENGTH); + return true; + } + + return false; +} + +/* Get display timings from the device tree + * + * @np: device node contain the display timings + * @pptim: where the pointer of struct display_timings to store to + */ +static void lsdc_get_display_timings_from_dtb(struct device_node *np, + struct display_timings **pptim) +{ + struct display_timings *timings; + + if (np == NULL) + return; + + timings = of_get_display_timings(np); + if (timings) + *pptim = timings; +} + + +static int lsdc_get_connector_type(struct drm_device *ddev, + struct device_node *output, + unsigned int index) +{ + const char *name; + int ret; + + ret = of_property_read_string(output, "connector", &name); + if (ret < 0) { + drm_warn(ddev, "please give a valid connector property\n"); + return DRM_MODE_CONNECTOR_Unknown; + } + + if (strncmp(name, "vga-connector", 13) == 0) { + ret = DRM_MODE_CONNECTOR_VGA; + drm_info(ddev, "connector%d is VGA\n", index); + } else if (strncmp(name, "dvi-connector", 13) == 0) { + bool analog, digital; + + analog = of_property_read_bool(output, "analog"); + digital = of_property_read_bool(output, "digital"); + + if (analog && !digital) + ret = DRM_MODE_CONNECTOR_DVIA; + else if (analog && digital) + ret = DRM_MODE_CONNECTOR_DVII; + else + ret = DRM_MODE_CONNECTOR_DVID; + + drm_info(ddev, "connector%d is DVI\n", index); + } else if (strncmp(name, "virtual-connector", 17) == 0) { + ret = DRM_MODE_CONNECTOR_VIRTUAL; + drm_info(ddev, "connector%d is virtual\n", index); + } else if (strncmp(name, "dpi-connector", 13) == 0) { + ret = DRM_MODE_CONNECTOR_DPI; + drm_info(ddev, "connector%d is DPI\n", index); + } else if (strncmp(name, "hdmi-connector", 14) == 0) { + int res; + const char *hdmi_type; + + res = of_property_read_string(output, "type", &hdmi_type); + if (res == 0) { + if (!strcmp(hdmi_type, "b")) + ret = DRM_MODE_CONNECTOR_HDMIB; + else + ret = DRM_MODE_CONNECTOR_HDMIA; + } else + ret = DRM_MODE_CONNECTOR_HDMIA; + + drm_info(ddev, "connector%d is HDMI, type is %s\n", + index, hdmi_type); + } else { + ret = DRM_MODE_CONNECTOR_Unknown; + drm_info(ddev, "The type of connector%d unknown\n", index); + } + + return ret; +} + + +struct lsdc_connector *lsdc_connector_init(struct lsdc_device *ldev, + unsigned int index) +{ + struct drm_device *ddev = &ldev->drm; + struct device_node *np = ddev->dev->of_node; + struct device_node *output = NULL; + struct lsdc_connector *lconn; + struct drm_connector *connector; + bool available = false; + unsigned int connector_type; + int ret; + + lconn = devm_kzalloc(ddev->dev, sizeof(*lconn), GFP_KERNEL); + if (lconn == NULL) + return ERR_PTR(-ENOMEM); + + lconn->index = index; + + output = of_parse_phandle(np, "output-ports", index); + if (output) { + struct device_node *disp_tims_np; + + available = of_device_is_available(output); + + if (available == false) { + drm_info(ddev, "connector%d is not available\n", index); + of_node_put(output); + return NULL; + } + + lconn->has_edid = of_property_read_bool(output, "edid"); + disp_tims_np = of_get_child_by_name(output, "display-timings"); + if (disp_tims_np) { + of_node_put(disp_tims_np); + lconn->has_disp_tim = true; + } else + lconn->has_disp_tim = false; + } else + drm_warn(ddev, "no output-ports property, please update dtb\n"); + + /* + * Providing a blindly support even through there is + * no output-ports property in the dtb. + */ + if (lconn->has_edid) { + lsdc_get_edid_from_dtb(output, lconn->edid_data); + drm_info(ddev, "connector%d provide edid\n", index); + } + + if (lconn->has_disp_tim) { + lsdc_get_display_timings_from_dtb(output, &lconn->disp_tim); + drm_info(ddev, "connector%d provide display timings\n", index); + } + + connector_type = lsdc_get_connector_type(ddev, output, index); + + if (output) + of_node_put(output); + + connector = &lconn->base; + + /* bypass the ddc creation if the edid or display timing is provided */ + if ((lconn->has_edid == false) && + (lconn->has_disp_tim == false) && + (connector_type != DRM_MODE_CONNECTOR_VIRTUAL)) { + const struct lsdc_chip_desc * const dc = ldev->desc; + + if (dc->have_builtin_i2c) + lconn->ddc = lsdc_create_i2c_chan(ddev, index); + else + lconn->ddc = lsdc_get_i2c_adapter(ddev, index); + + if (lconn->ddc && (IS_ERR(lconn->ddc) == false)) { + drm_info(ddev, "i2c%d for connector%d created\n", + i2c_adapter_id(lconn->ddc), index); + + /* only pull if the connector have a ddc */ + connector->polled = DRM_CONNECTOR_POLL_CONNECT | + DRM_CONNECTOR_POLL_DISCONNECT; + } + } + + ret = drm_connector_init_with_ddc(ddev, + connector, + &lsdc_connector_funcs, + connector_type, + lconn->ddc); + if (ret) { + drm_err(ddev, "init connector%d failed\n", index); + goto err_i2c_destroy; + } + + drm_connector_helper_add(connector, &lsdc_connector_helpers); + + return lconn; + +err_i2c_destroy: + lsdc_destroy_i2c(ddev, lconn->ddc); + return NULL; +} diff --git a/drivers/gpu/drm/lsdc/lsdc_connector.h b/drivers/gpu/drm/lsdc/lsdc_connector.h new file mode 100644 index 000000000000..e9f94a969f74 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_connector.h @@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + + +#ifndef __LSDC_CONNECTOR_H__ +#define __LSDC_CONNECTOR_H__ + +#include <drm/drm_device.h> +#include <drm/drm_connector.h> + +struct lsdc_connector { + struct drm_connector base; + + struct i2c_adapter *ddc; + + /* pass EDID from dtb support */ + unsigned char edid_data[EDID_LENGTH]; + bool has_edid; + + /* pass display timmings from dtb support */ + struct display_timings *disp_tim; + bool has_disp_tim; + + int index; +}; + +#define to_lsdc_connector(x) \ + container_of(x, struct lsdc_connector, base) + +struct lsdc_connector *lsdc_connector_init(struct lsdc_device *ldev, + unsigned int index); + +#endif diff --git a/drivers/gpu/drm/lsdc/lsdc_crtc.c b/drivers/gpu/drm/lsdc/lsdc_crtc.c new file mode 100644 index 000000000000..7623b0809b98 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_crtc.c @@ -0,0 +1,438 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#include <drm/drm_print.h> +#include <drm/drm_device.h> +#include <drm/drm_crtc.h> +#include <drm/drm_plane.h> +#include <drm/drm_atomic.h> +#include <drm/drm_vblank.h> +#include <drm/drm_drv.h> + + +#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_gem_cma_helper.h> +#include <drm/drm_atomic_helper.h> +#include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_gem_atomic_helper.h> +#include <drm/drm_damage_helper.h> + +#include "lsdc_drv.h" +#include "lsdc_regs.h" +#include "lsdc_pll.h" + + +static int lsdc_crtc_enable_vblank(struct drm_crtc *crtc) +{ + struct lsdc_device *ldev = to_lsdc(crtc->dev); + unsigned int index = drm_crtc_index(crtc); + struct drm_crtc_state *state = crtc->state; + u32 val; + + if (state->enable) { + val = lsdc_reg_read32(ldev, LSDC_INT_REG); + + if (index == 0) + val |= INT_CRTC0_VS_EN; + else if (index == 1) + val |= INT_CRTC1_VS_EN; + + lsdc_reg_write32(ldev, LSDC_INT_REG, val); + } + + return 0; +} + + +static void lsdc_crtc_disable_vblank(struct drm_crtc *crtc) +{ + struct lsdc_device *ldev = to_lsdc(crtc->dev); + unsigned int index = drm_crtc_index(crtc); + u32 val; + + val = lsdc_reg_read32(ldev, LSDC_INT_REG); + + if (index == 0) + val &= ~INT_CRTC0_VS_EN; + else if (index == 1) + val &= ~INT_CRTC1_VS_EN; + + lsdc_reg_write32(ldev, LSDC_INT_REG, val); +} + + +static void lsdc_crtc_reset(struct drm_crtc *crtc) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + unsigned int index = drm_crtc_index(crtc); + struct lsdc_crtc_state *priv_crtc_state; + u32 val; + + /* The crtc get soft reset if bit 20 of CRTC*_CFG_REG + * is write with falling edge. + * + * Doing this to switch from soft reset state to working state + */ + if (index == 0) { + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + val |= CFG_RESET_BIT | CFG_OUTPUT_EN_BIT; + lsdc_reg_write32(ldev, LSDC_CRTC0_CFG_REG, val); + } else if (index == 1) { + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + val |= CFG_RESET_BIT | CFG_OUTPUT_EN_BIT; + lsdc_reg_write32(ldev, LSDC_CRTC1_CFG_REG, val); + } + + if (crtc->state) { + priv_crtc_state = to_lsdc_crtc_state(crtc->state); + __drm_atomic_helper_crtc_destroy_state(&priv_crtc_state->base); + kfree(priv_crtc_state); + } + + priv_crtc_state = kzalloc(sizeof(*priv_crtc_state), GFP_KERNEL); + if (!priv_crtc_state) + return; + + priv_crtc_state->pix_fmt = val & CFG_PIX_FMT_MASK; + + __drm_atomic_helper_crtc_reset(crtc, &priv_crtc_state->base); + + drm_info(ddev, "crtc%u reset\n", index); +} + + +static void lsdc_crtc_atomic_destroy_state(struct drm_crtc *crtc, + struct drm_crtc_state *state) +{ + struct lsdc_crtc_state *priv_crtc_state = to_lsdc_crtc_state(state); + + __drm_atomic_helper_crtc_destroy_state(&priv_crtc_state->base); + + kfree(priv_crtc_state); +} + + +static struct drm_crtc_state *lsdc_crtc_atomic_duplicate_state(struct drm_crtc *crtc) +{ + struct lsdc_crtc_state *new_priv_state; + struct lsdc_crtc_state *old_priv_state; + struct drm_device *ddev = crtc->dev; + + if (drm_WARN_ON(ddev, !crtc->state)) + return NULL; + + new_priv_state = kmalloc(sizeof(*new_priv_state), GFP_KERNEL); + if (!new_priv_state) + return NULL; + + __drm_atomic_helper_crtc_duplicate_state(crtc, &new_priv_state->base); + + old_priv_state = to_lsdc_crtc_state(crtc->state); + + memcpy(&new_priv_state->pparams, &old_priv_state->pparams, + sizeof(new_priv_state->pparams)); + + new_priv_state->pix_fmt = old_priv_state->pix_fmt; + + return &new_priv_state->base; +} + + +static const struct drm_crtc_funcs lsdc_crtc_funcs = { + .reset = lsdc_crtc_reset, + .destroy = drm_crtc_cleanup, + .set_config = drm_atomic_helper_set_config, + .page_flip = drm_atomic_helper_page_flip, + .atomic_duplicate_state = lsdc_crtc_atomic_duplicate_state, + .atomic_destroy_state = lsdc_crtc_atomic_destroy_state, + .enable_vblank = lsdc_crtc_enable_vblank, + .disable_vblank = lsdc_crtc_disable_vblank, +}; + + +static enum drm_mode_status +lsdc_crtc_helper_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + const struct lsdc_chip_desc *desc = ldev->desc; + + if (mode->hdisplay > desc->max_width) + return MODE_BAD_HVALUE; + if (mode->vdisplay > desc->max_height) + return MODE_BAD_VVALUE; + + if (mode->clock > desc->max_pixel_clk) { + drm_dbg_kms(ddev, "mode %dx%d, pixel clock=%d is too high\n", + mode->hdisplay, mode->vdisplay, mode->clock); + return MODE_CLOCK_HIGH; + } + + /* the crtc hardware dma take 256 bytes once a time */ + if (mode->hdisplay % 64) { + drm_dbg_kms(ddev, "stride is not 256 bytes aligned\n"); + return MODE_BAD; + } + + return MODE_OK; +} + + +static void lsdc_update_pixclk(struct drm_crtc *crtc, unsigned int pixclk, bool verbose) +{ + struct lsdc_display_pipe *dispipe; + struct lsdc_pll *pixpll; + const struct lsdc_pixpll_funcs *clkfun; + struct lsdc_crtc_state *priv_crtc_state; + + priv_crtc_state = to_lsdc_crtc_state(crtc->state); + + dispipe = container_of(crtc, struct lsdc_display_pipe, crtc); + pixpll = &dispipe->pixpll; + clkfun = pixpll->funcs; + + /* config the pixel pll */ + clkfun->update(pixpll, &priv_crtc_state->pparams); + + if (verbose) + clkfun->print(pixpll, pixclk); +} + + +static void lsdc_crtc_helper_mode_set_nofb(struct drm_crtc *crtc) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_display_mode *mode = &crtc->state->adjusted_mode; + unsigned int hr = mode->hdisplay; + unsigned int hss = mode->hsync_start; + unsigned int hse = mode->hsync_end; + unsigned int hfl = mode->htotal; + unsigned int vr = mode->vdisplay; + unsigned int vss = mode->vsync_start; + unsigned int vse = mode->vsync_end; + unsigned int vfl = mode->vtotal; + unsigned int pixclock = mode->clock; + unsigned int index = drm_crtc_index(crtc); + + + if (index == 0) { + /* CRTC 0 */ + u32 hsync, vsync; + + lsdc_reg_write32(ldev, LSDC_CRTC0_FB_ORIGIN_REG, 0); + + /* 26:16 total pixels, 10:0 visiable pixels, in horizontal */ + lsdc_reg_write32(ldev, LSDC_CRTC0_HDISPLAY_REG, + (mode->crtc_htotal << 16) | mode->crtc_hdisplay); + + /* 26:16 total pixels, 10:0 visiable pixels, in vertical */ + lsdc_reg_write32(ldev, LSDC_CRTC0_VDISPLAY_REG, + (mode->crtc_vtotal << 16) | mode->crtc_vdisplay); + + /* 26:16 hsync end, 10:0 hsync start */ + hsync = (mode->crtc_hsync_end << 16) | mode->crtc_hsync_start; + + if (mode->flags & DRM_MODE_FLAG_NHSYNC) + hsync |= INV_HSYNC_BIT; + + lsdc_reg_write32(ldev, LSDC_CRTC0_HSYNC_REG, EN_HSYNC_BIT | hsync); + + /* 26:16 vsync end, 10:0 vsync start */ + vsync = (mode->crtc_vsync_end << 16) | mode->crtc_vsync_start; + + if (mode->flags & DRM_MODE_FLAG_NVSYNC) + vsync |= INV_VSYNC_BIT; + + lsdc_reg_write32(ldev, LSDC_CRTC0_VSYNC_REG, EN_VSYNC_BIT | vsync); + + } else if (index == 1) { + /* CRTC 1 */ + u32 hsync, vsync; + + lsdc_reg_write32(ldev, LSDC_CRTC1_FB_ORIGIN_REG, 0); + + /* 26:16 total pixels, 10:0 visiable pixels, in horizontal */ + lsdc_reg_write32(ldev, LSDC_CRTC1_HDISPLAY_REG, + (mode->crtc_htotal << 16) | mode->crtc_hdisplay); + + /* 26:16 total pixels, 10:0 visiable pixels, in vertical */ + lsdc_reg_write32(ldev, LSDC_CRTC1_VDISPLAY_REG, + (mode->crtc_vtotal << 16) | mode->crtc_vdisplay); + + /* 26:16 hsync end, 10:0 hsync start */ + hsync = (mode->crtc_hsync_end << 16) | mode->crtc_hsync_start; + + if (mode->flags & DRM_MODE_FLAG_NHSYNC) + hsync |= INV_HSYNC_BIT; + + lsdc_reg_write32(ldev, LSDC_CRTC1_HSYNC_REG, EN_HSYNC_BIT | hsync); + + /* 26:16 vsync end, 10:0 vsync start */ + vsync = (mode->crtc_vsync_end << 16) | mode->crtc_vsync_start; + + if (mode->flags & DRM_MODE_FLAG_NVSYNC) + vsync |= INV_VSYNC_BIT; + + lsdc_reg_write32(ldev, LSDC_CRTC1_VSYNC_REG, EN_VSYNC_BIT | vsync); + } + + drm_dbg_kms(ddev, "hdisplay=%d, hsync_start=%d, hsync_end=%d, htotal=%d\n", + hr, hss, hse, hfl); + + drm_dbg_kms(ddev, "vdisplay=%d, vsync_start=%d, vsync_end=%d, vtotal=%d\n", + vr, vss, vse, vfl); + + drm_dbg_kms(ddev, "%s modeset: %ux%u\n", crtc->name, hr, vr); + + lsdc_update_pixclk(crtc, pixclock, false); +} + + +void lsdc_enable_display(struct lsdc_device *ldev, unsigned int index) +{ + u32 val; + + if (index == 0) { + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + val |= CFG_OUTPUT_EN_BIT; + lsdc_reg_write32(ldev, LSDC_CRTC0_CFG_REG, val); + } else if (index == 1) { + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + val |= CFG_OUTPUT_EN_BIT; + lsdc_reg_write32(ldev, LSDC_CRTC1_CFG_REG, val); + } +} + + +void lsdc_disable_display(struct lsdc_device *ldev, unsigned int index) +{ + u32 val; + + if (index == 0) { + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + val &= ~CFG_OUTPUT_EN_BIT; + lsdc_reg_write32(ldev, LSDC_CRTC0_CFG_REG, val); + } else if (index == 1) { + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + val &= ~CFG_OUTPUT_EN_BIT; + lsdc_reg_write32(ldev, LSDC_CRTC1_CFG_REG, val); + } +} + + +static void lsdc_crtc_helper_atomic_enable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + + drm_crtc_vblank_on(crtc); + + lsdc_enable_display(ldev, drm_crtc_index(crtc)); + + drm_dbg_kms(ddev, "%s: enabled\n", crtc->name); +} + + +static void lsdc_crtc_helper_atomic_disable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + + drm_crtc_vblank_off(crtc); + + lsdc_disable_display(ldev, drm_crtc_index(crtc)); + + drm_dbg_kms(ddev, "%s: disabled\n", crtc->name); +} + + +static void lsdc_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct drm_pending_vblank_event *event = crtc->state->event; + + if (event) { + crtc->state->event = NULL; + + spin_lock_irq(&crtc->dev->event_lock); + if (drm_crtc_vblank_get(crtc) == 0) + drm_crtc_arm_vblank_event(crtc, event); + else + drm_crtc_send_vblank_event(crtc, event); + spin_unlock_irq(&crtc->dev->event_lock); + } +} + + +static const struct drm_crtc_helper_funcs lsdc_crtc_helper_funcs = { + .mode_valid = lsdc_crtc_helper_mode_valid, + .mode_set_nofb = lsdc_crtc_helper_mode_set_nofb, + .atomic_enable = lsdc_crtc_helper_atomic_enable, + .atomic_disable = lsdc_crtc_helper_atomic_disable, + .atomic_flush = lsdc_crtc_atomic_flush, +}; + + + +/** + * lsdc_crtc_init + * + * @ddev: point to the drm_device structure + * @index: hardware crtc index + * + * Init CRTC + */ +int lsdc_crtc_init(struct drm_device *ddev, + struct drm_crtc *crtc, + unsigned int index, + struct drm_plane *primary, + struct drm_plane *cursor) +{ + int ret; + + drm_crtc_helper_add(crtc, &lsdc_crtc_helper_funcs); + + ret = drm_mode_crtc_set_gamma_size(crtc, 256); + if (ret) + drm_warn(ddev, "set the gamma table size failed\n"); + + return drm_crtc_init_with_planes(ddev, + crtc, + primary, + cursor, + &lsdc_crtc_funcs, + "crtc%d", + index); +} diff --git a/drivers/gpu/drm/lsdc/lsdc_drv.c b/drivers/gpu/drm/lsdc/lsdc_drv.c new file mode 100644 index 000000000000..9450167149fd --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_drv.c @@ -0,0 +1,823 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#include <linux/errno.h> +#include <linux/string.h> +#include <linux/module.h> +#include <linux/pci.h> +#include <linux/of_reserved_mem.h> + +#include <drm/drm_drv.h> +#include <drm/drm_aperture.h> +#include <drm/drm_of.h> +#include <drm/drm_plane.h> +#include <drm/drm_vblank.h> +#include <drm/drm_debugfs.h> +#include <drm/drm_fb_helper.h> +#include <drm/drm_crtc_helper.h> +#include <drm/drm_gem_cma_helper.h> +#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_atomic_helper.h> +#include <drm/drm_damage_helper.h> +#include <drm/drm_probe_helper.h> + +#include "lsdc_drv.h" +#include "lsdc_irq.h" +#include "lsdc_regs.h" +#include "lsdc_connector.h" +#include "lsdc_pll.h" + + +#define DRIVER_AUTHOR "Sui Jingfeng <suijingfeng(a)loongson.cn>" +#define DRIVER_NAME "lsdc" +#define DRIVER_DESC "drm driver for loongson's display controller" +#define DRIVER_DATE "20200701" +#define DRIVER_MAJOR 1 +#define DRIVER_MINOR 0 +#define DRIVER_PATCHLEVEL 0 + +static int lsdc_modeset = 1; +MODULE_PARM_DESC(modeset, "Enable/disable CMA-based KMS(1 = enabled(default), 0 = disabled)"); +module_param_named(modeset, lsdc_modeset, int, 0644); + +static int lsdc_cached_coherent = 1; +MODULE_PARM_DESC(cached_coherent, "using cached coherent mapping(1 = enabled(default), 0 = disabled)"); +module_param_named(cached_coherent, lsdc_cached_coherent, int, 0644); + +static int lsdc_dirty_update = -1; +MODULE_PARM_DESC(dirty_update, "enable dirty update(1 = enabled, 0 = disabled(default))"); +module_param_named(dirty_update, lsdc_dirty_update, int, 0644); + +static int lsdc_use_vram_helper = -1; +MODULE_PARM_DESC(use_vram_helper, "use vram helper(1 = enabled, 0 = disabled(default))"); +module_param_named(use_vram_helper, lsdc_use_vram_helper, int, 0644); + + +static const struct lsdc_chip_desc dc_in_ls2k1000 = { + .chip = LSDC_CHIP_2K1000, + .num_of_crtc = LSDC_MAX_CRTC, + /* ls2k1000 user manual say the max pixel clock can be about 200MHz */ + .max_pixel_clk = 200000, + .max_width = 2560, + .max_height = 2048, + .num_of_hw_cursor = 1, + .hw_cursor_w = 32, + .hw_cursor_h = 32, + .have_builtin_i2c = false, +}; + +static const struct lsdc_chip_desc dc_in_ls2k0500 = { + .chip = LSDC_CHIP_2K0500, + .num_of_crtc = LSDC_MAX_CRTC, + .max_pixel_clk = 200000, + .max_width = 2048, + .max_height = 2048, + .num_of_hw_cursor = 1, + .hw_cursor_w = 32, + .hw_cursor_h = 32, + .have_builtin_i2c = false, +}; + +static const struct lsdc_chip_desc dc_in_ls7a1000 = { + .chip = LSDC_CHIP_7A1000, + .num_of_crtc = LSDC_MAX_CRTC, + .max_pixel_clk = 200000, + .max_width = 2048, + .max_height = 2048, + .num_of_hw_cursor = 1, + .hw_cursor_w = 32, + .hw_cursor_h = 32, + .have_builtin_i2c = true, +}; + + +static const struct of_device_id lsdc_drm_of_match[] = { + { .compatible = "loongson,loongson64c-4core-ls7a", .data = &dc_in_ls7a1000 }, + { .compatible = "loongson,loongson64g-4core-ls7a", .data = &dc_in_ls7a1000 }, + { .compatible = "loongson,loongson64-2core-2k1000", .data = &dc_in_ls2k1000 }, + { .compatible = "loongson,loongson2k1000", .data = &dc_in_ls2k1000 }, + { .compatible = "loongson,ls2k1000", .data = &dc_in_ls2k1000 }, + { .compatible = "loongson,display-subsystem", .data = &dc_in_ls2k1000 }, + { .compatible = "loongson,ls-fb", .data = &dc_in_ls2k1000 }, + { .compatible = "loongson,loongson2k0500", .data = &dc_in_ls2k0500 }, + { /* sentinel */ }, +}; + + +static struct drm_framebuffer * +lsdc_drm_gem_fb_create(struct drm_device *ddev, struct drm_file *file, + const struct drm_mode_fb_cmd2 *mode_cmd) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + + if (ldev->dirty_update) + return drm_gem_fb_create_with_dirty(ddev, file, mode_cmd); + + return drm_gem_fb_create(ddev, file, mode_cmd); +} + + +static enum drm_mode_status lsdc_device_mode_valid(struct drm_device *ddev, + const struct drm_display_mode *mode) +{ +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + struct lsdc_device *ldev = to_lsdc(ddev); + + if (ldev->use_vram_helper == true) + return drm_vram_helper_mode_valid(ddev, mode); +#endif + + return MODE_OK; +} + + +static const struct drm_mode_config_funcs lsdc_mode_config_funcs = { + .fb_create = lsdc_drm_gem_fb_create, + .output_poll_changed = drm_fb_helper_output_poll_changed, + .atomic_check = drm_atomic_helper_check, + .atomic_commit = drm_atomic_helper_commit, + .mode_valid = lsdc_device_mode_valid, +}; + + +#ifdef CONFIG_DEBUG_FS +static int lsdc_show_pxlclock(struct seq_file *m, void *arg) +{ + struct drm_info_node *node = (struct drm_info_node *)m->private; + struct drm_device *ddev = node->minor->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_crtc *crtc; + + drm_for_each_crtc(crtc, ddev) { + struct drm_crtc_state *state = crtc->state; + int index = drm_crtc_index(crtc); + struct lsdc_display_pipe *pipe = &ldev->disp_pipe[index]; + struct lsdc_pll *pixpll = &pipe->pixpll; + const struct lsdc_pixpll_funcs *clkfun =pixpll->funcs; + unsigned int clkrate = clkfun->get_clock_rate(pixpll); + unsigned int mode_clock = crtc->mode.crtc_clock; + + seq_printf(m, "\n"); + seq_printf(m, "CRTC%u, %s, %s\n", index, + state->active ? "active" : "non-active", + state->enable ? "enabled" : "disabled"); + seq_printf(m, "hw clock: %u kHz\n", clkrate); + seq_printf(m, "mode: %u kHz\n", mode_clock); + + seq_printf(m, "div_out=%u, loopc=%u, div_ref=%u\n", + pixpll->core_params.div_out, + pixpll->core_params.loopc, + pixpll->core_params.div_ref); + } + + return 0; +} + + +static int lsdc_mm_show(struct seq_file *m, void *arg) +{ + struct drm_info_node *node = (struct drm_info_node *) m->private; + struct drm_device *ddev = node->minor->dev; + struct drm_printer p = drm_seq_file_printer(m); + drm_mm_print(&ddev->vma_offset_manager->vm_addr_space_mm, &p); + return 0; +} + +static struct drm_info_list lsdc_debugfs_list[] = { + { "clocks", lsdc_show_pxlclock, 0 }, + { "mm", lsdc_mm_show, 0, NULL }, +}; + +static void lsdc_debugfs_init(struct drm_minor *minor) +{ + drm_debugfs_create_files(lsdc_debugfs_list, + ARRAY_SIZE(lsdc_debugfs_list), + minor->debugfs_root, + minor); +} +#endif + + +static struct drm_gem_object * +lsdc_drm_gem_create_object(struct drm_device *ddev, size_t size) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_gem_cma_object *obj; + + obj = kzalloc(sizeof(*obj), GFP_KERNEL); + if (!obj) + return ERR_PTR(-ENOMEM); + + if (ldev->cached_coherent) + obj->map_noncoherent = true; + + return &obj->base; +} + + +static int lsdc_gem_cma_dumb_create(struct drm_file *file, + struct drm_device *ddev, + struct drm_mode_create_dumb *args) +{ + unsigned int bytes_per_pixel = (args->bpp + 7) / 8; + unsigned int pitch = bytes_per_pixel * args->width; + + /* + * loongson's display controller require the pitch be a multiple + * of 256 bytes, which is for optimize dma dma data transfer + */ + args->pitch = roundup(pitch, 256); + + return drm_gem_cma_dumb_create_internal(file, ddev, args); +} + + +DEFINE_DRM_GEM_CMA_FOPS(lsdc_drv_fops); + + +static const struct drm_driver lsdc_drm_driver_cma_stub = { + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, + + .lastclose = drm_fb_helper_lastclose, + .fops = &lsdc_drv_fops, + .gem_create_object = lsdc_drm_gem_create_object, + + .name = DRIVER_NAME, + .desc = DRIVER_DESC, + .date = DRIVER_DATE, + .major = DRIVER_MAJOR, + .minor = DRIVER_MINOR, + .patchlevel = DRIVER_PATCHLEVEL, + + DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE(lsdc_gem_cma_dumb_create), + +#ifdef CONFIG_DEBUG_FS + .debugfs_init = lsdc_debugfs_init, +#endif +}; + + +DEFINE_DRM_GEM_FOPS(lsdc_fops); + + +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER +static const struct drm_driver lsdc_vram_driver_stub = { + .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC, + .fops = &lsdc_fops, + + .name = DRIVER_NAME, + .desc = DRIVER_DESC, + .date = DRIVER_DATE, + .major = DRIVER_MAJOR, + .minor = DRIVER_MINOR, + .patchlevel = DRIVER_PATCHLEVEL, + + DRM_GEM_VRAM_DRIVER, +}; +#endif + + +static int lsdc_modeset_init(struct lsdc_device *ldev, const uint32_t num_crtc) +{ + struct drm_device *ddev = &ldev->drm; + struct lsdc_display_pipe *dispipe; + struct lsdc_connector *lconn; + unsigned int i; + int ret; + + /* first find all of connector available */ + for (i = 0; i < num_crtc; i++) { + lconn = lsdc_connector_init(ldev, i); + dispipe = &ldev->disp_pipe[i]; + + if (IS_ERR(lconn)) + return PTR_ERR(lconn); + else if (lconn == NULL) { + dispipe->lconn = NULL; + dispipe->available = false; + continue; + } + + /* take a record */ + dispipe->available = true; + dispipe->lconn = lconn; + ldev->num_output++; + } + + drm_info(ddev, "number of outputs: %u\n", ldev->num_output); + + for (i = 0; i < num_crtc; i++) { + struct lsdc_display_pipe * const dispipe = &ldev->disp_pipe[i]; + struct drm_plane * const primary = &dispipe->primary; + struct drm_plane * const cursor = &dispipe->cursor; + struct drm_encoder * const encoder = &dispipe->encoder; + struct drm_crtc * const crtc = &dispipe->crtc; + struct lsdc_pll * const pixpll = &dispipe->pixpll; + + dispipe->index = i; + + ret = lsdc_pixpll_init(pixpll, ddev, i); + if (ret) + return ret; + + ret = lsdc_plane_init(ldev, primary, DRM_PLANE_TYPE_PRIMARY, i); + if (ret) + return ret; + + ret = lsdc_plane_init(ldev, cursor, DRM_PLANE_TYPE_CURSOR, i); + if (ret) + return ret; + + /* + * Initial all of the CRTC available, in this way the crtc + * index is equal to the hardware crtc index. That is: + * display pipe 0 = crtc0 + dvo0 + encoder0 + * display pipe 1 = crtc1 + dvo1 + encoder1 + */ + ret = lsdc_crtc_init(ddev, crtc, i, primary, cursor); + if (ret) + return ret; + + if (dispipe->available) { + ret = lsdc_encoder_init(encoder, + &dispipe->lconn->base, + ddev, + i, + ldev->num_output); + if (ret) + return ret; + } + + drm_info(ddev, "display pipe %u initialized\n", i); + } + + return 0; +} + + +static int lsdc_mode_config_init(struct lsdc_device *ldev) +{ + const struct lsdc_chip_desc * const descp = ldev->desc; + struct drm_device *ddev = &ldev->drm; + int ret; + + spin_lock_init(&ldev->reglock); + + drm_mode_config_init(ddev); + + ddev->mode_config.funcs = &lsdc_mode_config_funcs; + ddev->mode_config.min_width = 1; + ddev->mode_config.min_height = 1; + ddev->mode_config.preferred_depth = 24; + ddev->mode_config.prefer_shadow = 0; + + ddev->mode_config.max_width = 4096; + ddev->mode_config.max_height = 4096; + + ddev->mode_config.cursor_width = descp->hw_cursor_h; + ddev->mode_config.cursor_height = descp->hw_cursor_h; + + if (ldev->vram_base) + ddev->mode_config.fb_base = ldev->vram_base; + + ret = lsdc_modeset_init(ldev, descp->num_of_crtc); + if (ret) + goto out_mode_config; + + drm_mode_config_reset(ddev); + + return 0; + +out_mode_config: + drm_mode_config_cleanup(ddev); + + return ret; +} + + +static void lsdc_mode_config_fini(struct drm_device *ddev) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + + /* disable output polling */ + drm_kms_helper_poll_fini(ddev); + + drm_dev_unregister(ddev); + + devm_free_irq(ddev->dev, ldev->irq, ddev); + + /* shutdown all CRTC, for driver unloading */ + drm_atomic_helper_shutdown(ddev); + + drm_mode_config_cleanup(ddev); +} + +/* + * There are difference between the dc in ls7a1000 and the dc in ls2k1000, + * ls7a1000 have two builtin gpio emulated i2c, but ls2k1000 don't have this. + * ls2k1000 grab i2c adapter from other device driver, eithor hardware i2c or + * external gpio-emulated i2c. + * + * Beside, the pixel pll unit is also different, thererfore we a function to + * tell different chips apart. + */ +static int lsdc_determine_chip(struct lsdc_device *ldev) +{ + struct device_node *np; + const char *model; + const char *compat; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(lsdc_drm_of_match); ++i) { + compat = lsdc_drm_of_match[i].compatible; + + np = of_find_compatible_node(NULL, NULL, compat); + if (np) { + + /* additional information */ + of_property_read_string(np, "model", &model); + + of_node_put(np); + + ldev->desc = lsdc_drm_of_match[i].data; + + break; + } + } + + if (ldev->desc == NULL) { + drm_err(&ldev->drm, "unknown dc ip core, abort\n"); + return -ENOENT; + } + + drm_info(&ldev->drm, "%s found, model: %s\n", compat, model); + + return 0; +} + + +static int lsdc_drm_suspend(struct device *dev) +{ + struct drm_device *ddev = dev_get_drvdata(dev); + + return drm_mode_config_helper_suspend(ddev); +} + + +static int lsdc_drm_resume(struct device *dev) +{ + struct drm_device *ddev = dev_get_drvdata(dev); + + return drm_mode_config_helper_resume(ddev); +} + + +static int lsdc_pm_freeze(struct device *dev) +{ + return lsdc_drm_suspend(dev); +} + + +static int lsdc_pm_thaw(struct device *dev) +{ + return lsdc_drm_resume(dev); +} + + +static int lsdc_pm_suspend(struct device *dev) +{ + struct pci_dev *pdev = to_pci_dev(dev); + int error; + + error = lsdc_pm_freeze(dev); + if (error) + return error; + + pci_save_state(pdev); + /* Shut down the device */ + pci_disable_device(pdev); + pci_set_power_state(pdev, PCI_D3hot); + + return 0; +} + + +static int lsdc_pm_resume(struct device *dev) +{ + struct pci_dev *pdev = to_pci_dev(dev); + + if (pcim_enable_device(pdev)) + return -EIO; + + pci_set_power_state(pdev, PCI_D0); + + pci_restore_state(pdev); + + return lsdc_pm_thaw(dev); +} + + +static const struct dev_pm_ops lsdc_pm_ops = { + .suspend = lsdc_pm_suspend, + .resume = lsdc_pm_resume, + .freeze = lsdc_pm_freeze, + .thaw = lsdc_pm_thaw, + .poweroff = lsdc_pm_freeze, + .restore = lsdc_pm_resume, +}; + + +static int lsdc_remove_conflicting_framebuffers(const struct drm_driver *drv) +{ + /* lsdc is a pci device, but it don't have a dedicate vram bar + * because of historic reason. And simplefb node may have been + * located anywhere in memory. + */ + return drm_aperture_remove_conflicting_framebuffers(0, ~0, false, drv); +} + + +static int lsdc_vram_init(struct lsdc_device *ldev) +{ + struct drm_device *ddev = &ldev->drm; + struct pci_dev *gpu; + resource_size_t base, size; + int ret; + + /* BAR 2 of LS7A1000's GPU contain VRAM */ + gpu = pci_get_device(PCI_VENDOR_ID_LOONGSON, PCI_DEVICE_ID_GPU, NULL); + base = pci_resource_start(gpu, 2); + size = pci_resource_len(gpu, 2); + + drm_info(ddev, "vram start: 0x%llx, size: %lluMB\n", base, size >> 20); + + if (!request_mem_region(base, size, "lsdc_vram")) { + drm_err(ddev, "can't reserve VRAM memory region\n"); + return -ENXIO; + } + + if (ldev->use_vram_helper) { +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + ret = drmm_vram_helper_init(ddev, base, size); + if (ret) { + drm_err(ddev, "can't init vram helper\n"); + return ret; + } +#endif + } else if (ldev->dirty_update) { + ldev->vram = devm_ioremap_wc(ddev->dev, base, size); + if (ldev->vram == NULL) + return -ENOMEM; + + drm_info(ddev, "vram virtual addr: 0x%llx\n", (u64)ldev->vram); + } + + ldev->vram_base = base; + ldev->vram_size = size; + + return 0; +} + + +static bool lsdc_should_vram_helper_based(void) +{ + static const char *dc_compat[] = { "pci0014,7a06.0", + "pci0014,7a06", }; + bool ret = false; + struct device_node *np; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(dc_compat); ++i) { + np = of_find_compatible_node(NULL, NULL, dc_compat[i]); + if (!np) + continue; + + ret = of_property_read_bool(np, "use_vram_helper"); + of_node_put(np); + break; + } + + if (ret) + DRM_INFO("using vram base solution dictated by device tree\n"); + + return ret; +} + + +static int lsdc_pci_probe(struct pci_dev *pdev, + const struct pci_device_id * const ent) +{ + const struct drm_driver *driver = &lsdc_drm_driver_cma_stub; + struct lsdc_device *ldev; + struct drm_device *ddev; + int ret; + + lsdc_remove_conflicting_framebuffers(driver); + + ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); + if (ret) { + dev_err(&pdev->dev, "Set DMA Mask failed\n"); + return ret; + } + + ret = pcim_enable_device(pdev); + if (ret) { + dev_err(&pdev->dev, "Enable pci devive failed\n"); + return ret; + } + + pci_set_master(pdev); + + /* Get the optional framebuffer memory resource */ + ret = of_reserved_mem_device_init(&pdev->dev); + if (ret && ret != -ENODEV) + return ret; + +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + if ((lsdc_use_vram_helper > 0) || lsdc_should_vram_helper_based()) { + driver = &lsdc_vram_driver_stub; + DRM_INFO("using vram helper based solution\n"); + } +#endif + + ldev = devm_drm_dev_alloc(&pdev->dev, + driver, + struct lsdc_device, + drm); + if (IS_ERR(ldev)) + return PTR_ERR(ldev); + + ddev = &ldev->drm; + + pci_set_drvdata(pdev, ddev); + + if (lsdc_use_vram_helper > 0) + ldev->use_vram_helper = true; + else { + if (lsdc_cached_coherent > 0) { + ldev->cached_coherent = true; + drm_info(ddev, "with hardware maintained cached coherent\n"); + } + + if (lsdc_dirty_update > 0) { + ldev->dirty_update = true; + drm_info(ddev, "dirty update enabled\n"); + } + } + + ret = lsdc_determine_chip(ldev); + if (ret) + return ret; + + /* BAR 0 contains registers */ + ldev->reg_base = devm_ioremap_resource(&pdev->dev, &pdev->resource[0]); + if (IS_ERR(ldev->reg_base)) + return PTR_ERR(ldev->reg_base); + + /* LS2K1000/LS2K0500 is SoC, don't have a VRAM */ + if ((ldev->desc->chip == LSDC_CHIP_7A1000) && + (ldev->use_vram_helper || ldev->dirty_update)) + lsdc_vram_init(ldev); + + ret = lsdc_mode_config_init(ldev); + if (ret) + goto err_out; + + + ldev->irq = pdev->irq; + + dev_info(&pdev->dev, "irq = %d\n", ldev->irq); + + ret = devm_request_threaded_irq(&pdev->dev, + pdev->irq, + lsdc_irq_handler_cb, + lsdc_irq_thread_cb, + IRQF_ONESHOT, + dev_name(&pdev->dev), + ddev); + + if (ret) { + dev_err(&pdev->dev, "Failed to register lsdc interrupt\n"); + goto err_out; + } + + ret = drm_vblank_init(ddev, LSDC_MAX_CRTC); + if (ret) { + dev_err(&pdev->dev, + "Fatal error during vblank init: %d\n", ret); + goto err_out; + } + + /* Initialize and enable output polling */ + drm_kms_helper_poll_init(ddev); + + ret = drm_dev_register(ddev, 0); + if (ret) + goto err_out; + + drm_fbdev_generic_setup(ddev, 32); + + return 0; + +err_out: + drm_dev_put(ddev); + + return ret; +} + + +static void lsdc_pci_remove(struct pci_dev *pdev) +{ + struct drm_device *ddev = pci_get_drvdata(pdev); + + lsdc_mode_config_fini(ddev); + + drm_dev_put(ddev); + + pci_clear_master(pdev); + + pci_release_regions(pdev); +} + + +static const struct pci_device_id lsdc_pciid_list[] = { + {PCI_VENDOR_ID_LOONGSON, 0x7a06, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, + {0, 0, 0, 0, 0, 0, 0} +}; + + +static struct pci_driver lsdc_pci_driver = { + .name = "lsdc", + .id_table = lsdc_pciid_list, + .probe = lsdc_pci_probe, + .remove = lsdc_pci_remove, + .driver.pm = &lsdc_pm_ops, +}; + + +static int __init lsdc_drm_init(void) +{ + struct pci_dev *pdev = NULL; + + if (drm_firmware_drivers_only()) + return -EINVAL; + + if (lsdc_modeset == 0) + return -ENOENT; + + while ((pdev = pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, pdev))) { + /* + * Multiple video card workaround + * + * This integrated video driver will always be selected as + * default boot device by vgaarb system. + */ + if (pdev->vendor != PCI_VENDOR_ID_LOONGSON) { + DRM_INFO("Discrete graphic card detected, abort\n"); + return 0; + } + } + + return pci_register_driver(&lsdc_pci_driver); +} +module_init(lsdc_drm_init); + +static void __exit lsdc_drm_exit(void) +{ + pci_unregister_driver(&lsdc_pci_driver); +} +module_exit(lsdc_drm_exit); + + +MODULE_DEVICE_TABLE(pci, lsdc_pciid_list); +MODULE_AUTHOR(DRIVER_AUTHOR); +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/gpu/drm/lsdc/lsdc_drv.h b/drivers/gpu/drm/lsdc/lsdc_drv.h new file mode 100644 index 000000000000..fd45443b7a2b --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_drv.h @@ -0,0 +1,212 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#ifndef __LSDC_DRV_H__ +#define __LSDC_DRV_H__ + +#include <drm/drm_device.h> +#include <drm/drm_crtc.h> +#include <drm/drm_plane.h> +#include <drm/drm_encoder.h> + +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER +#include <drm/drm_gem_vram_helper.h> +#endif + +#include "lsdc_regs.h" +#include "lsdc_pll.h" + +#ifndef PCI_DEVICE_ID_GPU +#define PCI_DEVICE_ID_GPU 0x7a15 +#endif + + +#define LSDC_MAX_CRTC 2 + +/* There is only a 1:1 mapping of encoders and connectors for lsdc */ +/* + * +-------------------+ _________ + * | | | | + * | CRTC0 --> DVO0 ---------> Encoder0 --> Connector0 ---> | Monotor | + * | | ^ ^ |_________| + * | | | | + * | <----- i2c0 ----------------+ + * | LSDC IP CORE | + * | <----- i2c1 ----------------+ + * | | | | _________ + * | | | | | | + * | CRTC1 --> DVO1 ---------> Encoder1 --> Connector1 ---> | Panel | + * | | |_________| + * +-------------------+ + */ + +enum loongson_dc_family { + LSDC_CHIP_UNKNOWN = 0, + LSDC_CHIP_2K1000 = 1, /* 2-Core SoC, 64-bit */ + LSDC_CHIP_7A1000 = 2, /* North bridge of LS3A3000/LS3A4000/LS3A5000 */ + LSDC_CHIP_2K0500 = 3, /* Reduced version of LS2K1000, single core */ + LSDC_CHIP_7A2000 = 4, /* Newer version of 7A1000 */ + LSDC_CHIP_LAST, +}; + +enum lsdc_pixel_format { + LSDC_PF_NONE = 0, + LSDC_PF_ARGB4444 = 1, /* ARGB A:4 bits R/G/B: 4 bits each [16 bits] */ + LSDC_PF_ARGB1555 = 2, /* ARGB A:1 bit RGB:15 bits [16 bits] */ + LSDC_PF_RGB565 = 3, /* RGB [16 bits] */ + LSDC_PF_XRGB8888 = 4, /* XRGB [32 bits] */ +}; + +struct lsdc_chip_desc { + enum loongson_dc_family chip; + uint32_t num_of_crtc; + + uint32_t max_pixel_clk; + + uint32_t max_width; + uint32_t max_height; + + uint32_t num_of_hw_cursor; + uint32_t hw_cursor_w; + uint32_t hw_cursor_h; + bool have_builtin_i2c; +}; + + +/** + * struct lsdc_display_pipe - simple display pipeline + * @crtc: CRTC control structure + * @plane: Plane control structure + * @encoder: Encoder control structure + * @pixpll: Pll control structure + * @connector: point to connector control structure + * + * display pipeline with plane, crtc, encoder, pll collapsed into one + * entity. It should be initialized by calling drm_simple_display_pipe_init(). + */ +struct lsdc_display_pipe { + struct drm_crtc crtc; + struct drm_plane primary; + struct drm_plane cursor; + struct drm_encoder encoder; + struct lsdc_pll pixpll; + struct lsdc_connector *lconn; + + int index; + bool available; +}; + + +struct lsdc_crtc_state { + struct drm_crtc_state base; + struct lsdc_pll_core_values pparams; + unsigned int pix_fmt; +}; + + +struct lsdc_device { + struct drm_device drm; + + void __iomem *reg_base; + void __iomem *vram; + resource_size_t vram_base; + resource_size_t vram_size; + + struct lsdc_display_pipe disp_pipe[LSDC_MAX_CRTC]; + + unsigned int num_output; + + /* platform specific data */ + const struct lsdc_chip_desc *desc; + + /* @reglock: protects concurrent register access */ + spinlock_t reglock; + + /* + * @dirty_update: true if manual dirty update is wantted + */ + bool dirty_update; + bool cached_coherent; + bool use_vram_helper; + + int irq; + u32 irq_status; +}; + +#define to_lsdc(x) container_of(x, struct lsdc_device, drm) + +static inline struct lsdc_crtc_state * +to_lsdc_crtc_state(struct drm_crtc_state *base) +{ + return container_of(base, struct lsdc_crtc_state, base); +} + +static inline u32 lsdc_reg_read32(struct lsdc_device * const ldev, u32 offset) +{ + u32 val; + unsigned long flags; + + spin_lock_irqsave(&ldev->reglock, flags); + val = readl(ldev->reg_base + offset); + spin_unlock_irqrestore(&ldev->reglock, flags); + + return val; +} + + +static inline void lsdc_reg_write32(struct lsdc_device * const ldev, u32 offset, u32 val) +{ + unsigned long flags; + + spin_lock_irqsave(&ldev->reglock, flags); + writel(val, ldev->reg_base + offset); + spin_unlock_irqrestore(&ldev->reglock, flags); +} + + +int lsdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc, + unsigned int index, struct drm_plane *primary, + struct drm_plane *cursor); + + +int lsdc_plane_init(struct lsdc_device *ldev, struct drm_plane *plane, + enum drm_plane_type type, unsigned int index); + + +int lsdc_encoder_init(struct drm_encoder * const encoder, + struct drm_connector *connector, + struct drm_device *ddev, + unsigned int index, + unsigned int total); + +void lsdc_disable_display(struct lsdc_device *ldev, unsigned int index); + + +#endif diff --git a/drivers/gpu/drm/lsdc/lsdc_encoder.c b/drivers/gpu/drm/lsdc/lsdc_encoder.c new file mode 100644 index 000000000000..0cdd95f5bc37 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_encoder.c @@ -0,0 +1,79 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ +#include <drm/drm_print.h> +#include <drm/drm_crtc_helper.h> + +#include "lsdc_drv.h" + +static const struct drm_encoder_funcs lsdc_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + + +int lsdc_encoder_init(struct drm_encoder * const encoder, + struct drm_connector *connector, + struct drm_device *ddev, + unsigned int index, + unsigned int total) +{ + int ret; + int type; + + encoder->possible_crtcs = BIT(index); + + if (total == 2) + encoder->possible_clones = BIT(1) | BIT(0); + else if (total < 2) + encoder->possible_clones = 0; + + if (connector->connector_type == DRM_MODE_CONNECTOR_VGA) + type = DRM_MODE_ENCODER_DAC; + else if ((connector->connector_type == DRM_MODE_CONNECTOR_HDMIA) || + (connector->connector_type == DRM_MODE_CONNECTOR_HDMIB) || + (connector->connector_type == DRM_MODE_CONNECTOR_DVID)) + type = DRM_MODE_ENCODER_TMDS; + else if (connector->connector_type == DRM_MODE_CONNECTOR_DPI) + type = DRM_MODE_ENCODER_DPI; + else if (connector->connector_type == DRM_MODE_CONNECTOR_VIRTUAL) + type = DRM_MODE_ENCODER_VIRTUAL; + else + type = DRM_MODE_ENCODER_NONE; + + ret = drm_encoder_init(ddev, + encoder, + &lsdc_encoder_funcs, + type, + "encoder%d", + index); + if (ret) + return ret; + + return drm_connector_attach_encoder(connector, encoder); +} diff --git a/drivers/gpu/drm/lsdc/lsdc_i2c.c b/drivers/gpu/drm/lsdc/lsdc_i2c.c new file mode 100644 index 000000000000..895e94ae6827 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_i2c.c @@ -0,0 +1,220 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#include <linux/string.h> +#include <linux/i2c.h> + +#include "lsdc_drv.h" +#include "lsdc_regs.h" +#include "lsdc_i2c.h" + +/* + * set the state of a gpio pin indicated by mask + * @mask: gpio pin mask + */ +static void ls7a_gpio_i2c_set(struct lsdc_i2c * const i2c, int mask, int state) +{ + struct lsdc_device *ldev = to_lsdc(i2c->ddev); + u8 val; + unsigned long flags; + + spin_lock_irqsave(&ldev->reglock, flags); + + if (state) { + val = readb(i2c->dir_reg); + val |= mask; + writeb(val, i2c->dir_reg); + } else { + val = readb(i2c->dir_reg); + val &= ~mask; + writeb(val, i2c->dir_reg); + + val = readb(i2c->dat_reg); + if (state) + val |= mask; + else + val &= ~mask; + writeb(val, i2c->dat_reg); + } + + spin_unlock_irqrestore(&ldev->reglock, flags); +} + +/* + * read value back from gpio pin + * @mask: gpio pin mask + */ +static int ls7a_gpio_i2c_get(struct lsdc_i2c * const i2c, int mask) +{ + struct lsdc_device *ldev = to_lsdc(i2c->ddev); + u8 val; + unsigned long flags; + + spin_lock_irqsave(&ldev->reglock, flags); + + /* first set this pin as input */ + val = readb(i2c->dir_reg); + val |= mask; + writeb(val, i2c->dir_reg); + + /* then get level state from this pin */ + val = readb(i2c->dat_reg); + + spin_unlock_irqrestore(&ldev->reglock, flags); + + return (val & mask) ? 1 : 0; +} + + +/* set the state on the i2c->sda pin */ +static void ls7a_i2c_set_sda(void *i2c, int state) +{ + struct lsdc_i2c * const li2c = (struct lsdc_i2c *)i2c; + + return ls7a_gpio_i2c_set(li2c, li2c->sda, state); +} + +/* set the state on the i2c->scl pin */ +static void ls7a_i2c_set_scl(void *i2c, int state) +{ + struct lsdc_i2c * const li2c = (struct lsdc_i2c *)i2c; + + return ls7a_gpio_i2c_set(li2c, li2c->scl, state); +} + +/* read the value from the i2c->sda pin */ +static int ls7a_i2c_get_sda(void *i2c) +{ + struct lsdc_i2c * const li2c = (struct lsdc_i2c *)i2c; + + return ls7a_gpio_i2c_get(li2c, li2c->sda); +} + +/* read the value from the i2c->scl pin */ +static int ls7a_i2c_get_scl(void *i2c) +{ + struct lsdc_i2c * const li2c = (struct lsdc_i2c *)i2c; + + return ls7a_gpio_i2c_get(li2c, li2c->scl); +} + +/* + * Get i2c id from connector id + * + * TODO: get it from dtb + */ +static int lsdc_get_i2c_id(struct drm_device *ddev, unsigned int index) +{ + return index; +} + +/* + * mainly for dc in ls7a1000 which have builtin gpio emulated i2c + * + * @index : output channel index, 0 for DVO0, 1 for DVO1 + */ +struct i2c_adapter *lsdc_create_i2c_chan(struct drm_device *ddev, + unsigned int index) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + struct i2c_adapter *adapter; + struct lsdc_i2c *li2c; + int ret; + + li2c = devm_kzalloc(ddev->dev, sizeof(*li2c), GFP_KERNEL); + if (li2c == NULL) + return ERR_PTR(-ENOMEM); + + li2c->ddev = ddev; + + if (index == 0) { + li2c->sda = 0x01; + li2c->scl = 0x02; + } else if (index == 1) { + li2c->sda = 0x04; + li2c->scl = 0x08; + } + + li2c->dir_reg = ldev->reg_base + LS7A_DC_GPIO_DIR_REG; + li2c->dat_reg = ldev->reg_base + LS7A_DC_GPIO_DAT_REG; + + li2c->bit.setsda = ls7a_i2c_set_sda; + li2c->bit.setscl = ls7a_i2c_set_scl; + li2c->bit.getsda = ls7a_i2c_get_sda; + li2c->bit.getscl = ls7a_i2c_get_scl; + li2c->bit.udelay = 5; + li2c->bit.timeout = usecs_to_jiffies(2200); /* from VESA */ + li2c->bit.data = li2c; + + adapter = &li2c->adapter; + + adapter->algo_data = &li2c->bit; + adapter->owner = THIS_MODULE; + adapter->class = I2C_CLASS_DDC; + adapter->dev.parent = ddev->dev; + adapter->nr = -1; + + snprintf(adapter->name, sizeof(adapter->name), + "%s-%d", "lsdc_gpio_i2c", index); + + i2c_set_adapdata(adapter, li2c); + + ret = i2c_bit_add_numbered_bus(adapter); + if (ret) { + devm_kfree(ddev->dev, li2c); + return ERR_PTR(ret); + } + + return adapter; +} + + +/* + * Mainly for dc in ls2k1000, ls2k0500 SoC which should get a i2c adapter + * from i2c susystem. + * + * @index : output channel index, 0 for DVO0, 1 for DVO1 + */ +struct i2c_adapter *lsdc_get_i2c_adapter(struct drm_device *ddev, + unsigned int index) +{ + unsigned int i2c_id; + + /* find mapping between i2c id and connector id */ + i2c_id = lsdc_get_i2c_id(ddev, index); + + return i2c_get_adapter(i2c_id); +} + + +void lsdc_destroy_i2c(struct drm_device *ddev, struct i2c_adapter *adapter) +{ + i2c_put_adapter(adapter); +} diff --git a/drivers/gpu/drm/lsdc/lsdc_i2c.h b/drivers/gpu/drm/lsdc/lsdc_i2c.h new file mode 100644 index 000000000000..f4560db3694a --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_i2c.h @@ -0,0 +1,61 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + + +#ifndef __LSDC_I2C__ +#define __LSDC_I2C__ + +#include <linux/i2c.h> +#include <linux/i2c-algo-bit.h> + + +struct lsdc_i2c { + struct drm_device *ddev; + struct i2c_adapter adapter; + struct i2c_algo_bit_data bit; + /* pin bit mask */ + u8 sda; + u8 scl; + + void __iomem *dir_reg; + void __iomem *dat_reg; +}; + + +void lsdc_destroy_i2c(struct drm_device *ddev, struct i2c_adapter *i2c); + +struct i2c_adapter *lsdc_create_i2c_chan(struct drm_device *ddev, + unsigned int con_id); + +struct i2c_adapter *lsdc_get_i2c_adapter(struct drm_device *ddev, + unsigned int con_id); + + +#endif diff --git a/drivers/gpu/drm/lsdc/lsdc_irq.c b/drivers/gpu/drm/lsdc/lsdc_irq.c new file mode 100644 index 000000000000..17c53fcb8836 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_irq.c @@ -0,0 +1,49 @@ + +#include <drm/drm_vblank.h> + +#include "lsdc_drv.h" +#include "lsdc_regs.h" + + +/* Function to be called in a threaded interrupt context. */ +irqreturn_t lsdc_irq_thread_cb(int irq, void *arg) +{ + struct drm_device *ddev = arg; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_crtc *crtc; + + /* trigger the vblank event */ + if (ldev->irq_status & INT_CRTC0_VS) { + crtc = drm_crtc_from_index(ddev, 0); + drm_crtc_handle_vblank(crtc); + } + + if (ldev->irq_status & INT_CRTC1_VS) { + crtc = drm_crtc_from_index(ddev, 1); + drm_crtc_handle_vblank(crtc); + } + + lsdc_reg_write32(ldev, LSDC_INT_REG, INT_CRTC0_VS_EN | INT_CRTC1_VS_EN); + + return IRQ_HANDLED; +} + + +/* Function to be called when the IRQ occurs */ +irqreturn_t lsdc_irq_handler_cb(int irq, void *arg) +{ + struct drm_device *ddev = arg; + struct lsdc_device *ldev = to_lsdc(ddev); + + /* Read & Clear the interrupt status */ + ldev->irq_status = lsdc_reg_read32(ldev, LSDC_INT_REG); + if ((ldev->irq_status & INT_STATUS_MASK) == 0) { + drm_warn(ddev, "no interrupt occurs\n"); + return IRQ_NONE; + } + + /* clear all interrupt */ + lsdc_reg_write32(ldev, LSDC_INT_REG, ldev->irq_status); + + return IRQ_WAKE_THREAD; +} diff --git a/drivers/gpu/drm/lsdc/lsdc_irq.h b/drivers/gpu/drm/lsdc/lsdc_irq.h new file mode 100644 index 000000000000..ac187538d746 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_irq.h @@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#ifndef __LSDC_IRQ_H__ +#define __LSDC_IRQ_H__ + +irqreturn_t lsdc_irq_thread_cb(int irq, void *arg); +irqreturn_t lsdc_irq_handler_cb(int irq, void *arg); + +#endif diff --git a/drivers/gpu/drm/lsdc/lsdc_plane.c b/drivers/gpu/drm/lsdc/lsdc_plane.c new file mode 100644 index 000000000000..a80ad3d4f4d5 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_plane.c @@ -0,0 +1,711 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#include <drm/drm_print.h> +#include <drm/drm_device.h> +#include <drm/drm_crtc.h> +#include <drm/drm_plane.h> +#include <drm/drm_atomic.h> +#include <drm/drm_vblank.h> +#include <drm/drm_drv.h> + +#include <drm/drm_format_helper.h> +#include <drm/drm_plane_helper.h> +#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_gem_cma_helper.h> +#include <drm/drm_atomic_helper.h> +#include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_gem_atomic_helper.h> +#include <drm/drm_damage_helper.h> + + +#include "lsdc_drv.h" +#include "lsdc_regs.h" +#include "lsdc_pll.h" + + +static const uint32_t lsdc_primary_formats[] = { + DRM_FORMAT_RGB565, + DRM_FORMAT_XRGB8888, + DRM_FORMAT_ARGB8888, +}; + +static const uint32_t lsdc_cursor_formats[] = { + DRM_FORMAT_ARGB8888, +}; + +static const u64 lsdc_fb_format_modifiers[] = { + DRM_FORMAT_MOD_LINEAR, + DRM_FORMAT_MOD_INVALID +}; + + +static u32 lsdc_pixfmt_to_drm_pixfmt(enum lsdc_pixel_format pf) +{ + switch (pf) { + case LSDC_PF_XRGB8888: + return DRM_FORMAT_XRGB8888; + case LSDC_PF_RGB565: + return DRM_FORMAT_RGB565; + case LSDC_PF_ARGB1555: + return DRM_FORMAT_ARGB1555; + case LSDC_PF_ARGB4444: + return DRM_FORMAT_ARGB4444; + case LSDC_PF_NONE: + default: + return 0; + } +} + +static const char *lsdc_pixfmt_to_string(u32 reg) +{ + switch (reg & CFG_PIX_FMT_MASK) { + case LSDC_PF_XRGB8888: + return "XRGB8888"; + case LSDC_PF_RGB565: + return "RGB565"; + case LSDC_PF_ARGB1555: + return "ARGB1555"; + case LSDC_PF_ARGB4444: + return "ARGB4444"; + case LSDC_PF_NONE: + return "NONE"; + default: + return "unknown"; + } +} + + + +static void lsdc_update_fb_format(struct lsdc_device *ldev, + struct drm_crtc *crtc, + const struct drm_format_info *fmt_info) +{ + unsigned int index = drm_crtc_index(crtc); + u32 fmt; + u32 val; + + switch (fmt_info->format) { + case DRM_FORMAT_RGB565: + fmt = LSDC_PF_RGB565; + break; + case DRM_FORMAT_XRGB8888: + fmt = LSDC_PF_XRGB8888; + break; + case DRM_FORMAT_ARGB8888: + fmt = LSDC_PF_XRGB8888; + break; + default: + fmt = LSDC_PF_XRGB8888; + break; + } + + drm_dbg_kms(&ldev->drm, "fmt wanted is %s\n", + lsdc_pixfmt_to_string(fmt)); + + if (index == 0) { + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + val = (val & ~CFG_PIX_FMT_MASK) | fmt; + lsdc_reg_write32(ldev, LSDC_CRTC0_CFG_REG, val); + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + + } else if (index == 1) { + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + val = (val & ~CFG_PIX_FMT_MASK) | fmt; + lsdc_reg_write32(ldev, LSDC_CRTC1_CFG_REG, val); + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + } + + drm_info(&ldev->drm, "after update fb%d format is %s\n", + index, lsdc_pixfmt_to_string(val)); +} + + +static void lsdc_primary_get_default_format(struct drm_crtc *crtc) +{ + struct lsdc_device *ldev = to_lsdc(crtc->dev); + unsigned int index = drm_crtc_index(crtc); + struct lsdc_crtc_state *priv_crtc_state; + u32 val; + + if (crtc->state) { + priv_crtc_state = to_lsdc_crtc_state(crtc->state); + if (index == 0) + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + else if (index == 1) + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + + priv_crtc_state->pix_fmt = val & CFG_PIX_FMT_MASK; + } else + priv_crtc_state->pix_fmt = LSDC_PF_NONE; + + drm_dbg_kms(crtc->dev, "current fb format: %d\n", + priv_crtc_state->pix_fmt); +} + + +static void lsdc_update_fb_start_addr(struct lsdc_device *ldev, + struct drm_crtc *crtc, + u64 paddr) +{ + unsigned int index = drm_crtc_index(crtc); + u32 addr_reg; + u32 cfg_reg; + u32 val; + + /* + * Find which framebuffer address register should update. + * if FB_ADDR0_REG is in using, we write the addr to FB_ADDR1_REG, + * if FB_ADDR1_REG is in using, we write the addr to FB_ADDR0_REG + */ + if (index == 0) { + /* CRTC0 */ + val = lsdc_reg_read32(ldev, LSDC_CRTC0_CFG_REG); + + cfg_reg = LSDC_CRTC0_CFG_REG; + + if (val & CFG_FB_IDX_BIT) { + addr_reg = LSDC_CRTC0_FB_ADDR0_REG; + drm_dbg_kms(&ldev->drm, "CRTC0 FB0 will be use\n"); + } else { + addr_reg = LSDC_CRTC0_FB_ADDR1_REG; + drm_dbg_kms(&ldev->drm, "CRTC0 FBq will be use\n"); + } + } else if (index == 1) { + /* CRTC1 */ + val = lsdc_reg_read32(ldev, LSDC_CRTC1_CFG_REG); + + cfg_reg = LSDC_CRTC1_CFG_REG; + + if (val & CFG_FB_IDX_BIT) { + addr_reg = LSDC_CRTC1_FB_ADDR0_REG; + drm_dbg_kms(&ldev->drm, "CRTC1 FB0 will be use\n"); + } else { + addr_reg = LSDC_CRTC1_FB_ADDR1_REG; + drm_dbg_kms(&ldev->drm, "CRTC1 FBq will be use\n"); + } + } + + lsdc_reg_write32(ldev, addr_reg, paddr); + + /* + * Then, we triger the fb switch, the switch of the framebuffer + * to be scanout will complete at the next vblank. + */ + lsdc_reg_write32(ldev, cfg_reg, val | CFG_PAGE_FLIP_BIT); + + drm_dbg_kms(&ldev->drm, "crtc%u scantout from 0x%llx\n", index, paddr); +} + + +static void lsdc_handle_damage(struct lsdc_device *ldev, + struct drm_framebuffer *fb, + struct drm_rect *clip, + void *src) +{ + unsigned int offset; + void __iomem *dst; + + offset = drm_fb_clip_offset(fb->pitches[0], fb->format, clip); + dst = ldev->vram + offset; + drm_fb_memcpy_toio(dst, fb->pitches[0], src, fb, clip); +} + + +static void lsdc_handle_fullscreen_damage(struct lsdc_device *ldev, + struct drm_framebuffer *fb, + void *src) +{ + struct drm_rect fullscreen = { + .x1 = 0, + .x2 = fb->width, + .y1 = 0, + .y2 = fb->height, + }; + + lsdc_handle_damage(ldev, fb, &fullscreen, src); +} + + +static unsigned int lsdc_get_fb_offset(struct drm_framebuffer *fb, + struct drm_plane_state *state, + unsigned int plane) +{ + unsigned int offset; + + offset = fb->offsets[plane]; + offset += fb->format->cpp[plane] * (state->src_x >> 16); + offset += fb->pitches[plane] * (state->src_y >> 16); + + return offset; +} + +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER +static s64 lsdc_get_vram_bo_offset(struct drm_framebuffer *fb) +{ + struct drm_gem_vram_object *gbo; + s64 gpu_addr; + + gbo = drm_gem_vram_of_gem(fb->obj[0]); + gpu_addr = drm_gem_vram_offset(gbo); + + return gpu_addr; +} +#endif + + +static int lsdc_primary_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = plane->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_plane_state *old_plane_state; + struct drm_plane_state *new_plane_state; + struct drm_crtc_state *new_crtc_state; + struct lsdc_crtc_state *priv_crtc_state; + struct drm_framebuffer *new_fb; + struct drm_framebuffer *old_fb; + u32 new_format; + int ret; + + old_plane_state = drm_atomic_get_old_plane_state(state, plane); + new_plane_state = drm_atomic_get_new_plane_state(state, plane); + new_fb = new_plane_state->fb; + old_fb = old_plane_state->fb; + new_format = new_fb->format->format; + + if (!new_plane_state->crtc) + return 0; + + new_crtc_state = drm_atomic_get_new_crtc_state(state, + new_plane_state->crtc); + if (WARN_ON(!new_crtc_state)) + return -EINVAL; + + priv_crtc_state = to_lsdc_crtc_state(new_crtc_state); + + ret = drm_atomic_helper_check_plane_state(new_plane_state, + new_crtc_state, + DRM_PLANE_HELPER_NO_SCALING, + DRM_PLANE_HELPER_NO_SCALING, + false, + true); + if (ret) + return ret; + + /* + * Require full modeset if enabling or disabling a plane, + * or changing its position, size, depth or format. + */ + if ((!new_fb || ! old_fb || + old_plane_state->crtc_x != new_plane_state->crtc_x || + old_plane_state->crtc_y != new_plane_state->crtc_y || + old_plane_state->crtc_w != new_plane_state->crtc_w || + old_plane_state->crtc_h != new_plane_state->crtc_h || + old_fb->format->format != new_format)) + new_crtc_state->mode_changed = true; + + + if (lsdc_pixfmt_to_drm_pixfmt(priv_crtc_state->pix_fmt) != new_format) + new_crtc_state->mode_changed = true; + + + if (new_crtc_state->mode_changed) { + struct lsdc_display_pipe *dispipe = container_of( + plane, struct lsdc_display_pipe, primary); + struct lsdc_pll *pixpll = &dispipe->pixpll; + const struct lsdc_pixpll_funcs *pfuncs = pixpll->funcs; + + ret = pfuncs->compute(pixpll, + new_crtc_state->mode.clock, + true, + &priv_crtc_state->pparams); + if (ret == false) { + drm_warn(plane->dev, + "failed find a set of pll param for mode %u\n", + new_crtc_state->mode.clock); + return -EINVAL; + } + } + + if (ldev->dirty_update) + drm_atomic_helper_check_plane_damage(state, new_plane_state); + + return 0; +} + +static void lsdc_update_stride(struct lsdc_device *ldev, + struct drm_crtc *crtc, + unsigned int stride) +{ + unsigned int index = drm_crtc_index(crtc); + + if (index == 0) + lsdc_reg_write32(ldev, LSDC_CRTC0_STRIDE_REG, stride); + else if (index == 1) + lsdc_reg_write32(ldev, LSDC_CRTC1_STRIDE_REG, stride); + + drm_dbg_kms(&ldev->drm, "update stride to %u\n", stride); +} + + + +static void lsdc_primary_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct lsdc_device *ldev = to_lsdc(plane->dev); + struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, plane); + struct drm_crtc *crtc = new_plane_state->crtc; + struct drm_framebuffer *fb = new_plane_state->fb; + u32 fb_offset = lsdc_get_fb_offset(fb, new_plane_state, 0); + struct drm_gem_cma_object *obj; + dma_addr_t fb_addr; + + if (ldev->use_vram_helper) { +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + s64 gpu_addr; + + gpu_addr = lsdc_get_vram_bo_offset(fb); + if (gpu_addr < 0) + return; + + fb_addr = ldev->vram_base + gpu_addr + fb_offset; +#endif + } else { + obj = drm_fb_cma_get_gem_obj(fb, 0); + + if (ldev->dirty_update) + fb_addr = ldev->vram_base + fb_offset; + else + fb_addr = obj->paddr + fb_offset; + } + + lsdc_update_fb_start_addr(ldev, crtc, fb_addr); + + lsdc_update_stride(ldev, crtc, fb->pitches[0]); + + if (drm_atomic_crtc_needs_modeset(crtc->state)) { + lsdc_update_fb_format(ldev, crtc, fb->format); + lsdc_primary_get_default_format(crtc); + } + + if (ldev->dirty_update) { + struct drm_plane_state *old_plane_state; + struct drm_rect damage; + bool valid; + + old_plane_state = drm_atomic_get_old_plane_state(state, plane); + + valid = drm_atomic_helper_damage_merged(old_plane_state, + new_plane_state, + &damage); + if (valid) + lsdc_handle_damage(ldev, fb, &damage, obj->vaddr); + } +} + + +static void lsdc_primary_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_plane_state *new_plane_state; + + new_plane_state = drm_atomic_get_new_plane_state(state, plane); + + drm_dbg_kms(plane->dev, "%s disabled\n", plane->name); +} + + +static int lsdc_plane_prepare_fb(struct drm_plane *plane, + struct drm_plane_state *new_state) +{ +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + struct lsdc_device *ldev = to_lsdc(plane->dev); + + if (ldev->use_vram_helper) + return drm_gem_vram_plane_helper_prepare_fb(plane, new_state); +#endif + return drm_gem_plane_helper_prepare_fb(plane, new_state); +} + + +static void lsdc_plane_cleanup_fb(struct drm_plane *plane, + struct drm_plane_state *old_state) +{ +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + struct drm_device *ddev = plane->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + + if (ldev->use_vram_helper) + return drm_gem_vram_plane_helper_cleanup_fb(plane, old_state); +#endif +} + +static const struct drm_plane_helper_funcs lsdc_primary_plane_helpers = { + .prepare_fb = lsdc_plane_prepare_fb, + .cleanup_fb = lsdc_plane_cleanup_fb, + .atomic_check = lsdc_primary_plane_atomic_check, + .atomic_update = lsdc_primary_plane_atomic_update, + .atomic_disable = lsdc_primary_plane_atomic_disable, +}; + + + +static int lsdc_cursor_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, plane); + struct drm_crtc *crtc = new_plane_state->crtc; + struct drm_framebuffer *fb = new_plane_state->fb; + struct drm_crtc_state *crtc_state; + int ret; + + /* no need for further checks if the plane is being disabled */ + if (!crtc || !fb) + return 0; + + if (!new_plane_state->visible) + return 0; + + crtc_state = drm_atomic_get_new_crtc_state(state, + new_plane_state->crtc); + + ret = drm_atomic_helper_check_plane_state(new_plane_state, + crtc_state, + DRM_PLANE_HELPER_NO_SCALING, + DRM_PLANE_HELPER_NO_SCALING, + true, + true); + if (ret) + return ret; + + if ((fb->width < LSDC_CURS_MIN_SIZE) || + (fb->height < LSDC_CURS_MIN_SIZE) || + (fb->width > LSDC_CURS_MAX_SIZE) || + (fb->height > LSDC_CURS_MAX_SIZE)) { + drm_err(plane->dev, "Invalid cursor size: %dx%d\n", + fb->width, fb->height); + return -EINVAL; + } + + return 0; +} + + +/* Update the location of the cursor */ +static void lsdc_cursor_update_location(struct lsdc_device *ldev, + struct drm_crtc *crtc) +{ + u32 val; + + val = lsdc_reg_read32(ldev, LSDC_CURSOR_CFG_REG); + + if ((val & CURSOR_FORMAT_MASK) == 0) + val |= CURSOR_FORMAT_ARGB8888; + + /* Update the location of the cursor */ + if (drm_crtc_index(crtc)) + val |= CURSOR_LOCATION_BIT; + + lsdc_reg_write32(ldev, LSDC_CURSOR_CFG_REG, val); +} + +/* update the position of the cursor */ +static void lsdc_cursor_update_position(struct lsdc_device *ldev, int x, int y) +{ + if (x < 0) + x = 0; + + if (y < 0) + y = 0; + + lsdc_reg_write32(ldev, LSDC_CURSOR_POSITION_REG, (y << 16) | x); +} + + +static void lsdc_cursor_atomic_update(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = plane->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state, plane); + struct drm_plane_state *old_plane_state = drm_atomic_get_old_plane_state(state, plane); + struct drm_framebuffer *new_fb = new_plane_state->fb; + struct drm_framebuffer *old_fb = old_plane_state->fb; + + if (new_fb != old_fb) { + u64 cursor_addr; + + if (ldev->use_vram_helper) { +#ifdef CONFIG_DRM_LSDC_VRAM_DRIVER + s64 offset = lsdc_get_vram_bo_offset(new_fb); + cursor_addr = ldev->vram_base + offset; + + drm_dbg_kms(ddev, "%s offset: %llx\n", + plane->name, offset); +#endif + } else { + struct drm_gem_cma_object *cursor_obj; + + cursor_obj = drm_fb_cma_get_gem_obj(new_fb, 0); + if (!cursor_obj) + return; + + cursor_addr = cursor_obj->paddr; + } + + lsdc_reg_write32(ldev, LSDC_CURSOR_ADDR_REG, cursor_addr); + } + + lsdc_cursor_update_position(ldev, new_plane_state->crtc_x, + new_plane_state->crtc_y); + + lsdc_cursor_update_location(ldev, new_plane_state->crtc); +} + + +static void lsdc_cursor_atomic_disable(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = plane->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_plane_state *old_plane_state; + struct drm_crtc *crtc; + + old_plane_state = drm_atomic_get_old_plane_state(state, plane); + + if (old_plane_state) + crtc = old_plane_state->crtc; + + lsdc_reg_write32(ldev, LSDC_CURSOR_CFG_REG, 0); + + drm_dbg_kms(ddev, "%s disable\n", plane->name); +} + + +static const struct drm_plane_helper_funcs lsdc_cursor_plane_helpers = { + .prepare_fb = lsdc_plane_prepare_fb, + .cleanup_fb = lsdc_plane_cleanup_fb, + .atomic_check = lsdc_cursor_atomic_check, + .atomic_update = lsdc_cursor_atomic_update, + .atomic_disable = lsdc_cursor_atomic_disable, +}; + + +static int lsdc_plane_get_default_zpos(enum drm_plane_type type) +{ + switch (type) { + case DRM_PLANE_TYPE_PRIMARY: + return 0; + case DRM_PLANE_TYPE_OVERLAY: + return 1; + case DRM_PLANE_TYPE_CURSOR: + return 7; + } + return 0; +} + + +static void lsdc_plane_reset(struct drm_plane *plane) +{ + drm_atomic_helper_plane_reset(plane); + + plane->state->zpos = lsdc_plane_get_default_zpos(plane->type); + + drm_dbg_kms(plane->dev, "%s reset\n", plane->name); +} + + +static const struct drm_plane_funcs lsdc_plane_funcs = { + .update_plane = drm_atomic_helper_update_plane, + .disable_plane = drm_atomic_helper_disable_plane, + .destroy = drm_plane_cleanup, + .reset = lsdc_plane_reset, + .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, +}; + + +int lsdc_plane_init(struct lsdc_device *ldev, struct drm_plane *plane, + enum drm_plane_type type, unsigned int index) +{ + struct drm_device *ddev = &ldev->drm; + int zpos = lsdc_plane_get_default_zpos(type); + unsigned int format_count; + const uint32_t *formats; + const char *name; + int ret; + + switch (type) { + case DRM_PLANE_TYPE_PRIMARY: + formats = lsdc_primary_formats; + format_count = ARRAY_SIZE(lsdc_primary_formats); + name = "primary-%u"; + break; + case DRM_PLANE_TYPE_CURSOR: + formats = lsdc_cursor_formats; + format_count = ARRAY_SIZE(lsdc_cursor_formats); + name = "cursor-%u"; + break; + case DRM_PLANE_TYPE_OVERLAY: + drm_err(ddev, "overlay plane is not supported\n"); + break; + } + + ret = drm_universal_plane_init(ddev, plane, 1 << index, + &lsdc_plane_funcs, + formats, format_count, + lsdc_fb_format_modifiers, + type, name, index); + if (ret) { + drm_err(ddev, "%s failed: %d\n", __func__, ret); + return ret; + } + + switch (type) { + case DRM_PLANE_TYPE_PRIMARY: + drm_plane_helper_add(plane, &lsdc_primary_plane_helpers); + drm_plane_create_zpos_property(plane, zpos, 0, 6); + if (ldev->dirty_update) + drm_plane_enable_fb_damage_clips(plane); + break; + case DRM_PLANE_TYPE_CURSOR: + drm_plane_helper_add(plane, &lsdc_cursor_plane_helpers); + drm_plane_create_zpos_immutable_property(plane, zpos); + break; + case DRM_PLANE_TYPE_OVERLAY: + drm_err(ddev, "overlay plane is not supported\n"); + break; + } + + drm_plane_create_alpha_property(plane); + + return 0; +} diff --git a/drivers/gpu/drm/lsdc/lsdc_pll.c b/drivers/gpu/drm/lsdc/lsdc_pll.c new file mode 100644 index 000000000000..81ec5baeeb56 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_pll.c @@ -0,0 +1,596 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ +#include <drm/drm_print.h> + +#include "lsdc_drv.h" +#include "lsdc_regs.h" +#include "lsdc_pll.h" + +/* device dependent pixpll regs */ + +/* u64 */ +struct ls7a1000_pixpll_bitmap { + /* Byte 0 ~ Byte 3 */ + unsigned div_out : 7; /* 0 : 6 output clock divider */ + unsigned reserved_1 : 14; /* 7 : 20 */ + unsigned loopc : 9; /* 21 : 29 */ + unsigned reserved_2 : 2; /* 30 : 31 */ + + /* Byte 4 ~ Byte 7 */ + unsigned div_ref : 7; /* 0 : 6 input clock divider */ + unsigned locked : 1; /* 7 PLL locked flag */ + unsigned sel_out : 1; /* 8 output clk selector */ + unsigned reserved_3 : 2; /* 9 : 10 reserved */ + unsigned set_param : 1; /* 11 set pll param */ + unsigned bypass : 1; /* 12 */ + unsigned powerdown : 1; /* 13 */ + unsigned reserved_4 : 18; /* 14 : 31 */ +}; + + +/* u128 */ +struct ls2k1000_pixpll_bitmap { + /* Byte 0 ~ Byte 3 */ + unsigned sel_out : 1; /* 0 select this PLL */ + unsigned reserved_1 : 1; /* 1 */ + unsigned sw_adj_en : 1; /* 2 allow software adjust */ + unsigned bypass : 1; /* 3 bypass L1 PLL */ + unsigned reserved_2 : 3; /* 4:6 */ + unsigned lock_en : 1; /* 7 enable lock L1 PLL */ + unsigned reserved_3 : 2; /* 8:9 */ + unsigned lock_check : 2; /* 10:11 precision check */ + unsigned reserved_4 : 4; /* 12:15 */ + + unsigned locked : 1; /* 16 Is L1 PLL locked, RO */ + unsigned reserved_5 : 2; /* 17:18 */ + unsigned powerdown : 1; /* 19 powerdown the pll if set */ + unsigned reserved_6 : 6; /* 20:25 */ + unsigned div_ref : 6; /* 26:31 L1 Prescaler */ + + /* Byte 4 ~ Byte 7 */ + unsigned loopc : 10; /* 32:41 Clock Multiplier */ + unsigned l1_div : 6; /* 42:47 not used */ + unsigned reserved_7 : 16; /* 48:63 */ + + /* Byte 8 ~ Byte 15 */ + unsigned div_out : 6; /* 0 : 5 output clock divider */ + unsigned reserved_8 : 26; /* 6 : 31 */ + unsigned reserved_9 : 32; /* 70: 127 */ +}; + + +/* u32 */ +struct ls2k0500_pixpll_bitmap { + /* Byte 0 ~ Byte 1 */ + unsigned sel_out : 1; + unsigned reserved_1 : 2; + unsigned sw_adj_en : 1; /* allow software adjust */ + unsigned bypass : 1; /* bypass L1 PLL */ + unsigned powerdown : 1; /* write 1 to powerdown the PLL */ + unsigned reserved_2 : 1; + unsigned locked : 1; /* 7 Is L1 PLL locked, read only */ + unsigned div_ref : 6; /* 8:13 ref clock divider */ + unsigned reserved_3 : 2; /* 14:15 */ + /* Byte 2 ~ Byte 3 */ + unsigned loopc : 8; /* 16:23 Clock Multiplier */ + unsigned div_out : 6; /* 24:29 output clock divider */ + unsigned reserved_4 : 2; /* 30:31 */ +}; + + +/* + * NOTE: All loongson's cpu is little endian. + * The length of this structure should be 8 bytes + */ +union lsdc_pix_pll_param { + struct ls7a1000_pixpll_bitmap ls7a1000; + struct ls2k1000_pixpll_bitmap ls2k1000; + struct ls2k0500_pixpll_bitmap ls2k0500; + + u32 word[4]; + u64 qword[2]; +}; + +/* + * pixel clock to pll parameters translation table + */ +struct pixclk_to_pll_parm { + /* kHz */ + unsigned int clock; + + /* unrelated information */ + unsigned short width; + unsigned short height; + unsigned short vrefresh; + + /* Stores parameters for programming the Hardware PLLs */ + unsigned short div_out; + unsigned short loopc; + unsigned short div_ref; +}; + + +/* + * Small cached value to speed up pll parameter calculation + */ +static const struct pixclk_to_pll_parm pll_param_table[] = { + {148500, 1920, 1080, 60, 11, 49, 3}, /* 1920x1080@60Hz */ + /* 1920x1080@50Hz */ + {174500, 1920, 1080, 75, 17, 89, 3}, /* 1920x1080@75Hz */ + {181250, 2560, 1080, 75, 8, 58, 4}, /* 2560x1080@75Hz */ + {146250, 1680, 1050, 60, 16, 117, 5}, /* 1680x1050@60Hz */ + {135000, 1280, 1024, 75, 10, 54, 4}, /* 1280x1024@75Hz */ + + {108000, 1600, 900, 60, 15, 81, 5}, /* 1600x900@60Hz */ + /* 1280x1024@60Hz */ + /* 1280x960@60Hz */ + /* 1152x864@75Hz */ + + {106500, 1440, 900, 60, 19, 81, 4}, /* 1440x900@60Hz */ + {88750, 1440, 900, 60, 16, 71, 5}, /* 1440x900@60Hz */ + {83500, 1280, 800, 60, 17, 71, 5}, /* 1280x800@60Hz */ + {71000, 1280, 800, 60, 20, 71, 5}, /* 1280x800@60Hz */ + + {74250, 1280, 720, 60, 22, 49, 3}, /* 1280x720@60Hz */ + /* 1280x720@50Hz */ + + {78750, 1024, 768, 75, 16, 63, 5}, /* 1024x768@75Hz */ + {75000, 1024, 768, 70, 29, 87, 4}, /* 1024x768@70Hz */ + {65000, 1024, 768, 60, 20, 39, 3}, /* 1024x768@60Hz */ + + {51200, 1024, 600, 60, 25, 64, 5}, /* 1024x600@60Hz */ + + {57284, 832, 624, 75, 24, 55, 4}, /* 832x624@75Hz */ + {49500, 800, 600, 75, 40, 99, 5}, /* 800x600@75Hz */ + {50000, 800, 600, 72, 44, 88, 4}, /* 800x600@72Hz */ + {40000, 800, 600, 60, 30, 36, 3}, /* 800x600@60Hz */ + {36000, 800, 600, 56, 50, 72, 4}, /* 800x600@56Hz */ + {31500, 640, 480, 75, 40, 63, 5}, /* 640x480@75Hz */ + /* 640x480@73Hz */ + + {30240, 640, 480, 67, 62, 75, 4}, /* 640x480@67Hz */ + {27000, 720, 576, 50, 50, 54, 4}, /* 720x576@60Hz */ + {25175, 640, 480, 60, 85, 107, 5}, /* 640x480@60Hz */ + {25200, 640, 480, 60, 50, 63, 5}, /* 640x480@60Hz */ + /* 720x480@60Hz */ +}; + + +static int lsdc_pixpll_setup(struct lsdc_pll * const this) +{ + this->mmio = ioremap(this->reg_base, this->reg_size); + + drm_info(this->ddev, "PIXPLL%u REG[%x, %u] map to %llx\n", + this->index, this->reg_base, this->reg_size, (u64)this->mmio); + + return 0; +} + + +/** + * lsdc_crtc_init + * + * @ddev: point to the drm_device structure + * @index: hardware crtc index + * + * Init CRTC + */ + +/* + * Find a set of pll parameters (to generate pixel clock) from a static + * local table, which avoid to compute the pll parameter everytime a + * modeset is triggered. + * + * @clock: the desired pixel clock wanted to generate, the unit is kHz + * @pout: pointer to where hardware pll parameters(if found) to save + * + * Return true if a parameter is found, otherwise return false. + */ +static bool lsdc_pixpll_find(struct lsdc_pll * const this, + unsigned int clock, + struct lsdc_pll_core_values * const pout) +{ + unsigned int num = ARRAY_SIZE(pll_param_table); + unsigned int i; + + for (i = 0; i < num; i++) { + if (clock != pll_param_table[i].clock) + continue; + + pout->div_ref = pll_param_table[i].div_ref; + pout->loopc = pll_param_table[i].loopc; + pout->div_out = pll_param_table[i].div_out; + + return true; + } + + drm_dbg(this->ddev, "pixel clock %u: miss\n", clock); + + return false; +} + +/* + * Find a set of pll parameters which have minimal difference with desired + * clock frequency. It does that by computing the all of pll parameters + * combines possible and compare the diff and find the minimal. + * + * clock_out = refclk / div_ref * loopc / div_out + * + * refclk is fixed as 100MHz in ls7a1000, ls2k1000 and ls2k0500 + * + * @clk: the desired pixel clock wanted to generate, the unit is kHz + * @pout: pointer to where hardware pll parameters(if found) to save + * @verbose: print the pll parameter and the actual pixel clock. + * + * Return true if a parameter is found, otherwise return false. + */ +static bool lsdc_pixpll_compute(struct lsdc_pll * const this, + unsigned int clk, + bool verbose, + struct lsdc_pll_core_values * const pout) +{ + unsigned int refclk = this->ref_clock; + const unsigned int tolerance = 1000; + unsigned int min = tolerance; + unsigned int div_out, loopc, div_ref; + + if (lsdc_pixpll_find(this, clk, pout)) + return true; + + for (div_out = 6; div_out < 64; div_out++) { + for (div_ref = 3; div_ref < 6; div_ref++) { + for (loopc = 6; loopc < 161; loopc++) { + int diff; + + if (loopc < 12 * div_ref) + continue; + if (loopc > 32 * div_ref) + continue; + + diff = clk * div_out - refclk * loopc / div_ref; + + if (diff < 0) + diff = -diff; + + if (diff < min) { + min = diff; + pout->div_ref = div_ref; + pout->div_out = div_out; + pout->loopc = loopc; + + if (diff == 0) + return true; + } + } + } + } + + if (verbose) { + unsigned int clk_out; + + clk_out = refclk / pout->div_ref * pout->loopc / pout->div_out; + + drm_info(this->ddev, "pixpll%u\n", this->index); + + drm_info(this->ddev, "div_ref=%u, loopc=%u, div_out=%u\n", + pout->div_ref, pout->loopc, pout->div_out); + + drm_info(this->ddev, "desired clk=%u, actual out=%u, diff=%d\n", + clk, clk_out, clk_out - clk); + } + + return min < tolerance; +} + + +static int ls7a1000_pixpll_param_update(struct lsdc_pll * const this, + const struct lsdc_pll_core_values * const param) +{ + u32 val; + unsigned int counter = 0; + void __iomem *reg = this->mmio; + bool locked; + + + /* clear sel_pll_out0 */ + val = readl(reg + 0x4); + val &= ~(1 << 8); + writel(val, reg + 0x4); + + /* set pll_pd */ + val = readl(reg + 0x4); + val |= (1 << 13); + writel(val, reg + 0x4); + + /* clear set_pll_param */ + val = readl(reg + 0x4); + val &= ~(1 << 11); + writel(val, reg + 0x4); + + /* clear old value & config new value */ + val = readl(reg + 0x04); + val &= ~0x7F; + + val |= param->div_ref; /* div_ref */ + writel(val, reg + 0x4); + + val = readl(reg); + val &= ~(0x7f << 0); + val |= param->div_out; /* div_out */ + val &= ~(0x1ffUL << 21); + val |= param->loopc << 21; /* loopc */ + writel(val, reg); + + /* set set_pll_param */ + val = readl(reg + 0x4); + val |= (1 << 11); + writel(val, reg + 0x4); + + /* clear pll_pd */ + val = readl(reg + 0x4); + val &= ~(1 << 13); + writel(val, reg + 0x4); + + /* wait pll lock */ + do { + val = readl(reg + 0x4); + locked = val & 0x80; + counter++; + } while (locked == false); + + drm_dbg_kms(this->ddev, "%u loop waited\n", counter); + + /* set sel_pll_out0 */ + val = readl(reg + 0x4); + val |= (1UL << 8); + writel(val, reg + 0x4); + + return 0; +} + + +/* + * the PIX PLL be software configurable when SYS_CLKSEL[1:0] is 10b + */ +static int ls2k1000_pixpll_param_update(struct lsdc_pll * const this, + const struct lsdc_pll_core_values * const param) +{ + void __iomem *reg = this->mmio; + u64 val = readq(reg); + bool locked; + unsigned int counter = 0; + + val &= ~(1 << 0); /* Bypass the PLL, using refclk directly */ + val |= (1 << 19); /* powerdown the PLL */ + val &= ~(1 << 2); /* don't use the software configure param */ + writeq(val, reg); + + val = (1L << 7) | (1L << 42) | (3L << 10); /* allow L1 PLL locked */ + val |= (unsigned long)param->loopc << 32; /* set loopc */ + val |= (unsigned long)param->div_ref << 26; /* set div_ref */ + writeq(val, reg); + writeq(param->div_out, reg + 8); /* set div_out */ + + val = readq(reg); + val |= (1 << 2); /* use the software configure param */ + val &= ~(1 << 19); /* powerup the PLL */ + writeq(val, reg); + + /* wait pll setup and locked */ + do { + val = readl(reg); + locked = val & 0x10000; + counter++; + } while (locked == false); + + drm_dbg_kms(this->ddev, "%u loop waited\n", counter); + + val = readq(reg); + val |= (1 << 0); /* switch to the software configured pll */ + writeq(val, reg); + + return 0; +} + + +static int ls2k0500_pixpll_param_update(struct lsdc_pll * const this, + const struct lsdc_pll_core_values * const param) +{ + void __iomem *reg = this->mmio; + u64 val; + + /* set sel_pll_out0 0 */ + val = readq(reg); + val &= ~(1UL << 0); + writeq(val, reg); + + /* pll_pd 1 */ + val = readq(reg); + val |= (1UL << 5); + writeq(val, reg); + + val = (param->div_out << 24) | + (param->loopc << 16) | + (param->div_ref << 8); + + writeq(val, reg); + val |= (1U << 3); + writeq(val, reg); + + while (!(readq(reg) & 0x80)) + ; + writeq((val | 1), reg); + + return 0; +} + + +#define LSDC_PIXPLL_BITMAP(type,var,parms) \ + struct type ## _pixpll_bitmap *var = &parms.type + +#define LSDC_PIXPLL_PRINT_CODE_BLOCK(ddev,var,index,refclk) \ +{ \ + out_clk = refclk / var->div_ref * var->loopc / var->div_out; \ + drm_info(ddev, "div_ref=%u, loopc=%u, div_out=%u\n", \ + var->div_ref, var->loopc, var->div_out); \ + drm_info(ddev, "locked: %s\n", var->locked ? "Yes" : "No"); \ + drm_info(ddev, "bypass: %s\n", var->bypass ? "Yes" : "No"); \ + drm_info(ddev, "powerdown: %s\n", var->powerdown ? "Yes" : "No"); \ + drm_info(ddev, "set_out: %s\n", var->sel_out ? "Yes" : "No"); \ + drm_info(ddev, "pixpll%u generate %ukHz\n", index, out_clk); \ + drm_info(ddev, "\n"); \ +} + +/* lsdc_print_clock - print clock related parameters + * + * clock_out = refclk / div_ref * loopc / divout + * + * also print the precision information + */ +static void lsdc_pixpll_print(struct lsdc_pll * const this, unsigned int pixclk) +{ + struct drm_device *ddev = this->ddev; + struct lsdc_device *ldev = to_lsdc(ddev); + const struct lsdc_chip_desc * const ip = ldev->desc; + unsigned short index = this->index; + unsigned int refclk = this->ref_clock; + unsigned int out_clk; + union lsdc_pix_pll_param parms; + + if (ip->chip == LSDC_CHIP_7A1000) { + /* struct ls7a1000_pixpll_bitmap *obj = &parms.ls7a1000; */ + LSDC_PIXPLL_BITMAP(ls7a1000, obj, parms); + parms.qword[0] = readq(this->mmio); + LSDC_PIXPLL_PRINT_CODE_BLOCK(ddev, obj, index, refclk); + } else if (ip->chip == LSDC_CHIP_2K1000) { + /* struct ls2k1000_pixpll_bitmap *obj = &parms.ls2k1000; */ + LSDC_PIXPLL_BITMAP(ls2k1000, obj, parms); + parms.qword[0] = readq(this->mmio); + parms.qword[1] = readq(this->mmio + 8); + LSDC_PIXPLL_PRINT_CODE_BLOCK(ddev, obj, index, refclk); + } else if (ip->chip == LSDC_CHIP_2K0500) { + /* struct ls2k0500_pixpll_bitmap *obj = &parms.ls2k0500; */ + LSDC_PIXPLL_BITMAP(ls2k0500, obj, parms); + parms.word[0] = readl(this->mmio); + LSDC_PIXPLL_PRINT_CODE_BLOCK(ddev, obj, index, refclk); + } else { + drm_err(ddev, "unknown chip, the driver need update\n"); + return; + } +} + + +static unsigned int lsdc_get_clock_rate(struct lsdc_pll * const this) +{ + struct lsdc_pll_core_values * const parms = &this->core_params; + unsigned int clk_out = this->ref_clock / parms->div_ref; + + clk_out = clk_out * parms->loopc / parms->div_out; + + return clk_out; +} + + +static const struct lsdc_pixpll_funcs ls7a1000_pixpll_funcs = { + .setup = lsdc_pixpll_setup, + .compute = lsdc_pixpll_compute, + .update = ls7a1000_pixpll_param_update, + .get_clock_rate = lsdc_get_clock_rate, + + .print = lsdc_pixpll_print, +}; + +static const struct lsdc_pixpll_funcs ls2k1000_pixpll_funcs = { + .setup = lsdc_pixpll_setup, + .compute = lsdc_pixpll_compute, + .update = ls2k1000_pixpll_param_update, + .get_clock_rate = lsdc_get_clock_rate, + + .print = lsdc_pixpll_print, +}; + +static const struct lsdc_pixpll_funcs ls2k0500_pixpll_funcs = { + .setup = lsdc_pixpll_setup, + .compute = lsdc_pixpll_compute, + .update = ls2k0500_pixpll_param_update, + .get_clock_rate = lsdc_get_clock_rate, + + .print = lsdc_pixpll_print, +}; + + +int lsdc_pixpll_init(struct lsdc_pll * const this, + struct drm_device *ddev, + unsigned int index) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + const struct lsdc_chip_desc *ip = ldev->desc; + + this->ddev = ddev; + this->index = index; + this->ref_clock = LSDC_PLL_REF_CLK; + + if (ip->chip == LSDC_CHIP_7A1000) { + if (index == 0) + this->reg_base = LS7A1000_CFG_REG_BASE + + LS7A1000_PIX_PLL0_REG; + else if (index == 1) + this->reg_base = LS7A1000_CFG_REG_BASE + + LS7A1000_PIX_PLL1_REG; + this->reg_size = 8; + this->funcs = &ls7a1000_pixpll_funcs; + } else if (ip->chip == LSDC_CHIP_2K1000) { + if (index == 0) + this->reg_base = LS2K1000_CFG_REG_BASE + + LS2K1000_PIX_PLL0_REG; + else if (index == 1) + this->reg_base = LS2K1000_CFG_REG_BASE + + LS2K1000_PIX_PLL1_REG; + + this->reg_size = 16; + this->funcs = &ls2k1000_pixpll_funcs; + } else if (ip->chip == LSDC_CHIP_2K0500) { + if (index == 0) + this->reg_base = LS2K0500_CFG_REG_BASE + + LS2K0500_PIX_PLL0_REG; + else if (index == 1) + this->reg_base = LS2K0500_CFG_REG_BASE + + LS2K0500_PIX_PLL1_REG; + + this->reg_size = 4; + this->funcs = &ls2k0500_pixpll_funcs; + } else { + DRM_ERROR("unknown chip, the driver need update\n"); + return -ENOENT; + } + + /* call funcs->init only once */ + return this->funcs->setup(this); +} diff --git a/drivers/gpu/drm/lsdc/lsdc_pll.h b/drivers/gpu/drm/lsdc/lsdc_pll.h new file mode 100644 index 000000000000..4f8aa5144858 --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_pll.h @@ -0,0 +1,109 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright (C) 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#ifndef __LSDC_PLL_H__ +#define __LSDC_PLL_H__ + +#include <drm/drm_device.h> + +/* + * PIXEL PLL structure + * + * refclk: reference frequency, 100 MHz form external oscillator + * outclk: output frequency desired. + * + * + * L1 Fref Fvco L2 + * refclk +-----------+ +------------------+ +---------+ outclk + * -------> | Prescaler | ---> | Clock Multiplier | ---> | divider | ---------> + * | +-----------+ +------------------+ +---------+ ^ + * | ^ ^ ^ | + * | | | | | + * | | | | | + * | div_ref loopc div_out | + * | | + * +------------- sel_out (=1 => bypass above clock) -----------------+ + * + * + * outclk = refclk / div_ref * loopc / div_out; + * + * PLL hardware working requirements: + * + * 1) 20 MHz <= refclk / div_ref <= 40Mhz + * 2) 1.2 GHz <= refclk /div_out * loopc <= 3.2 Ghz + * + */ + +struct lsdc_pll_core_values { + unsigned short div_ref; + unsigned short loopc; + unsigned short div_out; +}; + +struct lsdc_pll; + +struct lsdc_pixpll_funcs { + int (*setup)(struct lsdc_pll * const this); + bool (*compute)(struct lsdc_pll * const this, + unsigned int clock, + bool verbose, + struct lsdc_pll_core_values * const params_out); + int (*update)(struct lsdc_pll * const this, + const struct lsdc_pll_core_values * const params_in); + + void (*print)(struct lsdc_pll * const this, unsigned int clock); + + unsigned int (*get_clock_rate)(struct lsdc_pll * const this); +}; + + +struct lsdc_pll { + const struct lsdc_pixpll_funcs *funcs; + struct drm_device *ddev; + void __iomem *mmio; + + /* Reg offset of the PLL */ + u32 reg_base; + u32 reg_size; + + struct lsdc_pll_core_values core_params; + + /* Stores parameters for programming the PLLs */ + unsigned int ref_clock; /* 100000kHz, fixed */ + + unsigned short index; +}; + + +int lsdc_pixpll_init(struct lsdc_pll * const this, + struct drm_device *ddev, + unsigned int index); + +#endif diff --git a/drivers/gpu/drm/lsdc/lsdc_regs.h b/drivers/gpu/drm/lsdc/lsdc_regs.h new file mode 100644 index 000000000000..69f7c63a7b1a --- /dev/null +++ b/drivers/gpu/drm/lsdc/lsdc_regs.h @@ -0,0 +1,242 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright (C) 2020 Loongson Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the + * "Software"), to deal in the Software without restriction, including + * without limitation the rights to use, copy, modify, merge, publish, + * distribute, sub license, and/or sell copies of the Software, and to + * permit persons to whom the Software is furnished to do so, subject to + * the following conditions: + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, + * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR + * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE + * USE OR OTHER DEALINGS IN THE SOFTWARE. + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + */ + +/* + * Authors: + * Sui Jingfeng <suijingfeng(a)loongson.cn> + */ + +#ifndef __LSDC_REGS_H__ +#define __LSDC_REGS_H__ + +/* + * PLL + */ +#define LSDC_PLL_REF_CLK 100000 /* kHz */ +#define PCLK_PRECISION_INDICATOR 10000 + + +/* + * Those PLL registers is not in dc's bar space, + * there are relative to LSXX1000_CFG_REG_BASE. + */ + +/* LS2K1000 */ +#define LS2K1000_DC_PLL_REG 0x04A0 + +#define LS2K1000_PIX_PLL0_REG 0x04B0 +#define LS2K1000_PIX_PLL1_REG 0x04C0 + +#define LS2K1000_CFG_REG_BASE 0x1fe10000 + +/* LS7A1000 */ +#define LS7A1000_DC_PLL_REG 0x0490 + +#define LS7A1000_PIX_PLL0_REG 0x04B0 +#define LS7A1000_PIX_PLL1_REG 0x04C0 + +#define LS7A1000_CFG_REG_BASE 0x10010000 + +/* LS2K0500 */ +#define LS2K0500_PIX_PLL0_REG 0x0418 +#define LS2K0500_PIX_PLL1_REG 0x0420 + +#define LS2K0500_CFG_REG_BASE 0x1fe10000 + + +/* + * CRTC CFG REG + */ +#define CFG_PIX_FMT_MASK 0x07 + + +#define CFG_PAGE_FLIP_BIT BIT(7) /* triger pageflip */ +#define CFG_OUTPUT_EN_BIT BIT(8) +#define CFG_PANEL_SWITCH BIT(9) +/* Indicate witch framebuffer addr reg is in using */ +#define CFG_FB_IDX_BIT BIT(11) +#define CFG_GAMMAR_EN_BIT BIT(12) +#define CFG_DC_DMA_MASK GENMASK(17, 16) + +/* crtc get soft reset if voltage level change from 1 -> 0 */ +#define CFG_RESET_BIT BIT(20) + +#define EN_HSYNC_BIT BIT(30) +#define INV_HSYNC_BIT BIT(31) + +#define EN_VSYNC_BIT BIT(30) +#define INV_VSYNC_BIT BIT(31) + + +/******** CRTC0 & DVO0 ********/ + +#define LSDC_CRTC0_CFG_REG 0x1240 + +#define LSDC_CRTC0_FB_ADDR0_REG 0x1260 +#define LSDC_CRTC0_FB_ADDR1_REG 0x1580 + +#define LSDC_CRTC0_STRIDE_REG 0x1280 +#define LSDC_CRTC0_FB_ORIGIN_REG 0x1300 +#define LSDC_CRTC0_HDISPLAY_REG 0x1400 +#define LSDC_CRTC0_HSYNC_REG 0x1420 +#define LSDC_CRTC0_VDISPLAY_REG 0x1480 +#define LSDC_CRTC0_VSYNC_REG 0x14a0 + + +/******** CTRC1 & DVO1 ********/ + +#define LSDC_CRTC1_CFG_REG 0x1250 + +#define LSDC_CRTC1_FB_ADDR0_REG 0x1270 +#define LSDC_CRTC1_FB_ADDR1_REG 0x1590 + +#define LSDC_CRTC1_STRIDE_REG 0x1290 +#define LSDC_CRTC1_FB_ORIGIN_REG 0x1310 +#define LSDC_CRTC1_HDISPLAY_REG 0x1410 +#define LSDC_CRTC1_HSYNC_REG 0x1430 +#define LSDC_CRTC1_VDISPLAY_REG 0x1490 +#define LSDC_CRTC1_VSYNC_REG 0x14b0 + + +/* + * Hardware cursor + * There is only one hardware cursor shared by two crtc in ls7a1000, + * ls2k1000 and ls2k0500, but ls7a2000 have two Hardware cursor. + */ +#define LSDC_CURSOR_CFG_REG 0x1520 + +#define CURSOR_FORMAT_MASK 0x03 +#define CURSOR_FORMAT_DISABLE 0 +#define CURSOR_FORMAT_MONOCHROME BIT(0) +#define CURSOR_FORMAT_ARGB8888 BIT(1) +#define CURSOR_LOCATION_BIT BIT(4) + +#define LSDC_CURSOR_ADDR_REG 0x1530 +#define LSDC_CURSOR_POSITION_REG 0x1540 +#define LSDC_CURSOR_BG_COLOR_REG 0x1550 /* background color */ +#define LSDC_CURSOR_FG_COLOR_REG 0x1560 /* foreground color */ + +#define CUR_WIDTH_SIZE 32 +#define CUR_HEIGHT_SIZE 32 + +#define LSDC_CURS_MIN_SIZE 1 +#define LSDC_CURS_MAX_SIZE 64 + +/* + * DC Interrupt Control Register, 32bit, Address Offset: 1570 + * + * Bits 0:10 inidicate the interrupt type, read only + * Bits 16:26 control if the specific interrupt corresponding to bit 0~10 + * is enabled or not. Write 1 to enable, write 0 to disable + * + * RF: Read Finished + * IDBU : Internal Data Buffer Underflow + * IDBFU : Internal Data Buffer Fatal Underflow + * + * + * +-------+-------------------------------+-------+--------+--------+-------+ + * | 31:27 | 26:16 | 15:11 | 10 | 9 | 8 | + * +-------+-------------------------------+-------+--------+--------+-------+ + * | N/A | Interrupt Enable Control Bits | N/A | IDBFU0 | IDBFU1 | IDBU0 | + * +-------+-------------------------------+-------+--------+--------+-------+ + * + * Bit 4 is cursor buffer read finished, no use. + * + * +-------+-----+-----+-----+--------+--------+--------+--------+ + * | 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 | + * +-------+-----+-----+-----+--------+--------+--------+--------+ + * | IDBU1 | RF0 | RF1 | | HSYNC0 | VSYNC0 | HSYNC1 | VSYNC1 | + * +-------+-----+-----+-----+--------+--------+--------+--------+ + * + */ + +#define LSDC_INT_REG 0x1570 + +#define INT_CRTC0_VS BIT(2) +#define INT_CRTC0_HS BIT(3) +#define INT_CRTC0_RF BIT(6) +#define INT_CRTC0_IDBU BIT(8) +#define INT_CRTC0_IDBFU BIT(10) + +#define INT_CURSOR_RF BIT(4) + +#define INT_CRTC1_VS BIT(0) +#define INT_CRTC1_HS BIT(1) +#define INT_CRTC1_RF BIT(5) +#define INT_CRTC1_IDBU BIT(7) +#define INT_CRTC1_IDBFU BIT(9) + + +#define INT_CRTC0_VS_EN BIT(18) +#define INT_CRTC0_HS_EN BIT(19) +#define INT_CRTC0_RF_EN BIT(22) +#define INT_CRTC0_IDBU_EN BIT(24) +#define INT_CRTC0_IDBFU_EN BIT(26) + +#define INT_CURSOR_RF_EN BIT(20) + +#define INT_CRTC1_VS_EN BIT(16) +#define INT_CRTC1_HS_EN BIT(17) +#define INT_CRTC1_RF_EN BIT(21) +#define INT_CRTC1_IDBU_EN BIT(23) +#define INT_CRTC1_IDBFU_EN BIT(25) + + +#define INT_STATUS_MASK GENMASK(10, 0) + + +/* + * LS7A1000 have 4 gpio which is under control of the LS7A_DC_GPIO_DAT_REG + * and LS7A_DC_GPIO_DIR_REG register, it has no relationship whth the general + * GPIO hardware as those two registers are in the DC register space on + * LS7A1000. + * + * This driver using those GPIO to emulated I2C, for reading edid and + * monitor detection + * + * LS2k1000 and LS2K0500 don't have those registers, they use harware i2c or + * generial GPIO emulated i2c from other module. + * + * GPIO data register + * Address offset: 0x1650 + * +---------------+-----------+-----------+ + * | 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 | + * +---------------+-----------+-----------+ + * | | DVO1 | DVO0 | + * + N/A +-----------+-----------+ + * | | SCL | SDA | SCL | SDA | + * +---------------+-----------+-----------+ + */ +#define LS7A_DC_GPIO_DAT_REG 0x1650 + +/* + * GPIO Input/Output direction control register + * Address offset: 0x1660 + * write 1 for Input, 0 for Output. + */ +#define LS7A_DC_GPIO_DIR_REG 0x1660 + + +#endif -- 2.20.1

1 0

[Bug 204611] New: amdgpu error scheduling IBs when waking from sleep
by bugzilla-daemon＠bugzilla.kernel.org 30 Jan '22

30 Jan '22

https://bugzilla.kernel.org/show_bug.cgi?id=204611 Bug ID: 204611 Summary: amdgpu error scheduling IBs when waking from sleep Product: Drivers Version: 2.5 Kernel Version: 5.2.9 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: tones111(a)hotmail.com Regression: No Created attachment 284485 --> https://bugzilla.kernel.org/attachment.cgi?id=284485&action=edit journalctl: amdgpu lockup on resume from sleep. My system locks up when trying to wake from sleep (open lid). The screen remains black and is unresponsive to keyboard/mouse input. I'm able to ssh from another machine and have attached the output from journalctl -b. The log shows scrolling errors... kernel: [drm:amdgpu_job_run [amdgpu]] *ERROR* Error scheduling IBs (-22) kernel: amdgpu 0000:05:00.0: couldn't schedule ib on ring <gfx> This is a Lenovo E585 laptop with an AMD R5 2500U APU. -- You are receiving this mail because: You are watching the assignee of the bug.

2 15

Re: [PATCH 1/1] drm/lsdc: add drm driver for loongson display controller
by Randy Dunlap 29 Jan '22

29 Jan '22

Hi-- On 1/29/22 12:33, suijingfeng wrote: > diff --git a/drivers/gpu/drm/lsdc/Kconfig b/drivers/gpu/drm/lsdc/Kconfig > new file mode 100644 > index 000000000000..744009dfcdde > --- /dev/null > +++ b/drivers/gpu/drm/lsdc/Kconfig > @@ -0,0 +1,32 @@ > +config DRM_LSDC > + tristate "DRM Support for loongson's display controller" > + depends on DRM && PCI > + depends on MACH_LOONGSON64 || LOONGARCH || MIPS || COMPILE_TEST > + select OF > + select CMA if HAVE_DMA_CONTIGUOUS > + select DMA_CMA if HAVE_DMA_CONTIGUOUS > + select DRM_KMS_HELPER > + select DRM_KMS_FB_HELPER > + select DRM_GEM_CMA_HELPER > + select VIDEOMODE_HELPERS > + select BACKLIGHT_PWM if CPU_LOONGSON2K > + select I2C_GPIO if CPU_LOONGSON2K > + select I2C_LS2X if CPU_LOONGSON2K > + default m > + help > + This is a KMS driver for the display controller in the LS7A1000 > + bridge chip and LS2K1000 SoC. The display controller have two has two > + display pipes and it is a pci device. PCI device. > + When using it on LS2K1000/LS2K0500 SoC, its framebuffer is > + located at system memory. > + If "M" is selected, the module will be called lsdc. > + > + If in doubt, say "Y". > + > +config DRM_LSDC_VRAM_DRIVER > + bool "vram helpper based device driver support" helper > + depends on DRM_LSDC > + select DRM_VRAM_HELPER > + default y > + help > + If in doubt, say "n". -- ~Randy

1 0

[PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()
by Zhou Qingyang 29 Jan '22

29 Jan '22

In nvkm_acr_hsfw_load_bl(), the return value of kmalloc() is directly passed to memcpy(), which could lead to undefined behavior on failure of kmalloc(). Fix this bug by using kmemdup() instead of kmalloc()+memcpy(). This bug was found by a static analyzer. Builds with 'make allyesconfig' show no new warnings, and our static analyzer no longer warns about this code. Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"") Signed-off-by: Zhou Qingyang <zhou1615(a)umn.edu> --- The analysis employs differential checking to identify inconsistent security operations (e.g., checks or kfrees) between two code paths and confirms that the inconsistent operations are not recovered in the current function or the callers, so they constitute bugs. Note that, as a bug found by static analysis, it can be a false positive or hard to trigger. Multiple researchers have cross-reviewed the bug. drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c index 667fa016496e..a6ea89a5d51a 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c @@ -142,11 +142,12 @@ nvkm_acr_hsfw_load_bl(struct nvkm_acr *acr, const char *name, int ver, hsfw->imem_size = desc->code_size; hsfw->imem_tag = desc->start_tag; - hsfw->imem = kmalloc(desc->code_size, GFP_KERNEL); - memcpy(hsfw->imem, data + desc->code_off, desc->code_size); - + hsfw->imem = kmemdup(data + desc->code_off, desc->code_size, GFP_KERNEL); nvkm_firmware_put(fw); - return 0; + if (!hsfw->imem) + return -ENOMEM; + else + return 0; } int -- 2.25.1

6 14

Patch "drm/atomic: Add the crtc to affected crtc only if uapi.enable = true" has been added to the 5.15-stable tree
by gregkh＠linuxfoundation.org 29 Jan '22

29 Jan '22

This is a note to let you know that I've just added the patch titled drm/atomic: Add the crtc to affected crtc only if uapi.enable = true to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: drm-atomic-add-the-crtc-to-affected-crtc-only-if-uapi.enable-true.patch and it can be found in the queue-5.15 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From 5ec1cebd59300ddd26dbaa96c17c508764eef911 Mon Sep 17 00:00:00 2001 From: Manasi Navare <manasi.d.navare(a)intel.com> Date: Mon, 4 Oct 2021 04:59:13 -0700 Subject: drm/atomic: Add the crtc to affected crtc only if uapi.enable = true MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Manasi Navare <manasi.d.navare(a)intel.com> commit 5ec1cebd59300ddd26dbaa96c17c508764eef911 upstream. In case of a modeset where a mode gets split across multiple CRTCs in the driver specific implementation (bigjoiner in i915) we wrongly count the affected CRTCs based on the drm_crtc_mask and indicate the stolen CRTC as an affected CRTC in atomic_check_only(). This triggers a warning since affected CRTCs doent match requested CRTC. To fix this in such bigjoiner configurations, we should only increment affected crtcs if that CRTC is enabled in UAPI not if it is just used internally in the driver to split the mode. v3: Add the same uapi crtc_state->enable check in requested crtc calc (Ville) Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Cc: Simon Ser <contact(a)emersion.fr> Cc: Pekka Paalanen <pekka.paalanen(a)collabora.co.uk> Cc: Daniel Stone <daniels(a)collabora.com> Cc: Daniel Vetter <daniel.vetter(a)intel.com> Cc: dri-devel(a)lists.freedesktop.org Cc: <stable(a)vger.kernel.org> # v5.11+ Fixes: 919c2299a893 ("drm/i915: Enable bigjoiner") Signed-off-by: Manasi Navare <manasi.d.navare(a)intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211004115913.23889-1-manasi… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/drm_atomic.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1310,8 +1310,10 @@ int drm_atomic_check_only(struct drm_ato DRM_DEBUG_ATOMIC("checking %p\n", state); - for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) - requested_crtc |= drm_crtc_mask(crtc); + for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) { + if (new_crtc_state->enable) + requested_crtc |= drm_crtc_mask(crtc); + } for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) { ret = drm_atomic_plane_check(old_plane_state, new_plane_state); @@ -1360,8 +1362,10 @@ int drm_atomic_check_only(struct drm_ato } } - for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) - affected_crtc |= drm_crtc_mask(crtc); + for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) { + if (new_crtc_state->enable) + affected_crtc |= drm_crtc_mask(crtc); + } /* * For commits that allow modesets drivers can add other CRTCs to the Patches currently in stable-queue which might be from manasi.d.navare(a)intel.com are queue-5.15/drm-atomic-add-the-crtc-to-affected-crtc-only-if-uapi.enable-true.patch

1 0

Patch "drm/atomic: Add the crtc to affected crtc only if uapi.enable = true" has been added to the 5.16-stable tree
by gregkh＠linuxfoundation.org 29 Jan '22

29 Jan '22

This is a note to let you know that I've just added the patch titled drm/atomic: Add the crtc to affected crtc only if uapi.enable = true to the 5.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=sum… The filename of the patch is: drm-atomic-add-the-crtc-to-affected-crtc-only-if-uapi.enable-true.patch and it can be found in the queue-5.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable(a)vger.kernel.org> know about it. >From 5ec1cebd59300ddd26dbaa96c17c508764eef911 Mon Sep 17 00:00:00 2001 From: Manasi Navare <manasi.d.navare(a)intel.com> Date: Mon, 4 Oct 2021 04:59:13 -0700 Subject: drm/atomic: Add the crtc to affected crtc only if uapi.enable = true MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Manasi Navare <manasi.d.navare(a)intel.com> commit 5ec1cebd59300ddd26dbaa96c17c508764eef911 upstream. In case of a modeset where a mode gets split across multiple CRTCs in the driver specific implementation (bigjoiner in i915) we wrongly count the affected CRTCs based on the drm_crtc_mask and indicate the stolen CRTC as an affected CRTC in atomic_check_only(). This triggers a warning since affected CRTCs doent match requested CRTC. To fix this in such bigjoiner configurations, we should only increment affected crtcs if that CRTC is enabled in UAPI not if it is just used internally in the driver to split the mode. v3: Add the same uapi crtc_state->enable check in requested crtc calc (Ville) Cc: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Cc: Simon Ser <contact(a)emersion.fr> Cc: Pekka Paalanen <pekka.paalanen(a)collabora.co.uk> Cc: Daniel Stone <daniels(a)collabora.com> Cc: Daniel Vetter <daniel.vetter(a)intel.com> Cc: dri-devel(a)lists.freedesktop.org Cc: <stable(a)vger.kernel.org> # v5.11+ Fixes: 919c2299a893 ("drm/i915: Enable bigjoiner") Signed-off-by: Manasi Navare <manasi.d.navare(a)intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala(a)linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211004115913.23889-1-manasi… Signed-off-by: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> --- drivers/gpu/drm/drm_atomic.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1310,8 +1310,10 @@ int drm_atomic_check_only(struct drm_ato DRM_DEBUG_ATOMIC("checking %p\n", state); - for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) - requested_crtc |= drm_crtc_mask(crtc); + for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) { + if (new_crtc_state->enable) + requested_crtc |= drm_crtc_mask(crtc); + } for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) { ret = drm_atomic_plane_check(old_plane_state, new_plane_state); @@ -1360,8 +1362,10 @@ int drm_atomic_check_only(struct drm_ato } } - for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) - affected_crtc |= drm_crtc_mask(crtc); + for_each_new_crtc_in_state(state, crtc, new_crtc_state, i) { + if (new_crtc_state->enable) + affected_crtc |= drm_crtc_mask(crtc); + } /* * For commits that allow modesets drivers can add other CRTCs to the Patches currently in stable-queue which might be from manasi.d.navare(a)intel.com are queue-5.16/drm-atomic-add-the-crtc-to-affected-crtc-only-if-uapi.enable-true.patch

1 0

[PATCH] drm/i915: Fix a race between vma / object destruction and unbinding
by Thomas Hellström 29 Jan '22

29 Jan '22

The vma destruction code was using an unlocked advisory check for drm_mm_node_allocated() to avoid racing with eviction code unbinding the vma. This is very fragile and prohibits the dereference of non-refcounted pointers of dying vmas after a call to __i915_vma_unbind(). It also prohibits the dereference of vma->obj of refcounted pointers of dying vmas after a call to __i915_vma_unbind(), since even if a refcount is held on the vma, that won't guarantee that its backing object doesn't get destroyed. So introduce an unbind under the vm mutex at object destroy time, removing all weak references of the vma and its object from the object vma list and from the vm bound list. Signed-off-by: Thomas Hellström <thomas.hellstrom(a)linux.intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c index 1a9e1f940a7d..e03e362d320b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c @@ -280,6 +280,12 @@ void __i915_gem_object_pages_fini(struct drm_i915_gem_object *obj) GEM_BUG_ON(vma->obj != obj); spin_unlock(&obj->vma.lock); + /* Verify that the vma is unbound under the vm mutex. */ + mutex_lock(&vma->vm->mutex); + atomic_and(~I915_VMA_PIN_MASK, &vma->flags); + __i915_vma_unbind(vma); + mutex_unlock(&vma->vm->mutex); + __i915_vma_put(vma); spin_lock(&obj->vma.lock); -- 2.34.1

3 3

← Newer
1
...
19
20
21
22
23
24
25
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2022