dri-devel January 2022

dri-devel@lists.freedesktop.org

373 participants
842 discussions

[PATCH 0/3] lib/string_helpers: Add a few string helpers
by Lucas De Marchi 26 Jan '22

26 Jan '22

Add some helpers under lib/string_helpers.h so they can be used throughout the kernel. When I started doing this there were 2 other previous attempts I know of, not counting the iterations each of them had: 1) https://lore.kernel.org/all/20191023131308.9420-1-jani.nikula@intel.com/ 2) https://lore.kernel.org/all/20210215142137.64476-1-andriy.shevchenko@linux.… Going through the comments I tried to find some common ground and justification for what is in here, addressing some of the concerns raised. a. This version should be a drop-in replacement for what is currently in the tree, with no change in behavior or binary size. For binary size what I checked wat that the linked objects in the end have the same size (gcc 11). From comments in the previous attempts this seems also the case for earlier compiler versions b. I didn't change the function name to choice_* as suggested by Andrew Morton in 20191023155619.43e0013f0c8c673a5c508c1e(a)linux-foundation.org because other people argumented in favor of shorter names for these simple helpers - if they are long and people simply not use due to that, we failed c. Use string_helper.h for these helpers - pulling string.h in the compilations units was one of the concerns and I think re-using this already existing header is better than creating a new string-choice.h d. This doesn't bring onoff() helper as there are some places in the kernel with onoff as variable - another name is probably needed for this function in order not to shadow the variable, or those variables could be renamed. Or if people wanting <someprefix> try to find a short one e. One alternative to all of this suggested by Christian König (43456ba7-c372-84cc-4949-dcb817188e21(a)amd.com) would be to add a printk format. But besides the comment, he also seemed to like the common function. This brought the argument from others that the simple yesno()/enabledisable() already used in the code is easier to remember and use than e.g. %py[DOY] Last patch also has some additional conversion of open coded cases. I preferred starting with drm/ since this is "closer to home". I hope this is a good summary of the previous attempts and a way we can move forward. Andrew Morton, Petr Mladek, Andy Shevchenko: if this is accepted, my proposal is to take first 2 patches either through mm tree or maybe vsprintf. Last patch can be taken later through drm. thanks Lucas De Marchi Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: Andrew Morton <akpm(a)linux-foundation.org> Cc: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> Cc: Andy Shevchenko <andy.shevchenko(a)gmail.com> Cc: Ben Skeggs <bskeggs(a)redhat.com> Cc: Christian König <christian.koenig(a)amd.com> Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: David Airlie <airlied(a)linux.ie> Cc: David S. Miller <davem(a)davemloft.net> Cc: Emma Anholt <emma(a)anholt.net> Cc: Eryk Brol <eryk.brol(a)amd.com> Cc: Francis Laniel <laniel_francis(a)privacyrequired.com> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: Harry Wentland <harry.wentland(a)amd.com> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Julia Lawall <julia.lawall(a)lip6.fr> Cc: Kentaro Takeda <takedakn(a)nttdata.co.jp> Cc: Leo Li <sunpeng.li(a)amd.com> Cc: Mikita Lipski <mikita.lipski(a)amd.com> Cc: Petr Mladek <pmladek(a)suse.com> Cc: Rahul Lakkireddy <rahul.lakkireddy(a)chelsio.com> Cc: Raju Rangoju <rajur(a)chelsio.com> Cc: Rasmus Villemoes <linux(a)rasmusvillemoes.dk> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Sakari Ailus <sakari.ailus(a)linux.intel.com> Cc: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> Cc: Steven Rostedt <rostedt(a)goodmis.org> Cc: Vishal Kulkarni <vishal(a)chelsio.com> Lucas De Marchi (3): lib/string_helpers: Consolidate yesno() implementation lib/string_helpers: Add helpers for enable[d]/disable[d] drm: Convert open yes/no strings to yesno() drivers/gpu/drm/amd/amdgpu/atom.c | 3 ++- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 +----- drivers/gpu/drm/drm_client_modeset.c | 3 ++- drivers/gpu/drm/drm_dp_helper.c | 3 ++- drivers/gpu/drm/drm_gem.c | 3 ++- drivers/gpu/drm/i915/i915_utils.h | 15 --------------- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c | 4 +++- drivers/gpu/drm/radeon/atom.c | 3 ++- drivers/gpu/drm/v3d/v3d_debugfs.c | 11 ++++++----- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 3 ++- .../net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 11 ----------- include/linux/string_helpers.h | 4 ++++ security/tomoyo/audit.c | 2 +- security/tomoyo/common.c | 18 ++++-------------- security/tomoyo/common.h | 1 - 15 files changed, 31 insertions(+), 59 deletions(-) -- 2.34.1

10 32

[PATCH v1 1/4] ARM: dts: imx6dl-prtvt7: Add display and panel nodes
by Oleksij Rempel 26 Jan '22

26 Jan '22

Add Innolux G070Y2-T02 panel to the Protonic VT7 board. Signed-off-by: Robin van der Gracht <robin(a)protonic.nl> Signed-off-by: Oleksij Rempel <o.rempel(a)pengutronix.de> --- arch/arm/boot/dts/imx6dl-prtvt7.dts | 47 +++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts index 190d26642bc8..be7c4cb339e7 100644 --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts @@ -28,6 +28,30 @@ backlight_lcd: backlight-lcd { power-supply = <&reg_bl_12v0>; }; + display { + compatible = "fsl,imx-parallel-display"; + pinctrl-0 = <&pinctrl_ipu1_disp>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + display_in: endpoint { + remote-endpoint = <&ipu1_di0_disp0>; + }; + }; + + port@1 { + reg = <1>; + + display_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; + keys { compatible = "gpio-keys"; autorepeat; @@ -135,6 +159,18 @@ led-debug0 { }; }; + panel { + compatible = "innolux,g070y2-t02"; + backlight = <&backlight_lcd>; + power-supply = <&reg_3v3>; + + port { + panel_in: endpoint { + remote-endpoint = <&display_out>; + }; + }; + }; + reg_bl_12v0: regulator-bl-12v0 { compatible = "regulator-fixed"; pinctrl-names = "default"; @@ -146,6 +182,13 @@ reg_bl_12v0: regulator-bl-12v0 { enable-active-high; }; + reg_3v3: regulator-3v3 { + compatible = "regulator-fixed"; + regulator-name = "3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + reg_1v8: regulator-1v8 { compatible = "regulator-fixed"; regulator-name = "1v8"; @@ -275,6 +318,10 @@ &ipu1 { status = "okay"; }; +&ipu1_di0_disp0 { + remote-endpoint = <&display_in>; +}; + &pwm1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pwm1>; -- 2.30.2

2 7

[pull] drm/msm: drm-msm-fixes-2022-01-25 for v5.17
by Rob Clark 25 Jan '22

25 Jan '22

Hi Dave & Daniel, A few fixes for v5.17. The following changes since commit 6ed95285382d6f90a3c3a11d5806a5eb7db715c3: drm/msm/a5xx: Fix missing CP_PROTECT for SMMU on A540 (2021-12-17 15:09:46 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git drm-msm-fixes-2022-01-25 for you to fetch changes up to 6aa89ae1fb049614b7e03e24485bbfb96754a02b: drm/msm/gpu: Cancel idle/boost work on suspend (2022-01-25 08:54:41 -0800) ---------------------------------------------------------------- José Expósito (2): drm/msm/dpu: invalid parameter check in dpu_setup_dspp_pcc drm/msm/dsi: invalid parameter check in msm_dsi_phy_enable Miaoqian Lin (2): drm/msm/dsi: Fix missing put_device() call in dsi_get_phy drm/msm/hdmi: Fix missing put_device() call in msm_hdmi_get_phy Rob Clark (3): drm/msm/a6xx: Add missing suspend_count increment drm/msm/gpu: Wait for idle before suspending drm/msm/gpu: Cancel idle/boost work on suspend Xianting Tian (1): drm/msm: Fix wrong size calculation Yang Li (1): drm/msm: remove variable set but not used drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ drivers/gpu/drm/msm/adreno/adreno_device.c | 18 ++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 11 +++++++++-- drivers/gpu/drm/msm/dsi/dsi.c | 7 ++++++- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 +++- drivers/gpu/drm/msm/hdmi/hdmi.c | 7 ++++++- drivers/gpu/drm/msm/msm_drv.c | 5 +---- drivers/gpu/drm/msm/msm_gpu.c | 3 +++ drivers/gpu/drm/msm/msm_gpu.h | 3 +++ drivers/gpu/drm/msm/msm_gpu_devfreq.c | 21 +++++++++++++++++++-- 10 files changed, 70 insertions(+), 11 deletions(-)

1 0

help on CI fail for patchwork 21938
by jim.cromie＠gmail.com 25 Jan '22

25 Jan '22

this patchwork CI test is failing. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21938/fi-kbl-soraka/igt@… I dont understand what went wrong, but I dont see how patchset could be involved, it is drm.debug code, and I dont see evidence that it is even active. It would have to be explicitly enabled from user-space, via: echo 0x05 > /sys/module/drm/parameters/debug I will be resending patchset here, for another pass thru CI, so Im looking for hints more than specific fixes. tia

1 0

[Bug 215436] New: admgpu: suspend and resuming from suspend don't work
by bugzilla-daemon＠bugzilla.kernel.org 25 Jan '22

25 Jan '22

https://bugzilla.kernel.org/show_bug.cgi?id=215436 Bug ID: 215436 Summary: admgpu: suspend and resuming from suspend don't work Product: Drivers Version: 2.5 Kernel Version: 5.16-rc{1-7} Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: spasswolf(a)web.de Regression: No Created attachment 300180 --> https://bugzilla.kernel.org/attachment.cgi?id=300180&action=edit full kern.log from boot to reboot System: MSI Alpha 15 B5EEK Lapttop with newest BIOS lspci -nn 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne Root Complex [1022:1630] 00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne IOMMU [1022:1631] 00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir PCIe Dummy Host Bridge [1022:1632] 00:01.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir PCIe GPP Bridge [1022:1633] 00:02.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir PCIe Dummy Host Bridge [1022:1632] 00:02.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne PCIe GPP Bridge [1022:1634] 00:02.2 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne PCIe GPP Bridge [1022:1634] 00:02.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne PCIe GPP Bridge [1022:1634] 00:02.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne PCIe GPP Bridge [1022:1634] 00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Renoir PCIe Dummy Host Bridge [1022:1632] 00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Renoir Internal PCIe GPP Bridge to Bus [1022:1635] 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus Controller [1022:790b] (rev 51) 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC Bridge [1022:790e] (rev 51) 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 0 [1022:166a] 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 1 [1022:166b] 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 2 [1022:166c] 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 3 [1022:166d] 00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 4 [1022:166e] 00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 5 [1022:166f] 00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 6 [1022:1670] 00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Cezanne Data Fabric; Function 7 [1022:1671] 01:00.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 10 XL Upstream Port of PCI Express Switch [1002:1478] (rev c3) 02:00.0 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 10 XL Downstream Port of PCI Express Switch [1002:1479] 03:00.0 Display controller [0380]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 23 [Radeon RX 6600/6600 XT/6600M] [1002:73ff] (rev c3) 03:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 21 HDMI Audio [Radeon RX 6800/6800 XT / 6900 XT] [1002:ab28] 04:00.0 Network controller [0280]: MEDIATEK Corp. Device [14c3:0608] 05:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168] (rev 15) 06:00.0 Non-Volatile memory controller [0108]: Micron/Crucial Technology P1 NVMe PCIe SSD [c0a9:2263] (rev 03) 07:00.0 Non-Volatile memory controller [0108]: Kingston Technology Company, Inc. Device [2646:500c] (rev 01) 08:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Cezanne [1002:1638] (rev c5) 08:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] Renoir Radeon High Definition Audio Controller [1002:1637] 08:00.2 Encryption controller [1080]: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 10h-1fh) Platform Security Processor [1022:15df] 08:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne USB 3.1 [1022:1639] 08:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] Renoir/Cezanne USB 3.1 [1022:1639] 08:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. [AMD] Raven/Raven2/FireFlight/Renoir Audio Processor [1022:15e2] (rev 01) 08:00.6 Audio device [0403]: Advanced Micro Devices, Inc. [AMD] Family 17h (Models 10h-1fh) HD Audio Controller [1022:15e3] 08:00.7 Signal processing controller [1180]: Advanced Micro Devices, Inc. [AMD] Raven/Raven2/Renoir Sensor Fusion Hub [1022:15e4] When going into suspend on the above System suspend does not work properly Dec 29 13:12:38 lisa kernel: [ 52.085072] [drm] Register(0) [mmUVD_POWER_STATUS] failed to reach value 0x00000001 != 0x00000002 Dec 29 13:12:38 lisa kernel: [ 52.407841] [drm] Register(0) [mmUVD_POWER_STATUS] failed to reach value 0x00000001 != 0x00000002 resuming from suspend freezes the System: Dec 29 13:12:38 lisa kernel: [ 53.663566] [drm] reserve 0xa00000 from 0x81fe000000 for PSP TMR Dec 29 13:12:38 lisa kernel: [ 53.715562] amdgpu 0000:08:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring sdma0 test failed (-110) Dec 29 13:12:38 lisa kernel: [ 53.715805] [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <sdma_v4_0> failed -110 Dec 29 13:12:38 lisa kernel: [ 53.716007] amdgpu 0000:08:00.0: amdgpu: amdgpu_device_ip_resume failed (-110). Dec 29 13:12:38 lisa kernel: [ 53.716010] PM: dpm_run_callback(): pci_pm_resume+0x0/0xe0 returns -110 Dec 29 13:12:38 lisa kernel: [ 53.716023] amdgpu 0000:08:00.0: PM: failed to resume async: error -110 Dec 29 13:12:38 lisa kernel: [ 53.734885] amdgpu 0000:03:00.0: amdgpu: RAS: optional ras ta ucode is not available Dec 29 13:12:38 lisa kernel: [ 53.744042] amdgpu 0000:03:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available Dec 29 13:12:38 lisa kernel: [ 53.744048] amdgpu 0000:03:00.0: amdgpu: SMU is resuming... Dec 29 13:12:38 lisa kernel: [ 53.744053] amdgpu 0000:03:00.0: amdgpu: smu driver if version = 0x0000000f, smu fw if version = 0x00000012, smu fw version = 0x003b2200 (59.34.0) Dec 29 13:12:38 lisa kernel: [ 53.744059] amdgpu 0000:03:00.0: amdgpu: SMU driver if version not matched Dec 29 13:12:38 lisa kernel: [ 53.794983] amdgpu 0000:03:00.0: amdgpu: SMU is resumed successfully! Suspend and resume used to work with linux.5.15.11, the first bad commit is commit 2a50edbf10c8c56e930bfb53d8f9f00a33fd837e Author: Qingqing Zhuo <qingqing.zhuo(a)amd.com> Date: Tue Aug 17 16:29:07 2021 -0400 drm/amd/display: Apply w/a for hard hang on HPD [Why] HPD disable and enable sequences are not mutually exclusive on Linux. For HPDs that spans under 1s (i.e. HPD low = 1s), part of the disable sequence (specifically, a request to SMU to lower refclk) could come right before the call to PHY enablement, causing DMUB to access an irresponsive PHY and thus a hard hang on the system. [How] Disable 48mhz refclk off when there is any HPD status in connected state. Reviewed-by: Hersen Wu <hersenwu(a)amd.com> Acked-by: Mikita Lipski <mikita.lipski(a)amd.com> Signed-off-by: Qingqing Zhuo <qingqing.zhuo(a)amd.com> Tested-by: Daniel Wheeler <daniel.wheeler(a)amd.com> Signed-off-by: Alex Deucher <alexander.deucher(a)amd.com> .../drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 12 ++++++++++- .../amd/display/dc/irq/dcn21/irq_service_dcn21.c | 25 ++++++++++++++++++++++ .../amd/display/dc/irq/dcn21/irq_service_dcn21.h | 2 ++ drivers/gpu/drm/amd/display/dc/irq/irq_service.c | 2 +- drivers/gpu/drm/amd/display/dc/irq/irq_service.h | 4 ++++ 5 files changed, 43 insertions(+), 2 deletions(-) -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 30

[PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"
by Colin Ian King 25 Jan '22

25 Jan '22

There is a spelling mistake in a drm_err error message. Fix it. Signed-off-by: Colin Ian King <colin.i.king(a)gmail.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index 1331ff91c5b0..1ae3d1f259e3 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -3942,7 +3942,7 @@ static void guc_handle_context_reset(struct intel_guc *guc, guc_context_replay(ce); } else { drm_err(&guc_to_gt(guc)->i915->drm, - "Invalid GuC engine reset notificaion for 0x%04X on %s: banned = %d, blocked = %d", + "Invalid GuC engine reset notification for 0x%04X on %s: banned = %d, blocked = %d", ce->guc_id.id, ce->engine->name, intel_context_is_banned(ce), context_blocked(ce)); } -- 2.33.1

2 1

[PATCH] drm/i915/guc: Update guc shim control programming on newer platforms
by Daniele Ceraolo Spurio 25 Jan '22

25 Jan '22

Starting from xehpsdv, bit 0 of of the GuC shim control register has been repurposed, while bit 2 is now reserved, so we need to avoid setting those for their old meaning on newer platforms. Cc: Vinay Belgaumkar <vinay.belgaumkar(a)intel.com> Cc: Stuart Summers <stuart.summers(a)intel.com> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio(a)intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c index f773e7f35bc1a..40f7d4779c9ec 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c @@ -15,13 +15,15 @@ static void guc_prepare_xfer(struct intel_uncore *uncore) { - u32 shim_flags = GUC_DISABLE_SRAM_INIT_TO_ZEROES | - GUC_ENABLE_READ_CACHE_LOGIC | - GUC_ENABLE_MIA_CACHING | + u32 shim_flags = GUC_ENABLE_READ_CACHE_LOGIC | GUC_ENABLE_READ_CACHE_FOR_SRAM_DATA | GUC_ENABLE_READ_CACHE_FOR_WOPCM_DATA | GUC_ENABLE_MIA_CLOCK_GATING; + if (GRAPHICS_VER_FULL(uncore->i915) < IP_VER(12, 50)) + shim_flags |= GUC_DISABLE_SRAM_INIT_TO_ZEROES | + GUC_ENABLE_MIA_CACHING; + /* Must program this register before loading the ucode with DMA */ intel_uncore_write(uncore, GUC_SHIM_CONTROL, shim_flags); -- 2.25.1

2 1

[GIT PULL] etnaviv-fixes for 5.17-rc2
by Lucas Stach 25 Jan '22

25 Jan '22

Hi Dave, Daniel, this patch relaxes the submit size checks added in the last merge window. Turns out that we have existing userspace that overruns its max size target due to a bug and thus gets denied now. Regards, Lucas The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07: Linux 5.17-rc1 (2022-01-23 10:12:53 +0200) are available in the Git repository at: https://git.pengutronix.de/git/lst/linux etnaviv/fixes for you to fetch changes up to e3d26528e083e612314d4dcd713f3d5a26143ddc: drm/etnaviv: relax submit size limits (2022-01-25 19:03:11 +0100) ---------------------------------------------------------------- Lucas Stach (1): drm/etnaviv: relax submit size limits drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

1 0

[PATCH] drm/mediatek: DP HPD Detect with debounce
by Jitao Shi 25 Jan '22

25 Jan '22

DP Spec 1.4a 3.3 requires dp detect the hpd with debounce. Upstream implementations should implement HPD signal de-bouncing on an external connection. A period of 100ms should be used for detecting an HPD connect event (i.e., the event, “HPD high,” is confirmed only after HPD has been continuously asserted for 100ms). Care should be taken to not implement de-bouncing on an IRQ_HPD and on a downstream device-generated pair of HPD disconnect/reconnect events (typically HPD shall be de-asserted for more than 2ms, but less than 100ms in this case). To cover these cases, HPD de-bounce should be implemented only after HPD low has been detected for 100ms. Timing requirements in this Standard related to the detection of HPD high are to be interpreted as applying from the completion of an implementation-dependent de-bounce period. Signed-off-by: Jitao Shi <jitao.shi(a)mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dp.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c index a256d55346a2..05f401a024a4 100644 --- a/drivers/gpu/drm/mediatek/mtk_dp.c +++ b/drivers/gpu/drm/mediatek/mtk_dp.c @@ -193,6 +193,8 @@ struct mtk_dp { struct mutex eld_lock; u8 connector_eld[MAX_ELD_BYTES]; struct drm_connector *conn; + bool need_debounce; + struct timer_list debounce_timer; }; enum mtk_dp_sdp_type { @@ -2217,6 +2219,9 @@ static irqreturn_t mtk_dp_hpd_event_thread(int hpd, void *dev) if (event < 0) return IRQ_HANDLED; + if (mtk_dp->need_debounce && mtk_dp->train_info.cable_plugged_in) + msleep(100); + if (mtk_dp->drm_dev) { dev_info(mtk_dp->dev, "drm_helper_hpd_irq_event\n"); drm_helper_hpd_irq_event(mtk_dp->bridge.dev); @@ -2296,6 +2301,14 @@ static irqreturn_t mtk_dp_hpd_isr_handler(struct mtk_dp *mtk_dp) mtk_dp->train_state = MTK_DP_TRAIN_STATE_STARTUP; } train_info->cable_state_change = true; + + if (train_info->cable_state_change) { + if (!train_info->cable_plugged_in) { + mod_timer(&mtk_dp->debounce_timer, jiffies + msecs_to_jiffies(100) - 1); + mtk_dp->need_debounce = false; + } + } + return IRQ_WAKE_THREAD; } @@ -2903,6 +2916,13 @@ static int mtk_dp_register_audio_driver(struct device *dev) return 0; } +static void mtk_dp_debounce_timer(struct timer_list *t) +{ + struct mtk_dp *mtk_dp = from_timer(mtk_dp, t, debounce_timer); + + mtk_dp->need_debounce = true; +} + static int mtk_dp_probe(struct platform_device *pdev) { struct mtk_dp *mtk_dp; @@ -2990,6 +3010,9 @@ static int mtk_dp_probe(struct platform_device *pdev) else mtk_dp->bridge.type = DRM_MODE_CONNECTOR_DisplayPort; + mtk_dp->need_debounce = true; + timer_setup(&mtk_dp->debounce_timer, mtk_dp_debounce_timer, 0); + mtk_dp->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_HPD; drm_bridge_add(&mtk_dp->bridge); @@ -3008,6 +3031,7 @@ static int mtk_dp_remove(struct platform_device *pdev) mtk_dp_video_mute(mtk_dp, true); mtk_dp_audio_mute(mtk_dp, true); + del_timer_sync(&mtk_dp->debounce_timer); pm_runtime_disable(&pdev->dev); -- 2.12.5

2 1

[PATCH 0/5] sysfb: Fix memory-region management
by Thomas Zimmermann 25 Jan '22

25 Jan '22

Request framebuffer memory in simpledrm and simplefb. Do a hot-unplug operation when removing fbdev firmware drivers. After being unloaded by a hardware driver, simplefb leaves behind the firmware framebuffer's platform device. This prevents other drivers from acquiring the memory as reported at [1]. Patch 1 changes the removal code of remove_conflicting_framebuffers() to remove the underlying device and the rsp memory region. Patches 2 to 4 update sysfb and its drivers. The sysfb code does no longer mark the framebuffer memory with IORESOURCE_BUSY. Instead, the device drivers acquire the memory when they probe the device. Patch 5 adds a todo item to acquire memory regions in all DRM drivers. Tested with simpledrm and simplefb. [1] https://lore.kernel.org/dri-devel/20220117180359.18114-1-zack@kde.org/ v2: * fix possible NULL deref in simpledrm (Jocelyn) * various style fixes (Javier) Javier Martinez Canillas (1): drivers/firmware: Don't mark as busy the simple-framebuffer IO resource Thomas Zimmermann (4): fbdev: Hot-unplug firmware fb devices on forced removal drm/simpledrm: Request memory region in driver fbdev/simplefb: Request memory region in driver drm: Add TODO item for requesting memory regions Documentation/gpu/todo.rst | 15 +++++++ drivers/firmware/sysfb_simplefb.c | 2 +- drivers/gpu/drm/tiny/simpledrm.c | 22 ++++++++--- drivers/video/fbdev/core/fbmem.c | 29 ++++++++++++-- drivers/video/fbdev/simplefb.c | 65 +++++++++++++++++++++---------- include/linux/fb.h | 1 + 6 files changed, 105 insertions(+), 29 deletions(-) base-commit: 0bb81b5d6db5f689b67f9d8b35323235c45e890f prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 prerequisite-patch-id: 8e52143a6cd7b8fb789e656208f6edde71d0f499 -- 2.34.1

4 9

← Newer
1
...
27
28
29
30
31
32
33
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2022