Hi all,
This patch adds support for the zpos plane prop in the VKMS driver.
It should be applied after the "drm/vkms: add support for multiple overlay planes" series [1] because this new patch takes advantage of the new constant "NUM_OVERLAY_PLANES" to set the maximum overlay plane zpos.
Notice that, as explained in the commit message, there is one test failling (plane-immutable-zpos) because of the timeout capturing CRC.
This is a known bug [2] that needs to be fixed in a different series. It happens when the primary plane is disabled. The vkms_composer.c vkms_composer_worker() function is not able to find the "primary_composer" variable and the test fails.
As a quick fix, commenting the line:
if (act_plane->base.base.plane->type == DRM_PLANE_TYPE_PRIMARY)
Fixes the issue. However, more work is required to properly clear the background and blend the first active plane. I'll look into it, feedback from someone that already investigated the issue is welcome :)
Thanks in advance, José Expósito
[1] https://lore.kernel.org/dri-devel/20211226104059.11265-1-jose.exposito89@gma... [2] https://www.kernel.org/doc/html/latest/gpu/vkms.html#igt-better-support
José Expósito (1): drm/vkms: add zpos plane property
drivers/gpu/drm/vkms/vkms_crtc.c | 3 +-- drivers/gpu/drm/vkms/vkms_drv.c | 1 + drivers/gpu/drm/vkms/vkms_plane.c | 23 +++++++++++++++++++++++ 3 files changed, 25 insertions(+), 2 deletions(-)