On Tue, 14 Jun 2022 at 09:52, AngeloGioacchino Del Regno angelogioacchino.delregno@collabora.com wrote:
Il 13/06/22 18:37, Nícolas F. R. A. Prado ha scritto:
While parsing the DT, the anx7625 driver checks for the presence of a panel bridge on endpoint 1. If it is missing, pdata->panel_bridge stores the error pointer and the function returns successfully without first cleaning that variable. This is an issue since other functions later check for the presence of a panel bridge by testing the trueness of that variable.
In order to ensure proper behavior, zero out pdata->panel_bridge before returning when no panel bridge is found.
Fixes: 9e82ea0fb1df ("drm/bridge: anx7625: switch to devm_drm_of_get_bridge") Signed-off-by: Nícolas F. R. A. Prado nfraprado@collabora.com
I would've preferred s/zero out/cleanup/g but it's also fine as you wrote it. Besides, good catch!
Reviewed-by: AngeloGioacchino Del Regno angelogioacchino.delregno@collabora.com
Applied to drm-misc-next