Hi Felix,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210331] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.12-rc5 v5.12-rc4 v5.12-rc3 v5.12-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM-me... base: 7a43c78d0573e0bbbb0456b033e2b9a895b89464 config: x86_64-randconfig-a011-20210401 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/31c45957000fde18a71d7e93c0d6be26bc45... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712 git checkout 31c45957000fde18a71d7e93c0d6be26bc45a239 # save the attached .config to linux build tree make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:194:1: warning: no previous prototype for 'svm_migrate_copy_done' [-Wmissing-prototypes] 194 | svm_migrate_copy_done(struct amdgpu_device *adev, struct dma_fence *mfence) | ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:283:6: warning: no previous prototype for 'svm_migrate_put_sys_page' [-Wmissing-prototypes]
283 | void svm_migrate_put_sys_page(unsigned long addr) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c: In function 'svm_migrate_fini': drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c:875:2: error: implicit declaration of function 'memunmap_pages'; did you mean 'memcmp_pages'? [-Werror=implicit-function-declaration] 875 | memunmap_pages(&adev->kfd.dev->pgmap); | ^~~~~~~~~~~~~~ | memcmp_pages cc1: some warnings being treated as errors
Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for DEVICE_PRIVATE Depends on ZONE_DEVICE Selected by - HSA_AMD && HAS_IOMEM && DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
vim +/svm_migrate_put_sys_page +283 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_migrate.c
282
283 void svm_migrate_put_sys_page(unsigned long addr)
284 { 285 struct page *page; 286 287 page = pfn_to_page(addr >> PAGE_SHIFT); 288 unlock_page(page); 289 put_page(page); 290 } 291
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org