Re: [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses

Hi Matt,

...

diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 95174938b160..3c984553d86f 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)

i915_perf_init(dev_priv);

• intel_gt_init_hw_early(to_gt(dev_priv), &dev_priv->ggtt);

Does moving this call earlier in the function need to happen in patch #13 rather than here? That patch converts the internals of i915_ggtt_probe_hw() to use to_gt()->ggtt, but I believe until this patch that pointer is uninitialized.

yes... you cought me lazy... I will move it to #13.

Thanks, Andi