Re: [Intel-gfx] [PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks

Hi Jim,

On Sat, 31 Jul 2021 at 22:42, Jim Cromie jim.cromie@gmail.com wrote:

+struct dyndbg_bitdesc {

•   /* bitpos is inferred from index in containing array */
  

•   char *prefix;
  

•   char *help;
  

AFAICT these two should also be constant, right?

+int param_set_dyndbg(const char *instr, const struct kernel_param *kp) +{

•   unsigned int val;
  

•   unsigned long changes, result;
  

•   int rc, chgct = 0, totct = 0, bitpos, bitsmax;
  

•   char query[OUR_QUERY_SIZE];
  

•   struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;
  

•   // pr_info("set_dyndbg: instr: %s curr: %d\n", instr, *kp->arg);
  

Left-over debug code, here and below?

-Emil