Hi Nikolaus,
Le sam., févr. 12 2022 at 16:50:54 +0100, H. Nikolaus Schaller hns@goldelico.com a écrit :
There is no hpd-gpio installed on the CI20 board HDMI connector. Hence there is no hpd detection by the connector driver and we have to enable polling by the dw-hdmi driver.
We need to set .poll_enabled but that struct component can only be accessed in the core code. Hence we use the public setter function drm_kms_helper_hotplug_event().
As I said in your v13 - if you move your patch [2/7] after the patch [5/7] then you can drop this patch (merge it with the patch that introduces ingenic-dw-hdmi.c).
Otherwise between the introduction of the driver and the hotplug detection fix, the driver is not usable.
Cheers, -Paul
Signed-off-by: H. Nikolaus Schaller hns@goldelico.com
drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c b/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c index 34e986dd606cf..90547a28dc5c7 100644 --- a/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c +++ b/drivers/gpu/drm/ingenic/ingenic-dw-hdmi.c @@ -55,6 +55,8 @@ ingenic_dw_hdmi_mode_valid(struct dw_hdmi *hdmi, void *data, if (mode->clock > 216000) return MODE_CLOCK_HIGH;
- dw_hdmi_enable_poll(hdmi, true);
- return MODE_OK;
}
-- 2.33.0