Re: [PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge

On Sat, Dec 11, 2021 at 1:07 AM Linus Walleij linus.walleij@linaro.org wrote:

On Fri, Dec 10, 2021 at 6:49 PM Jagan Teki jagan@amarulasolutions.com wrote:

...

•           dev_info(dev, "connected to panel\n");
  

•           d->panel = panel;
  

How does this assignment happen after your patch? I'm using that...

devm_drm_of_get_bridge() needs some more argument right?

Actually it is only used in unbind right below:

if (d->panel) drm_panel_bridge_remove(d->bridge_out);

If it is not needed at all after your patch (because devm removes the bridge) then also delete this code, and delete the struct drm_panel *panel from struct mcde_dsi at the top and possibly also drop the header #include <drm/drm_panel.h> entirely.

Yours, Linus Walleij