Re: [PATCH] dma-buf: deprecate DMABUF_SYSFS_STATS

On Fri, Jun 17, 2022 at 1:57 AM Christian König ckoenig.leichtzumerken@gmail.com wrote:

Add a warning that this UAPI wasn't such a good idea and shouldn't be used by anybody.

That should give us a better chance to remove it at some point and prevents others from running into the same issues.

Signed-off-by: Christian König christian.koenig@amd.com

drivers/dma-buf/Kconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig index 541efe01abc7..e4dc53a36428 100644 --- a/drivers/dma-buf/Kconfig +++ b/drivers/dma-buf/Kconfig @@ -75,7 +75,7 @@ menuconfig DMABUF_HEAPS between drivers.

menuconfig DMABUF_SYSFS_STATS

•   bool "DMA-BUF sysfs statistics"
  

•   bool "DMA-BUF sysfs statistics (DEPRECATED)"
    depends on DMA_SHARED_BUFFER
    help
       Choose this option to enable DMA-BUF sysfs statistics
  

@@ -85,6 +85,10 @@ menuconfig DMABUF_SYSFS_STATS statistics for the DMA-BUF with the unique inode number <inode_number>.

•      This option is deprecated and should sooner or later be removed.
  

•      Android is the only user of this and it turned out that this resulted
  

•      in quite some performance problems.
  

source "drivers/dma-buf/heaps/Kconfig"

endmenu

2.25.1

Reviewed-by: T.J. Mercier tjmercier@google.com