Re: [PATCH v4 2/7] moduleparam: add data member to struct kernel_param

Hi Jim,

On Sat, 31 Jul 2021 at 22:42, Jim Cromie jim.cromie@gmail.com wrote:

Use of this new data member will be rare, it might be worth redoing this as a separate/sub-type to keep the base case.

Signed-off-by: Jim Cromie jim.cromie@gmail.com

include/linux/moduleparam.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h index eed280fae433..e9495b1e794d 100644 --- a/include/linux/moduleparam.h +++ b/include/linux/moduleparam.h @@ -78,6 +78,7 @@ struct kernel_param { const struct kparam_string *str; const struct kparam_array *arr; };

•   void *data;
  

Might as well make this "const void *" since it is a compile-time constant?

-Emil